https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157306&action=edit Bug 35081: Make it possible to translate catalog concern status messages The JavaScript in both OPAC and staff interface for submitting catalog concerns contains English strings which are not properly wrapped with the __() function to allow for translation. This patch fixes both affected files. The patch also modifies the dialog classes used in the staff interface so that the messages are styled consistently. To test, apply the patch and update a translation, e.g. fr-FR: - perl misc/translator/translate update fr-FR - Edit the updated po file for the language you chose, e.g. misc/translator/po/fr-FR-messages-js.po, to fill in translated strings for the two catalog concern entries. For example: koha-tmpl/intranet-tmpl/prog/js/modals/add_catalog_concern.js:38 koha-tmpl/opac-tmpl/bootstrap/js/modals/catalog_concern.js:55 msgid "Your concern was sucessfully submitted." msgstr "" - Install the updated po file: - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Enable the " CatalogConcerns" preference if necessary. - Locate a bibliographic record in the staff interface and view the detail page - From the toolbar, choose New -> New catalog concern. - Test submitting the form. When the form is submitted a message should display on the page: "Your concern was sucessfully submitted" - Perform the same test in the OPAC, where the "Report a concern" link is in the right-hand sidebar menu of the bibliographic detail page. - Perform the same tests, in both OPAC and staff interface, in your translated language to confirm that the translations show up correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157306|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157358&action=edit Bug 35081: Make it possible to translate catalog concern status messages The JavaScript in both OPAC and staff interface for submitting catalog concerns contains English strings which are not properly wrapped with the __() function to allow for translation. This patch fixes both affected files. The patch also modifies the dialog classes used in the staff interface so that the messages are styled consistently. To test, apply the patch and update a translation, e.g. fr-FR: - perl misc/translator/translate update fr-FR - Edit the updated po file for the language you chose, e.g. misc/translator/po/fr-FR-messages-js.po, to fill in translated strings for the two catalog concern entries. For example: koha-tmpl/intranet-tmpl/prog/js/modals/add_catalog_concern.js:38 koha-tmpl/opac-tmpl/bootstrap/js/modals/catalog_concern.js:55 msgid "Your concern was sucessfully submitted." msgstr "" - Install the updated po file: - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Enable the " CatalogConcerns" preference if necessary. - Locate a bibliographic record in the staff interface and view the detail page - From the toolbar, choose New -> New catalog concern. - Test submitting the form. When the form is submitted a message should display on the page: "Your concern was sucessfully submitted" - Perform the same test in the OPAC, where the "Report a concern" link is in the right-hand sidebar menu of the bibliographic detail page. - Perform the same tests, in both OPAC and staff interface, in your translated language to confirm that the translations show up correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35081 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.