https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 47858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47858&action=edit Bug 15784 - Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47867&action=edit [SIGNED-OFF]Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47867|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 47976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47976&action=edit Bug 15784 [Revised] Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47976|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 47977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47977&action=edit Bug 15784 [Revised] Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47987|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47989&action=edit Bug 15784: Library deletion warning is incorrectly styled When deleting a library in Administration -> Libraries and groups, the deletion confirmation message is not styled with the standard "dialog alert" <div>. This patch modifies the confirmation markup to match the standard. Revised to include Font Awesome icons. Depends on Bug 15785. To test, apply the patch and go to Administration -> Libraries and groups. - Try deleting a library. The confirmation box should have the standard "dialog alert" class. - Test the 'confirm' and 'cancel' actions and make sure both complete correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Buttons display as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 48734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48734&action=edit [3.22.x] Bug 15784: Library deletion warning is incorrectly styled Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.