[Bug 31110] New: Use `_should_be_fk` for ReturnClaim in TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Bug ID: 31110 Summary: Use `_should_be_fk` for ReturnClaim in TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 29495 In bug 29495 we added a follow-up to fix the TestBuilder test. However, we added the change to the wrong place; Instead of forcing undefined in the test data and not creating a link, we should add the field lacking a proper foreign key to the list in _should_be_fk These are deliberately not foreign keys because they link to one of two tables.. the original and old_ version tables.. but we do add dbix::class relations for the link. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137216&action=edit Bug 31110: Move 'ReturnClaim.issue_id' to _should_be_fk This patch moves the issue_id field definition for ReturnClaim in TestBuilder to the list of 'fake' keys in _should_be_fk. Test plan 1) Run t/db_dependent/TestBuilder.t before applying the patch 2) Run t/db_dependent/TestBuilder.t after applying the patch 3) Signoff if the test passes both times. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Assignee|chris@bigballofwax.co.nz |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- It doesn't apply on master, and when fixing it I get the error for CheckoutRenewal back! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Weird.. it passed before we made the same change for CheckoutRenewals.. seems we can't add the same thing twice. We can certainly leave this one as is for now.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org