[Bug 40846] New: Job Status should not be Failed if a record import result in a item update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Bug ID: 40846 Summary: Job Status should not be Failed if a record import result in a item update Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org If you import staged records with the sole purpose of updating the items (Action if matching record found: = Ignore incoming record ; Action if no match is found:Ignore incoming record ; Check for embedded item record data = Yes ; How to process items = Replace items if ...), at the end of the operation Koha display " Failed" job status. If the items were successfully updted, the status should be Success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188230&action=edit Bug 40846: Improve handling of ignored records Currently, a jobis marked failed if there are no records added or updated. We should take ignored records into account. Additionally, I mark the job failed when the number of records processed doesn't equal the number of records in the bacth To test: 1 - Export some records from your Koha, include some with items 2 - Stage and import those records into Koha, matching on biblionumber, ignoring matcheds, updating items 3 - View the import job, it is marked failed 4 - View the batch, all records imported 5 - Apply patch, restart all 6 - Stage/import as before 7 - Job is now marked finished 8 - Records imported as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188230|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190479&action=edit Bug 40846: Improve handling of ignored records Currently, a jobis marked failed if there are no records added or updated. We should take ignored records into account. Additionally, I mark the job failed when the number of records processed doesn't equal the number of records in the bacth To test: 1 - Export some records from your Koha, include some with items 2 - Stage and import those records into Koha, matching on biblionumber, ignoring matcheds, updating items 3 - View the import job, it is marked failed 4 - View the batch, all records imported 5 - Apply patch, restart all 6 - Stage/import as before 7 - Job is now marked finished 8 - Records imported as before Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Unsponsored Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191671&action=edit Bug 40846: Improve handling of ignored records Currently, a job is marked failed if there are no records added or updated. We should take ignored records into account. Additionally, I mark the job failed when the number of records processed doesn't equal the number of records in the batch. To test: 1) Export some records from your Koha, include some with items 2) Stage and import those records into Koha, matching on biblionumber, ignoring matcheds, updating items 3) View the import job, it is marked failed 4) View the batch, all records imported 5) Apply patch, restart all 6) Stage/import as before 7) Job is now marked finished 8) Records imported as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- please add release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40846 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org