[Bug 10688] New: QueryParser doesn't recognize QP queries when used in a fielded search box
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Bug ID: 10688 Summary: QueryParser doesn't recognize QP queries when used in a fielded search box Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: jcamins@cpbibliography.com Reporter: jcamins@cpbibliography.com QA Contact: testopia@bugs.koha-community.org If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 20123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20123&action=edit Bug 10688: Don't prefix index inappropriately If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. To test: 1) Select an index in the search dropdown in the OPAC. Author is fine. 2) Enter a search term using manually entered indexes. For example: ti:cat in the hat 3) Note that the search fails. 4) Apply patch. 5) Repeat steps 1 and 2. 6) Note that the search succeeds. 7) Sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20123|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20199&action=edit Bug 10688: Don't prefix index inappropriately If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. To test: 1) Select an index in the search dropdown in the OPAC. Author is fine. 2) Enter a search term using manually entered indexes. For example: ti:cat in the hat 3) Note that the search fails. 4) Apply patch. 5) Repeat steps 1 and 2. 6) Note that the search succeeds. 7) Sign off. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- I cannot reproduce the issue. I get the same results with and without the patch. Are there some prerequisites? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- You need to have QueryParser set up, which means you have to turn on UseQueryParser and have query_parser in your koha-conf.xml: <queryparser_config>/home/jcamins/kohaclone/etc/searchengine/queryparser.yaml</queryparser_config> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jared Camins-Esakov from comment #4)
You need to have QueryParser set up, which means you have to turn on UseQueryParser and have query_parser in your koha-conf.xml: <queryparser_config>/home/jcamins/kohaclone/etc/searchengine/queryparser. yaml</queryparser_config>
Thanks, my koha-conf.xml did not contain the right path! Now I reproduce the issue and I confirm the patch fixes it. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20199|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20423&action=edit Bug 10688: Don't prefix index inappropriately If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. To test: 1) Select an index in the search dropdown in the OPAC. Author is fine. 2) Enter a search term using manually entered indexes. For example: ti:cat in the hat 3) Note that the search fails. 4) Apply patch. 5) Repeat steps 1 and 2. 6) Note that the search succeeds. 7) Sign off. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.9. Thanks Jared! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org