[Bug 34431] New: Distinguish between status and status_alias in ILL UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Bug ID: 34431 Summary: Distinguish between status and status_alias in ILL UI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com CC: pedro.amorim@ptfs-europe.com Depends on: 34223 At the moment, we're concating status and status_alias in the ILL left filters. We also have our own custom logic of what to present in the status table column, i.e. if a status_alias exists, we show that over status. This may cause confusing as some users are filtering for status, but table is showing status_alias. We need to find a way to make it obvious which status a request is at, and which status_alias (if any) is at. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34223 [Bug 34223] ILL status filter does not load immediately after selecting a backend filter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154034&action=edit Bug 34431: Add 'type' to existing_statuses method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154035&action=edit Bug 34431: Distinguish status from status_alias in filter dropdown Add a new optgroup in status dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154036&action=edit Bug 34431: Distinguish status from status_alias in table column status now always displays. status_alias shows after in italic bold if exists -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154037&action=edit Bug 34431: Update tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com, | |katrin.fischer@bsz-bw.de, | |magnus@libriotech.no, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- The following command will (hopefully) reset your ILL data and create 10k fake ILL requests (run this in DEV KTD only). 1) BEFORE APPLYING PATCH, on an empty k-t-d, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-d...) 2) Pet a cat 3) Visit /cgi-bin/koha/admin/authorised_values.pl add search for "alias", click on ILL_STATUS_ALIAS 4) Click on the "New authorized value for ILL_STATUS_ALIAS" button and add "alias_code" in authorized value and "Alias Description" in Description 5) Visit /cgi-bin/koha/ill/ill-requests.pl and click "Manage request" on a FreeForm request, click "Edit request" 6) Edit the Status and select "Alias Description", click "Submit" 7) Visit /cgi-bin/koha/ill/ill-requests.pl and select FreeForm on the "Backend:" left-side filter 8) Notice how "Status Description" status_alias is now there, mixed with all the other "real" statuses. Click on it and filter on it. Confirm it works 9) Notice the table displays "Status Description" on the "Status" table column 10) Apply patch 11) Repeat 7) Notice how "Status Description" now shows under a new optgroup "Status aliases" 12) Notice the table nows displays whatever status the request has, followed by the "Status Description" status_alias in italic bold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I'm going to implement this differently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154034|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154035|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154036|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154289&action=edit Bug 34431: Allow for x-koha-embed in ill/backends endpoint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154290&action=edit Bug 34431: Show both status and status_alias - if exists - in table column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154291&action=edit Bug 34431: Add a status_alias filter input, if any status_alias exist This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154292&action=edit Bug 34431: Update tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154034|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154301&action=edit Bug 34431: Add status and status_alias filters to clear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154034|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154405&action=edit Bug 34431: Add 'type' to existing_statuses method Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154289|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154406&action=edit Bug 34431: Allow for x-koha-embed in ill/backends endpoint Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154290|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154407&action=edit Bug 34431: Show both status and status_alias - if exists - in table column Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154291|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154408&action=edit Bug 34431: Add a status_alias filter input, if any status_alias exist This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154292|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154409&action=edit Bug 34431: Update tests Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154301|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154410&action=edit Bug 34431: Add status and status_alias filters to clear Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154999&action=edit Bug 34431: (QA follow-up) Fix duplicate backend options Prevent adding backend option if the option already exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30271 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** Bug 33685 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase and put back at SO. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154405|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161104&action=edit Bug 34431: Add 'type' to existing_statuses method Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154406|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161105&action=edit Bug 34431: Allow for x-koha-embed in ill/backends endpoint Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154407|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161106&action=edit Bug 34431: Show both status and status_alias - if exists - in table column Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154408|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161107&action=edit Bug 34431: Add a status_alias filter input, if any status_alias exist This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154409|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161108&action=edit Bug 34431: Update tests Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154410|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161109&action=edit Bug 34431: Add status and status_alias filters to clear Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154999|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161110&action=edit Bug 34431: (QA follow-up) Fix duplicate backend options Prevent adding backend option if the option already exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161104|0 |1 is obsolete| | Attachment #161105|0 |1 is obsolete| | Attachment #161106|0 |1 is obsolete| | Attachment #161107|0 |1 is obsolete| | Attachment #161108|0 |1 is obsolete| | Attachment #161109|0 |1 is obsolete| | Attachment #161110|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161129&action=edit Bug 34431: Add 'type' to existing_statuses method Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161130&action=edit Bug 34431: Allow for x-koha-embed in ill/backends endpoint Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161131&action=edit Bug 34431: Show both status and status_alias - if exists - in table column Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161132&action=edit Bug 34431: Add a status_alias filter input, if any status_alias exist This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161133&action=edit Bug 34431: Update tests Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161134&action=edit Bug 34431: Add status and status_alias filters to clear Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161135&action=edit Bug 34431: (QA follow-up) Fix duplicate backend options Prevent adding backend option if the option already exists Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36105 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36105 [Bug 36105] Add option to filter for "No status alias" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
2) Pet a cat
Love! But I didn't find a cat to pet :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, just leaving a note (unrelated to this patch) : I can no longer create a FreeForm request in the GUI, I thought we had fixed them all, but maybe not? Programming error - No CSRF token passed for POST http://localhost:8081/intranet/ill/ill-requests.pl?method=create&backend=FreeForm (referer: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm) Or it's the backend that requires fixing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #36)
Hm, just leaving a note (unrelated to this patch) : I can no longer create a FreeForm request in the GUI, I thought we had fixed them all, but maybe not?
Programming error - No CSRF token passed for POST http://localhost:8081/intranet/ill/ill-requests. pl?method=create&backend=FreeForm (referer: http://localhost:8081/cgi-bin/koha/ill/ill-requests. pl?method=create&backend=FreeForm)
Or it's the backend that requires fixing?
Hi Katrin, thanks for noticiing. FreeForm on a Koha running after the CSRF work requires the use of branch b_36243 https://github.com/PTFS-Europe/koha-ill-freeform/commits/b_36243/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Or it's the backend that requires fixing?
Hi Katrin, thanks for noticiing. FreeForm on a Koha running after the CSRF work requires the use of branch b_36243 https://github.com/PTFS-Europe/koha-ill-freeform/commits/b_36243/
That makes sense. Do we have some kind of plan on how to handle this post/close to release? Maybe a note on README or using the version settings in the plugin info? (not sure if we are really checking for these so far) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #39)
That makes sense. Do we have some kind of plan on how to handle this post/close to release? Maybe a note on README or using the version settings in the plugin info? (not sure if we are really checking for these so far)
If bug 35570 is pushed in time for 24.05 this becomes a non-issue I believe, as that is planned to supersede FreeForm. As for other backends, I've tried my best to address compatibility through get_op_param_deprecation in Illrequest.pm but csrf_token needs to exist in the POST form anyway, which means some update work will also be required unless I'm missing some other alternative. ILL backend maintainer's will need to maintain their ILL backends, as it's also the case with regular plugins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #40)
(In reply to Katrin Fischer from comment #39)
That makes sense. Do we have some kind of plan on how to handle this post/close to release? Maybe a note on README or using the version settings in the plugin info? (not sure if we are really checking for these so far)
If bug 35570 is pushed in time for 24.05 this becomes a non-issue I believe, as that is planned to supersede FreeForm.
As for other backends, I've tried my best to address compatibility through get_op_param_deprecation in Illrequest.pm but csrf_token needs to exist in the POST form anyway, which means some update work will also be required unless I'm missing some other alternative. ILL backend maintainer's will need to maintain their ILL backends, as it's also the case with regular plugins.
Thx for clarifying! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #42 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Distinguish between status |Distinguish between status |and status_alias in ILL UI |and status alias in ILL UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #40)
(In reply to Katrin Fischer from comment #39)
That makes sense. Do we have some kind of plan on how to handle this post/close to release? Maybe a note on README or using the version settings in the plugin info? (not sure if we are really checking for these so far)
If bug 35570 is pushed in time for 24.05 this becomes a non-issue I believe, as that is planned to supersede FreeForm.
Hm, we didn't manage to push it in time - anything we need to do here now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #43)
Hm, we didn't manage to push it in time - anything we need to do here now?
I don't think so, no. I've edited the README.md at FreeForm: https://github.com/PTFS-Europe/koha-ill-freeform There's a new branch 24.05.x containing the CSRF compatibility work as well as the structural changes from bug 35581 compatibility work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #44)
(In reply to Katrin Fischer from comment #43)
Hm, we didn't manage to push it in time - anything we need to do here now?
I don't think so, no. I've edited the README.md at FreeForm: https://github.com/PTFS-Europe/koha-ill-freeform
There's a new branch 24.05.x containing the CSRF compatibility work as well as the structural changes from bug 35581 compatibility work.
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org