[Bug 22803] New: Set dataTable width issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Bug ID: 22803 Summary: Set dataTable width issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- When some columns are hidden in the Serials Subscription columns settings (see bug 11976) the table shrinks due to a "style=width:0%" which is automatically added by dataTable. Solved by adding a rule in css/datatables.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11976 Assignee|oleonard@myacpl.org |arthur.suzuki@biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 [Bug 11976] Add column settings + new column "Publication date" to the subscription table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 89011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89011&action=edit Bug 22803: Fix dataTable width Test plan : 1 - Go to Administration / Configure columns 2 - check Opac/serial_notes "is hidden by defaut" 3 - search a serials on the opac and in the opac-details page, subscriptions tab, find out that the table is shrinked on the left 4 - Apply patch 5 - Find out subscription table fills the tab correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Could you add a screeshot showing the problem? I don't think I'm seeing the problem. I'm hoping there might be another way to fix it. Adding an "!important" rule is not ideal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #3 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 89016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89016&action=edit Shrinked subscription table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89035&action=edit Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I'm proposing an alternate solution. I think this is the correct way to deal with it within the options provided by DataTables. The "autowidth" option should probably be set to "false" globally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89011|0 |1 is obsolete| | Attachment #89035|0 |1 is obsolete| | --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89157&action=edit Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89157|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 89301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89301&action=edit Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org