[Bug 12833] New: Patron search no longer searches extended attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Bug ID: 12833 Summary: Patron search no longer searches extended attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 9811 introduced C4::Utils::DataTables::Members::search for searching patrons which does not use C4::Members::Search at all. This is a huge problem that will cause either duplicated code, or missing features! Case in point, the code in C4::Utils::DataTables::Members::search does not take into account searching of extended patron attributes, which introduces a regression. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't know how to fix that. When should we search on the patron attributes? If the search is done on the birth date, I suppose we don't want. Should we add a "patron attributes" input in the search form? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Patron attributes should be part of the default patron search. The way to fix this is to remove the database queries from C4::Utils::DataTables::Members::search and use a call to C4::Members::Search instead. (In reply to Jonathan Druart from comment #1)
I don't know how to fix that. When should we search on the patron attributes? If the search is done on the birth date, I suppose we don't want. Should we add a "patron attributes" input in the search form?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9811 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31263&action=edit Bug 12833: Patron search should search on extended attributes Before Bug 9811, the patron search searched on extended attributes. This patch restore this behavior. Test plan: 0/ Create a patron attribute PA 1/ Create a patron A (cardnumber CNA) with PA="foo" 2/ Create a patron B (cardnumber CNB) with PA="foo bar" 3/ Search for CNA should redirect on the patron detail page. 4/ Search for "foo" should display the search result with 2 results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #2)
Patron attributes should be part of the default patron search. The way to fix this is to remove the database queries from C4::Utils::DataTables::Members::search and use a call to C4::Members::Search instead.
I will try do to that later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #5 from Nick Clemens <nick@quecheelibrary.org> --- I wasn't sure if you were redoing the patch after Kyle's comment or not, current patch doesn't seem to change behavior, I can test again with new patch when ready -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Nick Clemens from comment #5)
I wasn't sure if you were redoing the patch after Kyle's comment or not, current patch doesn't seem to change behavior, I can test again with new patch when ready
Hello Nick, Could detail what does not work? I tried this patch and it seemed to work as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31263|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31335&action=edit [SIGNED OFF] Bug 12833: Patron search should search on extended attributes Before Bug 9811, the patron search searched on extended attributes. This patch restore this behavior. Test plan: 0/ Create a patron attribute PA 1/ Create a patron A (cardnumber CNA) with PA="foo" 2/ Create a patron B (cardnumber CNB) with PA="foo bar" 3/ Search for CNA should redirect on the patron detail page. 4/ Search for "foo" should display the search result with 2 results. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 --- Comment #8 from Nick Clemens <nick@quecheelibrary.org> --- My bad, I thought I had checked the box to make the attribute searchable, but apparently I had missed it. Works now -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31335|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31476&action=edit [PASSED QA] Bug 12833: Patron search should search on extended attributes Before Bug 9811, the patron search searched on extended attributes. This patch restore this behavior. Test plan: 0/ Create a patron attribute PA 1/ Create a patron A (cardnumber CNA) with PA="foo" 2/ Create a patron B (cardnumber CNB) with PA="foo bar" 3/ Search for CNA should redirect on the patron detail page. 4/ Search for "foo" should display the search result with 2 results. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 'Searchable' patron attributes can now be searched for again. Works as described, passes stests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12648 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12262 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org