[Bug 9927] New: ./debian/update-control script build glitchy debian/control file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Bug ID: 9927 Summary: ./debian/update-control script build glitchy debian/control file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com CC: robin@catalyst.net.nz example of glitchy file to follow... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- the ./debian/control file currently has syntax errors on these lines... $ grep '|' ./debian/control libcgi-pm-perl | perl-modules, libdigest-sha-perl | perl, libfile-path-perl | perl-modules, libgd-gd2-noxpm-perl | libgd-gd2-perl, libmodule-load-conditional-perl | perl-modules, libtest-simple-perl | perl-modules, libcgi-pm-perl | perl-modules, libdigest-sha-perl | perl, libfile-path-perl | perl-modules, libgd-gd2-noxpm-perl | libgd-gd2-perl, libmodule-load-conditional-perl | perl-modules, libtest-simple-perl | perl-modules, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #1)
the ./debian/control file currently has syntax errors on these lines...
ps: i'll create a patch for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
(In reply to comment #1)
the ./debian/control file currently has syntax errors on these lines...
ps: i'll create a patch for this
oops, '|' chars are allowed, so its not a syntax error http://www.debian.org/doc/debian-policy/ch-relationships.html#s-sourcebinary... but still, we can improve this script to choose the newest version of each of these packages above, rather than defaulting to the oldest version in the 'perl-modules' package -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|./debian/update-control |tweak list-deps script to |script build glitchy |build a better |debian/control file |./debian/control file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 16915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16915&action=edit Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ apply patch 2/ delete existing ./debian.control file rm ./debian.control 3/ run script ./debian.control/update-debian 4/ view new ./debian.control file more ./debian.control -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16915|0 |1 is obsolete| | --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 16916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16916&action=edit Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ apply patch 2/ delete existing file rm ./debian/control 3/ run script ./debian/update-control 4/ view new file more ./debian/control -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- Why is this necessary? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)
Why is this necessary?
its necessary, so that the latest available version of all Koha's dependency packages are installed. before this patch, this doesn't happen example.. before the patch you end up with the old version of CGI.pm from the 'perl-modules' package $CGI::revision = '$Id: CGI.pm,v 1.263 2009/02/11 16:56:37 lstein Exp $'; $CGI::VERSION='3.43'; after the patch you end up with the new version of CGI.pm from the 'libcgi-pm-perl' package $CGI::revision = '$Id: CGI.pm,v 1.266 2009/07/30 16:32:34 lstein Exp $'; $CGI::VERSION='3.49'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16997&action=edit Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Whoops wrong one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- The content of attachment 16997 has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2013-03-29 21:52:55 NZDT. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Resetting to ASSIGNED since Mason is planning on providing a new patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #7)
(In reply to comment #6)
Why is this necessary?
its necessary, so that the latest available version of all Koha's dependency packages are installed. before this patch, this doesn't happen
after some further discussion with Robin, we discovered that it was a better choice to select the version from perl's base packages, rather than the 'other' package (this was the opposite of what i initially thought) the reason is - the base perl packages have more security testing this patch always chooses the *base* perl packages, not the alternative -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16916|0 |1 is obsolete| | --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Created attachment 17670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17670&action=edit Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ apply patch 2/ rename existing file mv ./debian/control ./debian/control.old 3/ run script ./debian/update-control 4/ compare files, to see improvements diff ./debian/control ./debian/control.old -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17670|0 |1 is obsolete| | --- Comment #14 from Mason James <mtj@kohaaloha.com> --- Created attachment 17674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17674&action=edit Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ rename existing file mv ./debian/control ./debian/control.old 2/ apply patch 3/ run script ./debian/update-control 4/ compare control files, to see improvements diff ./debian/control ./debian/control.old -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #15 from Robin Sheat <robin@catalyst.net.nz> --- I'm still not sold on the need for this, in an "if it ain't broke" kinda way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Robin Sheat from comment #15)
I'm still not sold on the need for this, in an "if it ain't broke" kinda way.
Indeed. Can you supply examples of specific packages where you believe that a non-optimal version is being installed? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org