https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172466&action=edit Bug 38096: OPAC: Preparation The OPAC logic for 856 in results page and detail page has diverged. This commit ensures the 856 in the OPAC detail and search results pages are consistent, in preparation to become DRY in the following commits. With this DRY refactor, the following divergences are now aligned: - 856 block now calls AddMissingProtocol regardless of value OPACURLOpenInNewWindow (previously was only being called if OPACURLOpenInNewWindow was 0). Now it's in line with what exists in MARC21slim2OPACDetail.xsl - substring(,1,6)='image/' is also now a consideration when OPACURLOpenInNewWindow is 1. (previously was only being called if OPACURLOpenInNewWindow was 0). This is now in line with that exists in MARC21slim2OPACDetail.xsl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172468&action=edit Bug 38096: OPAC: Display 857 on detail and results pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172470&action=edit [DONT PUSH] Bug 38096: Add test data for fields 856 and 857 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172467|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 172533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172533&action=edit Bug 38096: OPAC: Move 856 logic to renderMARCOnlineResourceField utils Now that OPAC detail and search results are consitent, we can DRY this logic to its own function to be also utilized by 857 in the following commit Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172469|0 |1 is obsolete| | --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 172535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172535&action=edit Bug 38096: Staff: Display 857 to detail and results pages This work DRYs the 856 display logic to renderMARCOnlineResourceField. This was previously written in detail and results pages. Once this single function exists, 857 can also make use of it to be displayed using the same logic/features already present for 856. 1) If testing k-t-d, add the test data for test plan (skip if sandboxes): updatedatabase 2) Force reindex of this biblio by saving it, visit the biblio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 3) Click "Edit" -> "Edit record" -> "Save" 4) Open the following URL's, preferably on 4 different browser tabs (we're using biblio 76 for this test): <staff_url>/cgi-bin/koha/catalogue/search.pl?q=music (first record [76] is the one we're testing) <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 <opac_url>/cgi-bin/koha/opac-search.pl?idx=&q=music (first record [76] is the one we're testing) <opac_url>/cgi-bin/koha/opac-detail.pl?biblionumber=76 5) Verify that on all pages there are 3 instances of 856 (Online resources) and 3 instances of 857 (Online archive resources) with their respective link labels and URLs. 6) Click on the "Koha community no protocol" link for 856 and 857, notice the 'http://' protocol is added. 7) Change the values of OPACDisplay856uAsImage + Display856uAsImage and refresh the respective page. Verify it works as expected (respects the system preference). Note: This only applies for 856, not 857 (out of scope here). 8) Change the value of OPACURLOpenInNewWindow and click on the links before and after. Verify they respect the system preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Pedro! In the test, I'd add to refresh the page in step 8 after changing the pref. I hope I attached everything correctly... I don't often test bugs with many patches like this... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Patch no longer applies, updating here to come back to this later. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172532|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192376&action=edit Bug 38096: OPAC: Preparation The OPAC logic for 856 in results page and detail page has diverged. This commit ensures the 856 in the OPAC detail and search results pages are consistent, in preparation to become DRY in the following commits. With this DRY refactor, the following divergences are now aligned: - 856 block now calls AddMissingProtocol regardless of value OPACURLOpenInNewWindow (previously was only being called if OPACURLOpenInNewWindow was 0). Now it's in line with what exists in MARC21slim2OPACDetail.xsl - substring(,1,6)='image/' is also now a consideration when OPACURLOpenInNewWindow is 1. (previously was only being called if OPACURLOpenInNewWindow was 0). This is now in line with that exists in MARC21slim2OPACDetail.xsl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172534|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192378&action=edit Bug 38096: OPAC: Display 857 on detail and results pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172536|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192380&action=edit Bug 38096: [DONT PUSH] Add test data for fields 856 and 857 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #21)

Marcel, are you willing to QA this one? :)

My hands start shaking when I see xslt...

Sure. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #24 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- False alarm, all appears well. The first patch appears to be "removing" functionality but it's not. It's DRYing the code as it was effectively duplicated for with and without OPACURLOpenInNewWindow. This DRY work puts MARC21slim2OPACResults in line with MARC21slim2OPACDetail ensuring that the following patches converging the two do not introduce new regressions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Pedro Amorim from comment #18)

1) If testing k-t-d, add the test data for test plan (skip if sandboxes): updatedatabase Hmm. Dont like such test plans as a member of the non-ktd minority..

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192377|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192590&action=edit Bug 38096: OPAC: Move 856 logic to renderMARCOnlineResourceField utils Now that OPAC detail and search results are consitent, we can DRY this logic to its own function to be also utilized by 857 in the following commit Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192379|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192592&action=edit Bug 38096: Staff: Display 857 to detail and results pages This work DRYs the 856 display logic to renderMARCOnlineResourceField. This was previously written in detail and results pages. Once this single function exists, 857 can also make use of it to be displayed using the same logic/features already present for 856. 1) If testing k-t-d, add the test data for test plan (otherwise prep instructions below): updatedatabase 2) Force reindex of this biblio by saving it, visit the biblio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 3) Click "Edit" -> "Edit record" -> "Save" 4) Open the following URL's, preferably on 4 different browser tabs (we're using biblio 76 for this test): <staff_url>/cgi-bin/koha/catalogue/search.pl?q=music (first record [76] is the one we're testing) <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 <opac_url>/cgi-bin/koha/opac-search.pl?idx=&q=music (first record [76] is the one we're testing) <opac_url>/cgi-bin/koha/opac-detail.pl?biblionumber=76 5) Verify that on all pages there are 3 instances of 856 (Online resources) and 3 instances of 857 (Online archive resources) with their respective link labels and URLs. 6) Click on the "Koha community no protocol" link for 856 and 857, notice the 'http://' protocol is added. 7) Change the values of OPACDisplay856uAsImage + Display856uAsImage and refresh the respective page. Verify it works as expected (respects the system preference). Note: This only applies for 856, not 857 (out of scope here). 8) Change the value of OPACURLOpenInNewWindow and click on the links before and after. Verify they respect the system preference. If not on k-t-d and updatedatabase not available: perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl or koha-shell -c "perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl" <instance_name> If CLI not available (preparation on UI): A) Add field 857 to the 'Default' framework B) Edit the field: <staff_url>/cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=857&frameworkcode= C) Check the 'Editor' checkbox for subfields q, u and z (Add these if not there already) D) Edit the record in question, visit: <staff_url>/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=76 E) Click 'Settings' dropdown and pick 'Default' framework. F) Add MARC data that corresponds to the following: 3 instances of 856 as below. 3 instances of 857 as below. <datafield tag="856" ind1="4" ind2="2"> <subfield code="z">Koha community no protocol</subfield> <subfield code="u">koha-community.org/</subfield> </datafield> <datafield tag="856" ind1="4" ind2="2"> <subfield code="z">Koha community with protocol</subfield> <subfield code="u">https://koha-community.org/</subfield> </datafield> <datafield tag="856" ind1="4" ind2="2"> <subfield code="z">Koha logo image</subfield> <subfield code="q">jpeg</subfield> <subfield code="u">https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg</subfield> </datafield> <datafield tag="857" ind1="4" ind2="2"> <subfield code="z">Koha community no protocol</subfield> <subfield code="u">koha-community.org/</subfield> </datafield> <datafield tag="857" ind1="4" ind2="2"> <subfield code="z">Koha community with protocol</subfield> <subfield code="u">https://koha-community.org/</subfield> </datafield> <datafield tag="857" ind1="4" ind2="2"> <subfield code="z">KohaCon 2024 logo image</subfield> <subfield code="q">jpeg</subfield> <subfield code="u">https://2024.kohacon.org/wp-content/uploads/2024/01/kohacon24_fr_verticale_vert_noir.png</subfield> </datafield> G) At this point you're ready to start the original test plan from step 4) Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192381|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192594&action=edit Bug 38096: (QA follow-up): Fix passing string param to template Upon following original test plan after rebase, noticed that OPACDisplay856uAsImage wasn't working for 'Details' or 'Results'. The culprit was how each screen is invoking the template, passing the string param in a wrong XSL way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #34 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Marcel de Rooy from comment #33)

Please note that I am still working on this. So we are now on parallel tracks :)

Hi Marcel, appreciate your time here. My new patches are the same, just with signed-off lines added and an updated test plan in case not using k-t-d. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192590|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192814&action=edit Bug 38096: OPAC: Move 856 logic to renderMARCOnlineResourceField utils Now that OPAC detail and search results are consitent, we can DRY this logic to its own function to be also utilized by 857 in the following commit Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192592|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192816&action=edit Bug 38096: Staff: Display 857 to detail and results pages This work DRYs the 856 display logic to renderMARCOnlineResourceField. This was previously written in detail and results pages. Once this single function exists, 857 can also make use of it to be displayed using the same logic/features already present for 856. 1) If testing k-t-d, add the test data for test plan (otherwise prep instructions below): updatedatabase 2) Force reindex of this biblio by saving it, visit the biblio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 3) Click "Edit" -> "Edit record" -> "Save" 4) Open the following URL's, preferably on 4 different browser tabs (we're using biblio 76 for this test): <staff_url>/cgi-bin/koha/catalogue/search.pl?q=music (first record [76] is the one we're testing) <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 <opac_url>/cgi-bin/koha/opac-search.pl?idx=&q=music (first record [76] is the one we're testing) <opac_url>/cgi-bin/koha/opac-detail.pl?biblionumber=76 5) Verify that on all pages there are 3 instances of 856 (Online resources) and 3 instances of 857 (Online archive resources) with their respective link labels and URLs. 6) Click on the "Koha community no protocol" link for 856 and 857, notice the 'http://' protocol is added. 7) Change the values of OPACDisplay856uAsImage + Display856uAsImage and refresh the respective page. Verify it works as expected (respects the system preference). Note: This only applies for 856, not 857 (out of scope here). 8) Change the value of OPACURLOpenInNewWindow and click on the links before and after. Verify they respect the system preference. If not on k-t-d and updatedatabase not available: perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl or koha-shell -c "perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl" <instance_name> If CLI not available (preparation on UI): A) Add field 857 to the 'Default' framework B) Edit the field: <staff_url>/cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=857&frameworkcode= C) Check the 'Editor' checkbox for subfields q, u and z (Add these if not there already) D) Edit the record in question, visit: <staff_url>/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=76 E) Click 'Settings' dropdown and pick 'Default' framework. F) Add MARC data that corresponds to the following: 3 instances of 856 as below. 3 instances of 857 as below. <datafield tag="856" ind1="4" ind2="2"> <subfield code="z">Koha community no protocol</subfield> <subfield code="u">koha-community.org/</subfield> </datafield> <datafield tag="856" ind1="4" ind2="2"> <subfield code="z">Koha community with protocol</subfield> <subfield code="u">https://koha-community.org/</subfield> </datafield> <datafield tag="856" ind1="4" ind2="2"> <subfield code="z">Koha logo image</subfield> <subfield code="q">jpeg</subfield> <subfield code="u">https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg</subfield> </datafield> <datafield tag="857" ind1="4" ind2="2"> <subfield code="z">Koha community no protocol</subfield> <subfield code="u">koha-community.org/</subfield> </datafield> <datafield tag="857" ind1="4" ind2="2"> <subfield code="z">Koha community with protocol</subfield> <subfield code="u">https://koha-community.org/</subfield> </datafield> <datafield tag="857" ind1="4" ind2="2"> <subfield code="z">KohaCon 2024 logo image</subfield> <subfield code="q">jpeg</subfield> <subfield code="u">https://2024.kohacon.org/wp-content/uploads/2024/01/kohacon24_fr_verticale_vert_noir.png</subfield> </datafield> G) At this point you're ready to start the original test plan from step 4) Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192594|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192818&action=edit Bug 38096: (QA follow-up): Fix passing string param to template Upon following original test plan after rebase, noticed that OPACDisplay856uAsImage wasn't working for 'Details' or 'Results'. The culprit was how each screen is invoking the template, passing the string param in a wrong XSL way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #44 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Rebased and retested with test plan to ensure all works as before and recent changes from bug 41588 have moved over. (In reply to Marcel de Rooy from comment #35)

koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Indentation of those new 856 and 857 blocks is a bit messy. Please correct. Could we perhaps squash some patches?

Changing status for minor correction.

Marcel, thank you, submitted follow-up to fix indentation. I'm on board with squashing the patches, I organized them that way initially to ease the review (i.e. make the 'change path' more clear). If you agree, I'll leave to your best judgement in regards to squashing (I'm on board with whatever you decide). Thank you once again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192813|0 |1 is obsolete| | Attachment #192817|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 192906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192906&action=edit Bug 38096: OPAC: Preparation The OPAC logic for 856 in results page and detail page has diverged. This commit ensures the 856 in the OPAC detail and search results pages are consistent, in preparation to become DRY in the following commits. With this DRY refactor, the following divergences are now aligned: - 856 block now calls AddMissingProtocol regardless of value OPACURLOpenInNewWindow (previously was only being called if OPACURLOpenInNewWindow was 0). Now it's in line with what exists in MARC21slim2OPACDetail.xsl - substring(,1,6)='image/' is also now a consideration when OPACURLOpenInNewWindow is 1. (previously was only being called if OPACURLOpenInNewWindow was 0). This is now in line with that exists in MARC21slim2OPACDetail.xsl Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192815|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 192908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192908&action=edit Bug 38096: OPAC: Display 857 on detail and results pages Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192818|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 192910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192910&action=edit Bug 38096: (QA follow-up): Fix passing string param to template Upon following original test plan after rebase, noticed that OPACDisplay856uAsImage wasn't working for 'Details' or 'Results'. The culprit was how each screen is invoking the template, passing the string param in a wrong XSL way. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #52 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192919&action=edit Bug 38096: (QA follow-up): Fix URLLinkText -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #54 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Lucas these 2 follow-ups are very important and are fixing 2 major oversights from the original patch. Things will blow up as described in Martin's commit. The short of it is, the DRY work missed some variables that are only utilized in specific conditions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192920|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 192922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192922&action=edit Bug 38096: (follow-up) Fix missing biblionumber parameter in renderMARCOnlineResourceField The renderMARCOnlineResourceField template uses $biblionumber for the TrackClicks feature but this parameter was never declared in the template definition nor passed by any of the call sites. This caused XSLT runtime errors when TrackClicks system preference is enabled ('track' or 'anonymous') and records contain MARC fields 856 or 857 with subfield $u (URLs): Variable 'biblionumber' has not been declared. Undefined variable XPath evaluation returned no result. This patch: 1. Adds biblionumber parameter to renderMARCOnlineResourceField template 2. Passes biblionumber value in all 4 call sites (2 in Detail, 2 in Results) Test plan: 1. Enable TrackClicks: System Preferences > OPAC > TrackClicks = "track" 2. Find a bibliographic record with field 856 or 857 containing subfield $u 3. Run: yarn build (to regenerate XSLT for all languages) 4. View the record in OPAC detail and search results pages 5. Verify no XSLT errors in plack-opac-error.log 6. Verify online resource links display correctly 7. Verify links include biblionumber parameter in tracklinks.pl URLs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- t/db_dependent/Search.t is failing, I guess it's coming from here. 02:30:02 koha-1 | # XSLT::Base: runtime error: file /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl line 730 element choose 02:30:02 koha-1 | # Variable 'URLLinkText' has not been declared. 02:30:02 koha-1 | # Undefined variable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #61 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Looking into it, the URLLinkText intra fix is also required on the opac MARC21slimUtils.xsl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 --- Comment #63 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #59)

t/db_dependent/Search.t is failing, I guess it's coming from here.

02:30:02 koha-1 | # XSLT::Base: runtime error: file /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl line 730 element choose 02:30:02 koha-1 | # Variable 'URLLinkText' has not been declared. 02:30:02 koha-1 | # Undefined variable

Last patch fixes it please verify. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192966|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #67 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38096 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.