[Bug 7775] New: tools/upload-file.pl: scope $uploaded_file for plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Priority: P5 - low Change sponsored?: --- Bug ID: 7775 Assignee: gmcharlt@gmail.com Summary: tools/upload-file.pl: scope $uploaded_file for plack QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin@rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Tools Product: Koha Created attachment 8398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8398&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8398|0 |1 is obsolete| | --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 8426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8426&action=edit Bug 7775 - tools/upload-file.pl: scope $uploaded_file for plack -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alex.arnaud@biblibre.com --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- I've applied this patch and it seems to fix the problem described in title. Indeed, files upload works now but there's a (new?) problem: When the upload is done and clicking "Manage staged records" link on MARC Staging results page in order to view the details of the batch, i get an Internal Server Error. Also, in "Manage Staged MARC Records" page (list of batches) the file name is not shown on the line related to record(s) i've juste imported. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7790 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Alex, that's problem with tools/manage-marc-import.pl for which I submitted bug 7790, so you might as well sign-off this one ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7773 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7790 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- I have the same problem than in comment 2 when applying 7775 and 7790. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8426|0 |1 is obsolete| | --- Comment #5 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 8584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8584&action=edit Bug 7775 - tools/upload-file.pl: scoping for plack $uploaded_file is now scoped with our, and we set correct filename -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8584|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 8586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8586&action=edit [Signed-Off] Bug 7775 - tools/upload-file.pl: scoping for plack $uploaded_file is now scoped with our, and we set correct filename Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 --- Comment #7 from Alex Arnaud <alex.arnaud@biblibre.com> --- This patch should be pushed with 7790. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: same kind of patch as all the plack compliance patch. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7775 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org