[Bug 42754] New: Add ability to handle 98/99 sc status messages without requiring a login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 Bug ID: 42754 Summary: Add ability to handle 98/99 sc status messages without requiring a login Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The SIP2 spec doesn't require authentication ( nor does it disallow it ) for the 99 SC Status message and the 98 ACS Status response. We should add the ability to enable/disable requiring authentication for this behavior. Because this a server-wide behavior I think making it a system preference makes the most sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199840&action=edit Bug 42754: Add SIP2AllowSCStatusWithoutLogin system preference This adds a new YesNo system preference, SIP2AllowSCStatusWithoutLogin, defaulting to off. When enabled, the SIP2 server will answer an SC Status ( 99 ) message with an ACS Status ( 98 ) response without first requiring a login. This is a server-wide behavior, so a system preference is the right place for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199841&action=edit Bug 42754: Handle SC Status (99) messages without requiring a login The SIP2 spec does not require authentication for the SC Status ( 99 ) message and its ACS Status ( 98 ) response. In fact, the spec treats the 99 as the first message a self-check unit sends, with login being an optional exception "configurable on the SC". Koha's raw transport, however, requires a 93 Login before it will process anything else, and silently drops the connection on any other first message. That makes it impossible to check that the SIP2 server is alive and responding without a valid SIP login. With SIP2AllowSCStatusWithoutLogin enabled, the raw transport now answers a pre-login 99 with a 98 and keeps waiting for a login, rather than dropping the connection. send_acs_status falls back to safe defaults when there is no authenticated account yet: an anonymous ILS ( so the capability flags report N ), an empty institution id, and no patron existence check. This lets a monitoring tool confirm the SIP2 server is up without needing a SIP account. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Without setting the new preference, connect to the SIP2 server and send an SC Status message before logging in: printf '9900302.00\r' | nc 127.0.0.1 6001 Note the connection is dropped with no response! 5) Set SIP2AllowSCStatusWithoutLogin to "Allow" 6) Restart all the things! 7) Send the same SC Status message again: printf '9900302.00\r' | nc 127.0.0.1 6001 8) Note you now get back a 98 ACS Status response without logging in! 9) Set SIP2AllowSCStatusWithoutLogin back to "Don't allow" 10) Restart all the things! 11) Send the SC Status message again, note the connection is dropped again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 199842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199842&action=edit Bug 42754: Add unit tests Patch from commit d234e46 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199840|0 |1 is obsolete| | Attachment #199841|0 |1 is obsolete| | Attachment #199842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 203960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203960&action=edit Bug 42754: Add SIP2AllowSCStatusWithoutLogin system preference This adds a new YesNo system preference, SIP2AllowSCStatusWithoutLogin, defaulting to off. When enabled, the SIP2 server will answer an SC Status ( 99 ) message with an ACS Status ( 98 ) response without first requiring a login. This is a server-wide behavior, so a system preference is the right place for it. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 203961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203961&action=edit Bug 42754: Handle SC Status (99) messages without requiring a login The SIP2 spec does not require authentication for the SC Status ( 99 ) message and its ACS Status ( 98 ) response. In fact, the spec treats the 99 as the first message a self-check unit sends, with login being an optional exception "configurable on the SC". Koha's raw transport, however, requires a 93 Login before it will process anything else, and silently drops the connection on any other first message. That makes it impossible to check that the SIP2 server is alive and responding without a valid SIP login. With SIP2AllowSCStatusWithoutLogin enabled, the raw transport now answers a pre-login 99 with a 98 and keeps waiting for a login, rather than dropping the connection. send_acs_status falls back to safe defaults when there is no authenticated account yet: an anonymous ILS ( so the capability flags report N ), an empty institution id, and no patron existence check. This lets a monitoring tool confirm the SIP2 server is up without needing a SIP account. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Without setting the new preference, connect to the SIP2 server and send an SC Status message before logging in: printf '9900302.00\r' | nc 127.0.0.1 6001 Note the connection is dropped with no response! 5) Set SIP2AllowSCStatusWithoutLogin to "Allow" 6) Restart all the things! 7) Send the same SC Status message again: printf '9900302.00\r' | nc 127.0.0.1 6001 8) Note you now get back a 98 ACS Status response without logging in! 9) Set SIP2AllowSCStatusWithoutLogin back to "Don't allow" 10) Restart all the things! 11) Send the SC Status message again, note the connection is dropped again! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 203962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203962&action=edit Bug 42754: Add unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42754 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org