[Bug 32105] New: Patron lists needs to share to specific people or groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Bug ID: 32105 Summary: Patron lists needs to share to specific people or groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org If using patron lists with the batch permissions modifier plugin, there is no way to share that list with specific people or groups. It is all or nothing. This means if you use the plugin, either only one person maintains that list, or everyone with patron list permissions has access to that list, giving them power over all permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.hafen@washk12.org --- Comment #1 from Michael Hafen <michael.hafen@washk12.org> --- Sounds to me like you should file an enhancement request against the plugin, which comes from somewhere else, rather than here in Koha core. Though I agree that it should be possible to share a list with a group; I don't like the all or nothing either. My idea was to be able to share it with other staff at a certain branch, which should be a relatively easy enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I also think that the plugin doesn't make a strong enough use case here as it's basically a work around for a feature we are missing. But: I think having the option to add 'users' to a list like we can for example to for acq orders would make a nice addition. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |michael.hafen@washk12.org |ity.org | --- Comment #3 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 149475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149475&action=edit Bug 32105 - Add Library and Individual sharing modes to Patron Lists Test Plan: 1. apply patch, restart Plack, etc. 2. create or select three users, two at the same library and one not. 3. create or select a patron list owned by one of the users at the same library. 4. edit list and change sharing mode to 'Library and individuals'. 5. login as the other user at the same library and navigate to patron lists. 6. observe that the list is shared. 7. login as the third user and navigate to patron lists. 8. observe that the list is not shared with this user. 9. login as the owner of the list. 10. edit the list and add the third user as an individual. 11. login as the third user and navigate to patron lists. 12. observe that the list is now shared with the third user. 13. login as the owner of the list. 14. edit the list to change the sharing mode to 'Individuals'. 15. login as the second and third users. 16. observe that the list is not shared with the second user, but still is with the third user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 [Bug 32730] Add patron lists tab to patron details and circulation pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |matthias.le-gac@inlibro.com --- Comment #4 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Patch doesn't apply. I have this error : Applying: Bug 32105 - Add Library and Individual sharing modes to Patron Lists error: sha1 information is lacking or useless (patron_lists/patron-lists-tab.pl). error: could not build fake ancestor Patch failed at 0001 Bug 32105 - Add Library and Individual sharing modes to Patron Lists hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32105---Add-Library-and-Individual-sharing-mod-6hyf27nh.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149475|0 |1 is obsolete| | --- Comment #5 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 160679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160679&action=edit Bug 32105 - Add Library and Individual sharing modes to Patron Lists [Rebase on master 2023-12-28] Test Plan: 1. apply patch, restart Plack, etc. 2. create or select three users, two at the same library and one not. 3. create or select a patron list owned by one of the users at the same library. 4. edit list and change sharing mode to 'Library and individuals'. 5. login as the other user at the same library and navigate to patron lists. 6. observe that the list is shared. 7. login as the third user and navigate to patron lists. 8. observe that the list is not shared with this user. 9. login as the owner of the list. 10. edit the list and add the third user as an individual. 11. login as the third user and navigate to patron lists. 12. observe that the list is now shared with the third user. 13. login as the owner of the list. 14. edit the list to change the sharing mode to 'Individuals'. 15. login as the second and third users. 16. observe that the list is not shared with the second user, but still is with the third user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- I can apply the patch but when I click on the button "New patron list" I have an 500 error. I have update my DB and I have the new table "patron_lis_user" and the new shares modes. I missed something ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- My bad I found the problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 --- Comment #8 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Matthias Le Gac from comment #7)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 --- Comment #9 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Matthias Le Gac from comment #7)
My bad I found the problem
I always have the error 500 but Ithink it's a problem with my configuration of Koha. I check for signoff when i fix my problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- My configuration of Koha is good now and I always have the 500 error. The log is : [Tue Jan 09 11:47:39.080444 2024] [core:notice] [pid 6891] AH00094: Command line: '/usr/sbin/apache2' Template process failed: file error - patron_search_filters_simple: not found at /inlibro/git/koha-master-dev-matthias/C4/Templates.pm line 134. Template process failed: file error - patron_search_filters_simple: not found at /inlibro/git/koha-master-dev-matthias/C4/Templates.pm line 134. I have the 500 error when I want to create a new "Patron list" and when I don't have the patch I can create a new "Patron list". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160679|0 |1 is obsolete| | --- Comment #11 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 160783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160783&action=edit Bug 32105 - Add Library and Individual sharing modes to Patron Lists [ rebase on 2023-12-28 with fix for add-modify.tt ] Test Plan: 1. apply patch, restart Plack, etc. 2. create or select three users, two at the same library and one not. 3. create or select a patron list owned by one of the users at the same library. 4. edit list and change sharing mode to 'Library and individuals'. 5. login as the other user at the same library and navigate to patron lists. 6. observe that the list is shared. 7. login as the third user and navigate to patron lists. 8. observe that the list is not shared with this user. 9. login as the owner of the list. 10. edit the list and add the third user as an individual. 11. login as the third user and navigate to patron lists. 12. observe that the list is now shared with the third user. 13. login as the owner of the list. 14. edit the list to change the sharing mode to 'Individuals'. 15. login as the second and third users. 16. observet that the list is not shared with the second user, but still is with the third user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 --- Comment #12 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- The patron list is share with the user who isn't in the same library while the sharing mode is Library staff and individuals. And the user who isn't in the same library isn't add in the individuals list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Bug 32105 depends on bug 32730, which changed state. Bug 32730 Summary: Add patron lists tab to patron details and circulation pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org