[Bug 18777] New: Translatability: Get rid of exposed tt directives in opac-memberentry.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Bug ID: 18777 Summary: Translatability: Get rid of exposed tt directives in opac-memberentry.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The file opac-memberentry.tt exposes template directives to translation where translators should not be confronted with. Example from po file: "%s [%% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && " "hidden.defined('B_city') && hidden.defined('B_state') && hidden." "defined('B_zipcode') && hidden.defined('B_country') && hidden." "defined('B_phone') && hidden.defined('B_email') && hidden." "defined('contactnote') %%] " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 64182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64182&action=edit Bug 18777: Translatability: Get rid of exposed tt directives in opac-memberentry.tt The file opac-memberentry.tt exposes template directives to translation where translators should not be confronted with. Example from po file: "%s [%% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && " "hidden.defined('B_city') && hidden.defined('B_state') && hidden." "defined('B_zipcode') && hidden.defined('B_country') && hidden." "defined('B_phone') && hidden.defined('B_email') && hidden." "defined('contactnote') %%] " To test: - Apply patch - Verify that advanced search in OPAC the page 'your personal details' behaves as before - Verify that you can change values and submit an update request - Create a new translation for a 'language' aa-AA (perl translate create aa-AA) - Verify that template directives ar no longer exposed in aa-AA-opac-bootstrap.p -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64182|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64735&action=edit [SIGNED-OFF] Bug 18777: Translatability: Get rid of exposed tt directives in opac-memberentry.tt The file opac-memberentry.tt exposes template directives to translation where translators should not be confronted with. Example from po file: "%s [%% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && " "hidden.defined('B_city') && hidden.defined('B_state') && hidden." "defined('B_zipcode') && hidden.defined('B_country') && hidden." "defined('B_phone') && hidden.defined('B_email') && hidden." "defined('contactnote') %%] " To test: - Apply patch - Verify that advanced search in OPAC the page 'your personal details' behaves as before - Verify that you can change values and submit an update request - Create a new translation for a 'language' aa-AA (perl translate create aa-AA) - Verify that template directives ar no longer exposed in aa-AA-opac-bootstrap.p NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64735|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66646&action=edit Bug 18777: Translatability: Get rid of exposed tt directives in opac-memberentry.tt The file opac-memberentry.tt exposes template directives to translation where translators should not be confronted with. Example from po file: "%s [%% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && " "hidden.defined('B_city') && hidden.defined('B_state') && hidden." "defined('B_zipcode') && hidden.defined('B_country') && hidden." "defined('B_phone') && hidden.defined('B_email') && hidden." "defined('contactnote') %%] " To test: - Apply patch - Verify that advanced search in OPAC the page 'your personal details' behaves as before - Verify that you can change values and submit an update request - Create a new translation for a 'language' aa-AA (perl translate create aa-AA) - Verify that template directives ar no longer exposed in aa-AA-opac-bootstrap.p NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org