[Bug 16280] New: purge_suggestions.pl: Cron job log should tell number of days used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Bug ID: 16280 Summary: purge_suggestions.pl: Cron job log should tell number of days used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To reproduce (on top of Bug 13287) - Set syspref CronjobLog to "Log" - Set syspref PurgeSuggestionsOlderThan to 20 - From console, run misc/cronjobs/purge_suggestions.pl - Check entry in cgi-bin/koha/admin/preferences.pl?op=search&searchfield=log Result in log: misc/cronjobs/purge_suggestions.pl Expected: indication that value of 20 days was used - From console, run misc/cronjobs/purge_suggestions.pl -days 100 Result in log: misc/cronjobs/purge_suggestions.pl Expected: indication that value of 100 days was used -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 50298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50298&action=edit Bug 16280: purge_suggestions.pl: Cron job log should tell number of days used To test: - Apply patch - Set syspref CronjobLog to "Log" - Set syspref PurgeSuggestionsOlderThan e.g. to 20 - From console, run misc/cronjobs/purge_suggestions.pl - Check entry in cgi-bin/koha/admin/preferences.pl?op=search&searchfield=log - Verify that log entry contains number of days (20, same as in syspref) - From console, run misc/cronjobs/purge_suggestions.pl -days 100 - Verify that log entry contains number of days (100, same as in param -days) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13287 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #2 from Marc Véron <veron@veron.ch> --- Is blocked by Bug 13287 (Failed QA) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Bug 16280 depends on bug 13287, which changed state. Bug 13287 Summary: Add a system preference to define the number of days used in purge_suggestions.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50298|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80669&action=edit Bug 16280: purge_suggestions.pl: Cron job log should tell number of days used To test: - Apply patch - Set syspref CronjobLog to "Log" - Set syspref PurgeSuggestionsOlderThan e.g. to 20 - From console, run misc/cronjobs/purge_suggestions.pl - Check entry in cgi-bin/koha/admin/preferences.pl?op=search&searchfield=log - Verify that log entry contains number of days (20, same as in syspref) - From console, run misc/cronjobs/purge_suggestions.pl -days 100 - Verify that log entry contains number of days (100, same as in param -days) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80669|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80739&action=edit Bug 16280: purge_suggestions.pl: Cron job log should tell number of days used To test: - Apply patch - Set syspref CronjobLog to "Log" - Set syspref PurgeSuggestionsOlderThan e.g. to 20 - From console, run misc/cronjobs/purge_suggestions.pl - Check entry in cgi-bin/koha/admin/preferences.pl?op=search&searchfield=log - Verify that log entry contains number of days (20, same as in syspref) - From console, run misc/cronjobs/purge_suggestions.pl -days 100 - Verify that log entry contains number of days (100, same as in param -days) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org