https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 27856 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120405&action=edit Bug 28279: Re-sync mappings.yaml We are missing some changes in the mappings.yaml file: * missing staff_client/opac (bug 25325 and bug 20589) * missing mandatory (bug 19482) * sort (bug 27316) became a boolean field Which means export_elasticsearch_mappings.pl generates a file that differs a lot from the one we have in our codebase. There are also indentation changes certainly caused by the replacement of YAML with YAML::XS Test plan: 1. reset_all without this patch 2. export the mappings to a non-tracked file (ie. don't erate mappings.yaml from source) 3. Apply this patch 4. Compare both file => No change expected 5. Reset the mappings (so using the mappings.yaml after the changes from this patch) 6. Compare the tables on the UI (with and without the patch applied) => No change expected QA will use --word-diff to make sure only mandatory, sort and staff_client/opac are modified -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- There is a strange thing in the patch. Some blocks are moving (for example field Heading). Looks like the export sorts by MARC type marc21->unimarc->normarc. But for me export sorts by MARC type alphabetical : marc21->normarc->unimarc. This is in patch : Bug 23204: Fix ordering of fields in exported file o_O -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah, I think we need someone else testing. Maybe Nick. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Bug 28279 depends on bug 19482, which changed state. Bug 19482 Summary: Elasticsearch - prevent removal / editing of required indexes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.