[Bug 22791] New: Calculation differs on aqui-home/spent and ordered.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Bug ID: 22791 Summary: Calculation differs on aqui-home/spent and ordered.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Order an example with 8 * 16,99 and 42% discount, 19.45% tax. Ordered.pl is doing: get_rounded_price( quantity * price ) Other pages are: quantity * get_rounded_price( price ) The second is more correct I believe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18736 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 [Bug 18736] Problems in order calculations (rounding errors) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88968&action=edit Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Bug 22791 depends on bug 18736, which changed state. Bug 18736 Summary: Problems in order calculations (rounding errors) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thought we resolved these numbers :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #2)
Thought we resolved these numbers :)
Baby steps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88968|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 89327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89327&action=edit Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89327|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89422&action=edit Bug 22791: Unify calculation between aqui-home and ordered.pl To test: 1 - Enable order price rounding 2 - Order an example with 8 * 16,99 and 42% discount, 19.45% tax. 3 - Check ordered page - 94.17 is total 4 - Check aqui-home - 94.16 is total 5 - Apply patch 6 - Verify numbers now match Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.06 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 18.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22791 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org