[Bug 7194] New: OPAC detail and recent comments pages require corrections for XHTML validity
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Bug #: 7194 Summary: OPAC detail and recent comments pages require corrections for XHTML validity Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: ian.walls@bywatersolutions.com - unescaped ampersands - images without alt attributes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-11-08 16:48:33 UTC --- Created attachment 6255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6255 Proposed fix - Adding html filter to subtitle output to correct unescaped ampersands - Adding missing alt attributes to libravatar output - Removing unecessary markup from comments page Bonus: Adding html_break filter to output of comments to preserve line breaks -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6255|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-12 09:05:59 UTC --- Created attachment 6719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6719 Fix for Bug 7194 - OPAC detail and recent comments pages corrections for XHTML validity - Adding html filter to subtitle output to correct unescaped ampersands - Adding missing alt attributes to libravatar output - Removing unecessary markup from comments page Bonus: Adding html_break filter to output of comments to preserve line breaks Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-05 13:28:47 UTC --- Adds alts, html escapement and a new html_break filter to various large text blobs. Also removes a yui-b div. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-06 14:53:00 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |cnighswonger@foundations.ed | |u Version|rel_3_6 |rel_3_4 --- Comment #5 from Chris Nighswonger <cnighswonger@foundations.edu> 2012-01-21 05:02:32 UTC --- Patch does not apply cleanly to 3.4.x. Please rebase against 3.4.x and attach a new patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7194 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Patch doesn't apply |RESOLVED Resolution| |FIXED --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 16:03:04 UTC --- I think it's not critical to fix this bug for 3.4 that is close to EOL. It's fixed in master though, marking RESO FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org