[Bug 34848] New: SIP/Message.t is failing if the DB has been upgraded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Bug ID: 34848 Summary: SIP/Message.t is failing if the DB has been upgraded Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 34841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34841 [Bug 34841] The test suite is failing is the DB has been upgraded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155932&action=edit Bug 34848: Fix SIP/Message.t if DB has been upgraded There were a lot of failures (in the context of bug 34841) t/db_dependent/SIP/Message.t .. 2/16 # Failed test 'Found AH field as timestamp in response' # at t/db_dependent/SIP/Message.t line 820. # Failed test 'Found AH field as SQL date in response' # at t/db_dependent/SIP/Message.t line 825. # Looks like you failed 2 tests of 8. t/db_dependent/SIP/Message.t .. 3/16 # Failed test 'Desensitize flag was set for patron category not in inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1133. # got: 'N' # expected: 'Y' # Failed test 'Desensitize flag was set for empty inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1139. # got: 'N' # expected: 'Y' Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. This patch also adds some missing transaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Test plan: perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155932|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 155963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155963&action=edit Bug 34848: Fix SIP/Message.t if DB has been upgraded There were a lot of failures (in the context of bug 34841) t/db_dependent/SIP/Message.t .. 2/16 # Failed test 'Found AH field as timestamp in response' # at t/db_dependent/SIP/Message.t line 820. # Failed test 'Found AH field as SQL date in response' # at t/db_dependent/SIP/Message.t line 825. # Looks like you failed 2 tests of 8. t/db_dependent/SIP/Message.t .. 3/16 # Failed test 'Desensitize flag was set for patron category not in inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1133. # got: 'N' # expected: 'Y' # Failed test 'Desensitize flag was set for empty inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1139. # got: 'N' # expected: 'Y' Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. This patch also adds some missing transaction Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155963|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156037&action=edit Bug 34848: Fix SIP/Message.t if DB has been upgraded There were a lot of failures (in the context of bug 34841) t/db_dependent/SIP/Message.t .. 2/16 # Failed test 'Found AH field as timestamp in response' # at t/db_dependent/SIP/Message.t line 820. # Failed test 'Found AH field as SQL date in response' # at t/db_dependent/SIP/Message.t line 825. # Looks like you failed 2 tests of 8. t/db_dependent/SIP/Message.t .. 3/16 # Failed test 'Desensitize flag was set for patron category not in inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1133. # got: 'N' # expected: 'Y' # Failed test 'Desensitize flag was set for empty inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1139. # got: 'N' # expected: 'Y' Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. This patch also adds some missing transaction Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156038&action=edit Bug 34848: (QA follow-up) Resolve warn on useless constant Useless use of a constant ("Dies if sip user cannot be found") in void context at t/db_dependent/SIP/Message.t line 582. We should remove the comma.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34848 --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org