[Bug 27550] New: "Duplicate budget" does not keep users associated with that budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Bug ID: 27550 Summary: "Duplicate budget" does not keep users associated with that budget Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: koha@listes.univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org Hi, In More > Administration > Acquisitions > Budgets, it could be great when you choose to duplicate a budget from one year to the next, to be able to keep the users(aqbudgetborrowers) associated with that budget. Users are useful in particular to receive orders from a particular fund. Currently, this functionality retrieves only the owner and funds associated with a budget. This enhancement could be optionnal using a checkbox in the "duplicate budget" view to enable/disable the copy of user ? What do you think about it ? Thanks, Best, Julien Sicot Université Rennes 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like the idea of a checkbox, but feel that the current behaviour could also be seen as a bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #2 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 127400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127400&action=edit Bug 27550: "Duplicate budget" does not keep users associated with that budget Once a budget is duplicated, all the parameters are copied except the Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then you go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard@biblibre. | |com Attachment #127400|1 |0 is patch| | Attachment #127400|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #3 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 127975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127975&action=edit Bug 27550: "Duplicate budget" does not keep users associated with that budget When a budget is duplicated, Owner is copied but not Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samu.heiskanen@hypernova.fi Status|Needs Signoff |Signed Off --- Comment #4 from Samu Heiskanen <samu.heiskanen@hypernova.fi> --- The patch works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #5 from Samu Heiskanen <samu.heiskanen@hypernova.fi> --- Created attachment 127975 [details] [review] Bug 27550: "Duplicate budget" does not keep users associated with that budget When a budget is duplicated, Owner is copied but not Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127975|0 |1 is obsolete| | --- Comment #6 from Samu Heiskanen <samu.heiskanen@hypernova.fi> --- Created attachment 128050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128050&action=edit Bug 27550: "Duplicate budget" does not keep users associated with that budget When a budget is duplicated, Owner is copied but not Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Missing test coverage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would someone be willing to step up and write the necessary tests here so we can get this bug fixed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 140334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140334&action=edit Bug 27550: Add unit test for CloneBudgetHierarchy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #9)
Created attachment 140334 [details] [review] Bug 27550: Add unit test for CloneBudgetHierarchy
Thank you, Julian :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128050|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140400&action=edit Bug 27550: "Duplicate budget" does not keep users associated with that budget When a budget is duplicated, Owner is copied but not Users Test plan : Home > Administration > Budgets 1)Create a budget to allow (active or inactive) 2)Give it some funds by filling up the form, especially Owner and User(s) 3)Submit then go back to the Budgets dashboard 4)Duplicate the Budget and click on its name 5)Edit it and notice that User(s) is empty 6)Apply the patch 7)Repeat from 1) to 5) Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140334|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140401&action=edit Bug 27550: Add unit test for CloneBudgetHierarchy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Duplicate budget" does not |"Duplicate budget" does not |keep users associated with |keep users associated with |that budget |the funds Text to go in the| |Users linked to funds in release notes| |acquisitions will now be | |kept when a budget and fund | |structure is duplicated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org