[Bug 29521] New: Patron Club name hyperlinks not operational + weird CSS behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Bug ID: 29521 Summary: Patron Club name hyperlinks not operational + weird CSS behavior Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: mkstephens@lancasterseminary.edu QA Contact: testopia@bugs.koha-community.org Sometime between 20.05 and 21.05 (we skipped 20.11), the name of a patron club is now showing up in the clubs table as hyperlinked. Clicking this hyperlink doesn't do anything. I've tried to search through release notes and bugs to find what the hyperlinking is supposed to do and couldn't trace it. The screenshots in the manual and other online tutorials show that the club name was not previously hyperlinked. The hyperlink could be directed to open the enrollments list or to edit the club's settings. Both of these options are available in the Actions menu. I think it would also be okay to remove the hyperlink altogether to reduce confusion. (I'm almost ashamed to admit how many times I clicked on it thinking it was a shortcut to the enrollments list!) Also, there's a CSS style being applied to the table where every other row is highlighted yellow when the mouse pointer hovers over it. This is distracting and not helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24627 [Bug 24627] Correct style of clubs search results during hold process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127818&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127818|0 |1 is obsolete| | --- Comment #2 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 127849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127849&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127849|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127864&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the link from release notes| |thea patron club name on | |the patrons club listing | |page as it didn't work. It | |also improves the | |consistency of the table of | |patron clubs so that the | |interface is consistent | |whether you're looking at | |clubs during the holds | |process or during the clubs | |management view. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #6 from David Nind <david@davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org