http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13055|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 13057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13057&action=edit [SIGNED-OFF] Bug 8893 - show more information on printout My proposed solution eliminates the special print view page altogether and has the Print button trigger the browser's print function. I've tweaked the print stylesheet to improve the output. Normally I don't think print buttons in the interface are necessary, since a user could be expected to be able to print the page using browser controls. But I think it's best not to remove the button when people are used to seeing it. The behavior people will find now is different when clicking the button from different catalogue pages. A user on the MARC detail page, instead of getting the generic print view will get a print of the page they're on. Overall I think this is more in line with what a user would expect. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Owen, I like your patch because it removes a script :) But is it not too radical ? I would like to have at least another point of view on this new behaviour. For example, with your patch, a notice is printed on 2 pages instead of 1. For the print button: your patch gives the same result as the browser print controls. Maybe it is the opportunity to delete this button ? For discussion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13057|0 |1 is obsolete| | --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13783&action=edit Bug 8893 - show more information on printout My proposed solution eliminates the special print view page altogether and has the Print button trigger the browser's print function. I've tweaked the print stylesheet to improve the output. Normally I don't think print buttons in the interface are necessary, since a user could be expected to be able to print the page using browser controls. But I think it's best not to remove the button when people are used to seeing it. The behavior people will find now is different when clicking the button from different catalogue pages. A user on the MARC detail page, instead of getting the generic print view will get a print of the page they're on. Overall I think this is more in line with what a user would expect. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 --- Comment #8 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13803&action=edit [Signed off] Bug 8893 [Follow-up] show more information on printout This follow-up removes the old link to detailprint.pl and replaces it with an empty container as a hook for the YUI button function. The appearance and functionality should not be any different. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com --- Comment #9 from Melia Meggs <melia@bywatersolutions.com> --- Just adding my signoff to the follow up. I tried printing a record from the staff client and verified that you can see the shelving location on the printout. Looks good. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8893 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13803|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13839&action=edit Bug 8893 [Follow-up] show more information on printout This follow-up removes the old link to detailprint.pl and replaces it with an empty container as a hook for the YUI button function. The appearance and functionality should not be any different. Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch removes a ref to detailprint.pl. With JS a "Print" button is displayed (else it is not). -- You are receiving this mail because: You are watching all bug changes.