[Bug 19849] New: Rebase of bug 16621 partially reverted bug 12509
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Bug ID: 19849 Summary: Rebase of bug 16621 partially reverted bug 12509 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org Causing a string to become untranslatable again. This is the first attachment that reverted the relevant part of bug 16621 See the first part of the diff. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53252&action=diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |victor.grousset@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16621 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12509 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 70070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70070&action=edit Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by <strong> - add forgotten condition for 9999-12-31 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 70071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70071&action=edit Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface → Patron page → Restrictions → Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70070|0 |1 is obsolete| | Attachment #70071|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76650&action=edit Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by <strong> - add forgotten condition for 9999-12-31 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76651&action=edit Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface → Patron page → Restrictions → Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76650|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76719&action=edit Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by <strong> - add forgotten condition for 9999-12-31 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76651|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76720&action=edit Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface → Patron page → Restrictions → Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org