[Bug 36563] New: Item search does not search for multiple values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Bug ID: 36563 Summary: Item search does not search for multiple values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sieber@kit.edu QA Contact: testopia@bugs.koha-community.org To recreate in Master : - go to item search - select at least two home libraries (e.g. Centerville + Midway) - check that the search results will only show the results of the second selected library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |lucas@bywatersolutions.com, | |michael.skarupianski@gmail. | |com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 [Bug 34913] Upgrade DataTables from 1.10.18 to 1.13.6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164595&action=edit Bug 36563: Dirty fix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164595|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164596&action=edit Bug 36563: Dirty fix Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- 'is not' searches dont appear to be working either -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36545 [Bug 36545] Use select2 in item search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #3)
'is not' searches dont appear to be working either
Should we fix that here or separately? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
(In reply to Lucas Gass from comment #3)
'is not' searches dont appear to be working either
Should we fix that here or separately?
I filed Bug 36571 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36571 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36571 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36571 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36571 [Bug 36571] Item search is broken when using 'is not' for searching -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164673&action=edit Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164596|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164675&action=edit Bug 36563: Dirty fix Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164673|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164676&action=edit Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164676|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164677&action=edit Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36571 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36571 [Bug 36571] Item search is broken when using 'is not' for searching -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- This now only works if you are selecting multiple parameters. If you choose only 1 the search doesn't work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164677|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164756&action=edit Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. 4- Test other use cases, like 'is' and 'is not' for multiple choices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass from comment #10)
This now only works if you are selecting multiple parameters. If you choose only 1 the search doesn't work.
Thank you Lucas, I've resubmitted a new version of the patch. Can you please try and test again? Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I tried something more pretty like: my @q = $cgi->param( $p . "[]" ) // $cgi->param( $p ); But I failed. For some reason that doesn't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164756|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164857&action=edit Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. 4- Test other use cases, like 'is' and 'is not' for multiple choices Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Bug 36563 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate, | |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Pedro. This seems to be working well now with is/is not operators. Scripts are happy, passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164857|0 |1 is obsolete| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165141&action=edit Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. 4- Test other use cases, like 'is' and 'is not' for multiple choices Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Noting I see the keywords already to get this into 23.11 and 23.05 ... and we will be very happy about it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Steve, OSLRI, USA <sspohn@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sspohn@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #19 from Michelle Spinney <mspinney@clamsnet.org> --- +Aleisha -- we use this daily for database maintenance -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 --- Comment #20 from Michaela Sieber <michaela.sieber@kit.edu> --- Could this please be backported ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36930 [Bug 36930] Item search gives irrelevant results when using 2+ added filter criteria -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate, | |rel_23_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36563 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org