[Bug 15270] New: Koha::Objects->find can exploded if searching for nonexistent record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Bug ID: 15270 Summary: Koha::Objects->find can exploded if searching for nonexistent record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45254&action=edit Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45254|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45255&action=edit Bug 15270: Add regression tests for Koha::Objects->find -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45256&action=edit Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45256|Bug 15270: Make |[FOR 3.20.X ONLY] Bug description|Koha::Objects->find return |15270: Make |undef instead of crashing |Koha::Objects->find return | |undef instead of crashing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The 2 patches are for 3.20.x but it would be good to get the first one (the tests) on master too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45255|0 |1 is obsolete| | Attachment #45256|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 45262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45262&action=edit Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. Signed-off-by: Magnus Enger <magnus@libriotech.no> Set AnonymousPatron pref to a nonexistent borrowernumber. Before the patch, about.pl shows a nasty error. After applying the patch the error is gone. Tests in t/db_dependent/Objects.t pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 45263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45263&action=edit Bug 15270: Add regression tests for Koha::Objects->find Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #4)
The 2 patches are for 3.20.x but it would be good to get the first one (the tests) on master too.
I can see the bug and the solution. Can I QA myself those patches, and then pushed them on 3.20, am I supposed to wait someone else from the QA team to validate this before? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frédéric Demians from comment #7)
(In reply to Jonathan Druart from comment #4)
The 2 patches are for 3.20.x but it would be good to get the first one (the tests) on master too.
I can see the bug and the solution. Can I QA myself those patches, and then pushed them on 3.20, am I supposed to wait someone else from the QA team to validate this before?
I don't know, I think the RMaints have the responsibility of keeping their branch stable :) Since you are releasing at the end of the month, maybe it is worth to wait for another pair of eyes? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please wait for the QA team. If something is urgently needed, feel free to nudge me or one of the others about it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Katrin Fischer from comment #9)
Please wait for the QA team. If something is urgently needed, feel free to nudge me or one of the others about it.
OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45262|0 |1 is obsolete| | Attachment #45263|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45438&action=edit [PASSED QA] Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. Signed-off-by: Magnus Enger <magnus@libriotech.no> Set AnonymousPatron pref to a nonexistent borrowernumber. Before the patch, about.pl shows a nasty error. After applying the patch the error is gone. Tests in t/db_dependent/Objects.t pass. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45439&action=edit [PASSED QA] Bug 15270: Add regression tests for Koha::Objects->find Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #13 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15473 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15270 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |On 3.20.05, if release notes| |AnonymousPatron is set to a | |nonexistent borrowernumber, | |the about.pl crashes with: | |DBIC result type isn't of | |the type Borrower at | |/home/koha/src/Koha/Objects | |.pm line 87. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org