[Bug 37301] New: Further improve ERM ToolbarButton component
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Bug ID: 37301 Summary: Further improve ERM ToolbarButton component Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 37274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37274 [Bug 37274] Improvements needed for heading of Agreements and Licenses in the ERM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168709&action=edit Bug 37301: [PoC] DRY ToolbarButton This is only a PoC applied to Agreements for discussion. This is a continuation of bug 37274. Bug 37274 applied the ToolbarButton to missing components but it was mostly replacing WET for WET. This is DRYer: - All mark-up related to toolbar buttons is now written once (css class, icons, elements) - All labels are now written once (except 'Add' for translatability) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|pedro.amorim@ptfs-europe.co |jonathan.druart@gmail.com |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168739&action=edit Bug 37301: Remove methods We do not need the methods, we can emit from the template. Also rename the events to the wording more consistent with what we have. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168740&action=edit Bug 37301: Rename 'type' with 'action' 'type' is too generic. Also move to else-if and add a else block to ease debugging in case an unsupported action is passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168741&action=edit Bug 37301: Restore to For discussion. I quite liked it, we didn't need an extra method. The problem I can see is that edit and add behave differently that delete. Is that a problem? If we drop this patch we need to decide a better wording: editAgreement is IMO the action of editing an agreement. Here I think we need maybe goToEditResourceForm and goToAddResourceform for the event names. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168800&action=edit Bug 37301: PoC (Continuation): Add BaseResource and AgreementResource This is the building blocks for a much consistent approach, for example: AgreementsShow -> delete_agreement && AgreementsList -> doDelete should be DRY into AgreementResource Any WET code currently in setup for list+show of a resource can (and should) be moved into <resourceName>Resource Any WET code currently in setup for all 'resources' can (and should) be moved into BaseResource and others -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #4)
Created attachment 168741 [details] [review] Bug 37301: Restore to
If we drop this patch we need to decide a better wording: editAgreement is IMO the action of editing an agreement. Here I think we need maybe goToEditResourceForm and goToAddResourceform for the event names.
I dropped this patch. Submitted a follow-up. Let me know what you think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168827&action=edit Bug 37301: (follow-up) PoC (Continuation): Add BaseResource and AgreementResource To squash with previous patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168828&action=edit Bug 37301: Remove toToResource* methods to BaseResource -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168829&action=edit Bug 37301: Add goToResourceShow to BaseResource -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@gmail.com |testopia@bugs.koha-communit | |y.org CC| |matt.blenkinsop@ptfs-europe | |.com, | |paul.derscheid@lmscloud.de --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. One question, for discussion: Should not we have those "resource" component part of a separate directory? Not sure but wondering. 2. Next steps could be: * continue to discuss on the existing bug, iterate with the AgreementsShow and AgreementsList * once we agree on a good-enough-for-now solution we create a separate bug for the BaseComponent idea * Build 37301 on top of it * Use the BaseComponent from everywhere (yet another bug report) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168836&action=edit Bug 37301: Get rid of e.preventDefault Feels wrong to have datatable+event related args in BaseResource, remove that. The only reason we needed preventDefault was because 'show' action was a link with an href, but we dont even need that, and add 'role="button"' for cursor:pointer mouseover interaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm really exited by the work happening here.. more re-usability and DRYer code for the win.. watching closely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- This looks very promising, should offer some good improvements and hopefully can be used to try and re-implement bug 34417 (In reply to Jonathan Druart from comment #10)
1. One question, for discussion: Should not we have those "resource" component part of a separate directory? Not sure but wondering.
I think this would be sensible, the resource components don't actually render any template to the UI themselves so it might be useful to isolate them from the ones that do -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #10)
1. One question, for discussion: Should not we have those "resource" component part of a separate directory? Not sure but wondering.
2. Next steps could be: * continue to discuss on the existing bug, iterate with the AgreementsShow and AgreementsList * once we agree on a good-enough-for-now solution we create a separate bug for the BaseComponent idea * Build 37301 on top of it * Use the BaseComponent from everywhere (yet another bug report)
fwiw I'm on board with all of the above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Further improve ERM |Further improve how we |ToolbarButton component |build Vue components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172713&action=edit Bug 37301: DRY delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #15)
Created attachment 172713 [details] [review] Bug 37301: DRY delete
I would make the success "message" configurable as well. Otherwise it looks great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #16)
I would make the success "message" configurable as well. Otherwise it looks great!
Thanks! Sure, it can be further iterated on. I'm trying to limit this scope to not worrying about making flexible things that don't absolutely need it. The delete message being flexible would be nice to have as an option but I'm not considering it important right now. The main reason being every delete message we have currently is "Are you sure you want to delete x?". They're all the same and WET. Same goes for "Yes, delete" and "No, do not delete". I firmly believe these things should be written once and maintained in a single place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Sorry if it was not clear enough. I was talking about the success message, (setMessage from success). And there are not the same, that is why I am asking. I have checked before :) koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/WaitingList.vue 331 this.$__("Item removed from the waiting list"), -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #18)
Sorry if it was not clear enough. I was talking about the success message, (setMessage from success). And there are not the same, that is why I am asking.
I have checked before :)
koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/WaitingList.vue 331 this.$__("Item removed from the waiting list"),
Ah! Fair! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- Btw, would it be possible to get the components bundled as a library, which could then be imported into client-side apps? I love the idea of Koha Plugins being able to re-use Koha's Vue components by dynamically importing them at runtime. I think that Koha Plugins using Koha Vue components and Mojolicious REST API is a natural fit. (It could also make it easier to slowly refactor other parts of Koha to use Vue components.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172911&action=edit Bug 37301: Move table_url declaration to resource class This is relevant because doResourceDelete expected table_url to be implemented, but LicensesList does not implement it for example. We now have a getResourceTableUrl implemented by all resources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172912&action=edit Bug 37301: Apply changes to licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172913&action=edit Bug 37301: Apply changes to eHoldings local packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172914&action=edit Bug 37301: Restore possibility of a custom toolbar button EHoldingsLocalTitles needs this for 'Import from list' and 'Import from KBART file' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172915&action=edit Bug 37301: Apply changes to eholdings titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172916&action=edit Bug 37301: Move setWarning to BaseResource UsageStatisticsDataProvidersList needs it, and others in the future will as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172917&action=edit Bug 37301: Fix: URL param needs to match attr_id url param needs to match attr_id usage statistics is non-standard when compared to agreements+licenses etc. using usage_data_provider_id but resource id field is erm_usage_data_provider_id. This patch is fixing that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172918&action=edit Bug 37301: Add required faicon for fontawesome compnent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172919&action=edit Bug 37301: Apply changes to usage statistics data providers This is also removing UsageStatissticsDataProvidersToolbar as that is not required, and updating the UsageStatisticsDataProvidersSummary button to a ToolbarButton instead of a router-link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172920&action=edit Bug 37301: Apply changes to preservation trains Also update edit route from TrainsFormEdit to TrainsFormAddEdit for consistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172921&action=edit Bug 37301: Update cypress Local packages were named 'package' on the delete confirmation dialog, but 'local package' on the deleted confirmation message. Both these places now use the same i18n.display_name from the respective Resource component so these label tests need to be updated. Same for local titles. Test plan: cypress run --spec t/cypress/integration/ERM/DataProviders_spec.ts cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts cypress run --spec t/cypress/integration/ERM/Licenses_spec.ts cypress run --spec t/cypress/integration/ERM/Titles_spec.ts cypress run --spec t/cypress/integration/ERM/Packages_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168709|0 |1 is obsolete| | --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174612&action=edit Bug 37301: [PoC] DRY ToolbarButton This is only a PoC applied to Agreements for discussion. This is a continuation of bug 37274. Bug 37274 applied the ToolbarButton to missing components but it was mostly replacing WET for WET. This is DRYer: - All mark-up related to toolbar buttons is now written once (css class, icons, elements) - All labels are now written once (except 'Add' for translatability) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168739|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174613&action=edit Bug 37301: Remove methods We do not need the methods, we can emit from the template. Also rename the events to the wording more consistent with what we have. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168740|0 |1 is obsolete| | --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174614&action=edit Bug 37301: Rename 'type' with 'action' 'type' is too generic. Also move to else-if and add a else block to ease debugging in case an unsupported action is passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168800|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174615&action=edit Bug 37301: PoC (Continuation): Add BaseResource and AgreementResource This is the building blocks for a much consistent approach, for example: AgreementsShow -> delete_agreement && AgreementsList -> doDelete should be DRY into AgreementResource Any WET code currently in setup for list+show of a resource can (and should) be moved into <resourceName>Resource Any WET code currently in setup for all 'resources' can (and should) be moved into BaseResource and others -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168827|0 |1 is obsolete| | --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174616&action=edit Bug 37301: (follow-up) PoC (Continuation): Add BaseResource and AgreementResource To squash with previous patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168828|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174617&action=edit Bug 37301: Remove toToResource* methods to BaseResource -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168829|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174618&action=edit Bug 37301: Add goToResourceShow to BaseResource -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168836|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174619&action=edit Bug 37301: Get rid of e.preventDefault Feels wrong to have datatable+event related args in BaseResource, remove that. The only reason we needed preventDefault was because 'show' action was a link with an href, but we dont even need that, and add 'role="button"' for cursor:pointer mouseover interaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172713|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174620&action=edit Bug 37301: DRY delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172911|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174621&action=edit Bug 37301: Move table_url declaration to resource class This is relevant because doResourceDelete expected table_url to be implemented, but LicensesList does not implement it for example. We now have a getResourceTableUrl implemented by all resources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172912|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174622&action=edit Bug 37301: Apply changes to licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172913|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174623&action=edit Bug 37301: Apply changes to eHoldings local packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172914|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174624&action=edit Bug 37301: Restore possibility of a custom toolbar button EHoldingsLocalTitles needs this for 'Import from list' and 'Import from KBART file' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172915|0 |1 is obsolete| | --- Comment #45 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174625&action=edit Bug 37301: Apply changes to eholdings titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172916|0 |1 is obsolete| | --- Comment #46 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174626&action=edit Bug 37301: Move setWarning to BaseResource UsageStatisticsDataProvidersList needs it, and others in the future will as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172917|0 |1 is obsolete| | --- Comment #47 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174627&action=edit Bug 37301: Fix: URL param needs to match attr_id url param needs to match attr_id usage statistics is non-standard when compared to agreements+licenses etc. using usage_data_provider_id but resource id field is erm_usage_data_provider_id. This patch is fixing that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172918|0 |1 is obsolete| | --- Comment #48 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174628&action=edit Bug 37301: Add required faicon for fontawesome compnent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172919|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174629&action=edit Bug 37301: Apply changes to usage statistics data providers This is also removing UsageStatissticsDataProvidersToolbar as that is not required, and updating the UsageStatisticsDataProvidersSummary button to a ToolbarButton instead of a router-link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172920|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174630&action=edit Bug 37301: Apply changes to preservation trains Also update edit route from TrainsFormEdit to TrainsFormAddEdit for consistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172921|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174631&action=edit Bug 37301: Update cypress Local packages were named 'package' on the delete confirmation dialog, but 'local package' on the deleted confirmation message. Both these places now use the same i18n.display_name from the respective Resource component so these label tests need to be updated. Same for local titles. Test plan: cypress run --spec t/cypress/integration/ERM/DataProviders_spec.ts cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts cypress run --spec t/cypress/integration/ERM/Licenses_spec.ts cypress run --spec t/cypress/integration/ERM/Titles_spec.ts cypress run --spec t/cypress/integration/ERM/Packages_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #52 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I get two failing tests :/ Running: Titles_spec.ts (1 of 1) Title CRUD operations ✓ Import titles (5737ms) ✓ List title (3268ms) ✓ Add title (10740ms) ✓ Edit title (2773ms) ✓ Show title (3982ms) 1) Delete title 5 passing (39s) 1 failing 1) Title CRUD operations Delete title: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'remove this local title' within the element: <h1> but never did. at Context.eval (webpack://koha/./t/cypress/integration/ERM/Titles_spec.ts:455:49) Running: Packages_spec.ts (1 of 1) Package CRUD operations ✓ List package (6329ms) ✓ Add package (5587ms) ✓ Edit package (3546ms) ✓ Show package (4711ms) 1) Delete package 4 passing (33s) 1 failing 1) Package CRUD operations Delete package: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'remove this local package' within the element: <h1> but never did. at Context.eval (webpack://koha/./t/cypress/integration/ERM/Packages_spec.ts:281:49) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #53 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175450&action=edit Bug 37301: (QA follow-up): Fix Dialog_spec.ts Run the test spec before and after applying the patch: cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #54 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Paul Derscheid from comment #52)
I get two failing tests :/
Thanks Paul. I ran all cypress tests and the only that failed for me was the one that the follow-up patch fixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37893 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174612|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177173&action=edit Bug 37301: [PoC] DRY ToolbarButton This is only a PoC applied to Agreements for discussion. This is a continuation of bug 37274. Bug 37274 applied the ToolbarButton to missing components but it was mostly replacing WET for WET. This is DRYer: - All mark-up related to toolbar buttons is now written once (css class, icons, elements) - All labels are now written once (except 'Add' for translatability) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174613|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177174&action=edit Bug 37301: Remove methods We do not need the methods, we can emit from the template. Also rename the events to the wording more consistent with what we have. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174614|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177175&action=edit Bug 37301: Rename 'type' with 'action' 'type' is too generic. Also move to else-if and add a else block to ease debugging in case an unsupported action is passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174615|0 |1 is obsolete| | --- Comment #58 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177176&action=edit Bug 37301: PoC (Continuation): Add BaseResource and AgreementResource This is the building blocks for a much consistent approach, for example: AgreementsShow -> delete_agreement && AgreementsList -> doDelete should be DRY into AgreementResource Any WET code currently in setup for list+show of a resource can (and should) be moved into <resourceName>Resource Any WET code currently in setup for all 'resources' can (and should) be moved into BaseResource and others -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174616|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177177&action=edit Bug 37301: (follow-up) PoC (Continuation): Add BaseResource and AgreementResource To squash with previous patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174617|0 |1 is obsolete| | --- Comment #60 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177178&action=edit Bug 37301: Remove toToResource* methods to BaseResource -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174618|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177179&action=edit Bug 37301: Add goToResourceShow to BaseResource -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174619|0 |1 is obsolete| | --- Comment #62 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177180&action=edit Bug 37301: Get rid of e.preventDefault Feels wrong to have datatable+event related args in BaseResource, remove that. The only reason we needed preventDefault was because 'show' action was a link with an href, but we dont even need that, and add 'role="button"' for cursor:pointer mouseover interaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174620|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177181&action=edit Bug 37301: DRY delete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174621|0 |1 is obsolete| | --- Comment #64 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177182&action=edit Bug 37301: Move table_url declaration to resource class This is relevant because doResourceDelete expected table_url to be implemented, but LicensesList does not implement it for example. We now have a getResourceTableUrl implemented by all resources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174622|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177183&action=edit Bug 37301: Apply changes to licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174623|0 |1 is obsolete| | --- Comment #66 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177184&action=edit Bug 37301: Apply changes to eHoldings local packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174624|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177185&action=edit Bug 37301: Restore possibility of a custom toolbar button EHoldingsLocalTitles needs this for 'Import from list' and 'Import from KBART file' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174625|0 |1 is obsolete| | --- Comment #68 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177186&action=edit Bug 37301: Apply changes to eholdings titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174626|0 |1 is obsolete| | --- Comment #69 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177187&action=edit Bug 37301: Move setWarning to BaseResource UsageStatisticsDataProvidersList needs it, and others in the future will as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174627|0 |1 is obsolete| | --- Comment #70 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177188&action=edit Bug 37301: Fix: URL param needs to match attr_id url param needs to match attr_id usage statistics is non-standard when compared to agreements+licenses etc. using usage_data_provider_id but resource id field is erm_usage_data_provider_id. This patch is fixing that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174628|0 |1 is obsolete| | --- Comment #71 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177189&action=edit Bug 37301: Add required faicon for fontawesome compnent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174629|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177190&action=edit Bug 37301: Apply changes to usage statistics data providers This is also removing UsageStatissticsDataProvidersToolbar as that is not required, and updating the UsageStatisticsDataProvidersSummary button to a ToolbarButton instead of a router-link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174630|0 |1 is obsolete| | --- Comment #73 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177191&action=edit Bug 37301: Apply changes to preservation trains Also update edit route from TrainsFormEdit to TrainsFormAddEdit for consistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174631|0 |1 is obsolete| | --- Comment #74 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177192&action=edit Bug 37301: Update cypress Local packages were named 'package' on the delete confirmation dialog, but 'local package' on the deleted confirmation message. Both these places now use the same i18n.display_name from the respective Resource component so these label tests need to be updated. Same for local titles. Test plan: cypress run --spec t/cypress/integration/ERM/DataProviders_spec.ts cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts cypress run --spec t/cypress/integration/ERM/Licenses_spec.ts cypress run --spec t/cypress/integration/ERM/Titles_spec.ts cypress run --spec t/cypress/integration/ERM/Packages_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175450|0 |1 is obsolete| | --- Comment #75 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 177193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177193&action=edit Bug 37301: (QA follow-up): Fix Dialog_spec.ts Run the test spec before and after applying the patch: cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #76 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased after bug 38854 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #77 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177351&action=edit Bug 37301: Use goToResourceList - does not work (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 --- Comment #78 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #77)
Created attachment 177351 [details] [review] Bug 37301: Use goToResourceList - does not work (?)
Hey, yeah that looks like it. We (me and Matt) have been working extensively on this. And I'm very confident this is fixed in the follow-up bug. Bug 38201. Here is a commit in bug 38201 that fixes it for agreements for example: https://github.com/PTFS-Europe/koha/commit/878a136e73a5b6fbc7432f03d07b7e0b0... I understand everything should be fixed here as this is the first step, but I want to make clear that most of the vuejs rewrite work is now sitting on bug 38201. Here bug 37301 is just the first step. I say I'm very confident these things are fixed in the follow-up bug as we're building 2 new modules on top of it and have been testing and updating it frequently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #79 from Jonathan Druart <jonathan.druart@gmail.com> --- So this is not ready for testing and should be pushed along with bug 38201. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38010 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|Failed QA |RESOLVED --- Comment #80 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- The commits here have been moved (and renamed) to bug 38201. Initially, back in July 2024, and then back in October 2024, the plan was to have this piece be pushed as a first step of a larger VueJS architecture rethink. That larger VueJS architecture rethink has now been materialized in bug 38201 and, even though is not ready yet, the patches here make more sense now in the context of bug 38201. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38201 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 [Bug 38201] VueJS architecture rethink -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org