[Bug 33021] New: Show an alert when adding a reserved item to an item bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Bug ID: 33021 Summary: Show an alert when adding a reserved item to an item bundle Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 32121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 [Bug 32121] Show an alert when adding a checked out item to an item bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 147019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147019&action=edit Bug 33021: Show an alert when adding a reserved item to an item bundle Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Create a biblio with one item and place a hold for this item. 3. Try to add the reserved item to the bundle You should see a message saying that the item is reserved. Next to this message should be a button "Ignore holds and add to bundle". 4. Click on the button. There should be a message saying that the item was added to the bundle. 5. Close the modal window and verify that the item was correctly added to the bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This works as described but I do notice a 409 ( conflict ) error in the console. -http://localhost:8081/api/v1/items/974/bundled_items Is this a problem that needs addressed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Lucas Gass from comment #2)
This works as described but I do notice a 409 ( conflict ) error in the console.
-http://localhost:8081/api/v1/items/974/bundled_items
Is this a problem that needs addressed?
It's normal. It's the status code used to indicate that the item was not added to the bundle. After you click on the button you should have the same API call but with a 2XX status code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- OK, sounds good. Just one more thing to note, a complaint from the QA tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 1833) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Lucas Gass from comment #4)
forbidden pattern: simple-quote string (line 1833)
That is probably a false positive. I think this rule refer to using simple quotes inside _(), but this this patch doesn't use this function. Can someone from QA confirm ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Julian Maurice from comment #5)
(In reply to Lucas Gass from comment #4)
forbidden pattern: simple-quote string (line 1833)
That is probably a false positive. I think this rule refer to using simple quotes inside _(), but this this patch doesn't use this function. Can someone from QA confirm ?
It looks right to me and the syntax/format is exactly the same as some of the other lines directly above. I will sign-off and move this along for QA to have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147019|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147160&action=edit Bug 33021: Show an alert when adding a reserved item to an item bundle Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Create a biblio with one item and place a hold for this item. 3. Try to add the reserved item to the bundle You should see a message saying that the item is reserved. Next to this message should be a button "Ignore holds and add to bundle". 4. Click on the button. There should be a message saying that the item was added to the bundle. 5. Close the modal window and verify that the item was correctly added to the bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147160|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148665&action=edit Bug 33021: Show an alert when adding a reserved item to an item bundle Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Create a biblio with one item and place a hold for this item. 3. Try to add the reserved item to the bundle You should see a message saying that the item is reserved. Next to this message should be a button "Ignore holds and add to bundle". 4. Click on the button. There should be a message saying that the item was added to the bundle. 5. Close the modal window and verify that the item was correctly added to the bundle Signed-off-by: Lucas Gass <lucas@bywatersolutiosn.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148666&action=edit Bug 33021: (QA follow-up) Add unit test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Bug 33021 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Bug 33021 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Bug 33021 depends on bug 32121, which changed state. Bug 32121 Summary: Show an alert when adding a checked out item to an item bundle https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show an alert when adding a |Show an alert when adding |reserved item to an item |an item on hold to an item |bundle |bundle Text to go in the| |When adding an item that is release notes| |currently on hold to an | |item bundle, a warning will | |display, but you can still | |choose to add the item to | |the bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769 [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/694 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org