[Bug 38222] New: Let staff pick a cancellation reason when canceling a booking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Bug ID: 38222 Summary: Let staff pick a cancellation reason when canceling a booking Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This should either be an authorised value or free text. Applicable to all views that allow booking cancelation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | Depends on| |38193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38193 [Bug 38193] Add cancellation_reason field to bookings table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38175 [Bug 38175] Improve Bookings behavior with new status field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173230&action=edit Bug 38222: Add combobox component Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173231&action=edit Bug 38222: Add cancellation reason to bookings patch definition; reformat bookings definition Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173232&action=edit Bug 38222: Add handling for cancellation reasons to cancel booking modal template, associated script Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173233&action=edit Bug 38222: Use comboboxes in circ/circulation.pl, bookings/list.pl, members/moremember.pl To test: 1) Apply dependencies and this patch 2) Maybe update class files w/ update_dbix_class_files.pl 3) Build a new bundle w/ yarn api:bundle 4) Restart plack 5) Add a couple bookings to a patron 6) Go to any of the above modules 7) Cancel the booking and note 7.1) That the value you input is correctly received by the backend for cancellation_reason 7.2) Do it for the other 2 modules 8) Configure some authorised values under category BOOKING_CANCELLATION 9) Repeat 7 and note that you can select them in the combobox 10) Sign off or leave your feedback Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Position: fixed behaves differently in Firefox vs Chrome. In chrome the options of the combobox float around in weird ways. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173264&action=edit Bug 38222: (follow-up) Reset overflow property of modal-body to prevent clipping of combobox options instead of position: fixed Also remove the inlined styles on the unordered list. Bootstrap's dropdown handles all of this. Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173265&action=edit Bug 38222: (follow-up) Include cancellation reason in sample notice for booking cancellation Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I didn't check how we do this normally, but would it be preferable to write the AV to the db and then use the AuthorisedValues template plugin in the notice instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173277&action=edit Bug 38222: (follow-up) Remove residual inline styles from example for combobox usage Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173278&action=edit Bug 38222: (follow-up) Minimally initialize combobox if passed no data via constructor or referenced elements Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173281&action=edit Bug 38222: (follow-up) Only replace first numerical match in bookings count containers Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173265|0 |1 is obsolete| | --- Comment #12 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 173282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173282&action=edit Bug 38222: (follow-up) Include cancellation reason in sample notice for booking cancellation Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 leb <simonsen@bz-sh.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |simonsen@bz-sh.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173230|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173312&action=edit Bug 38222: Add combobox component Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173231|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173313&action=edit Bug 38222: Add cancellation reason to bookings patch definition; reformat bookings definition Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173232|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173314&action=edit Bug 38222: Add handling for cancellation reasons to cancel booking modal template, associated script Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173233|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173315&action=edit Bug 38222: Use comboboxes in circ/circulation.pl, bookings/list.pl, members/moremember.pl To test: 1) Apply dependencies and this patch 2) Maybe update class files w/ update_dbix_class_files.pl 3) Build a new bundle w/ yarn api:bundle 4) Restart plack 5) Add a couple bookings to a patron 6) Go to any of the above modules 7) Cancel the booking and note 7.1) That the value you input is correctly received by the backend for cancellation_reason 7.2) Do it for the other 2 modules 8) Configure some authorised values under category BOOKING_CANCELLATION 9) Repeat 7 and note that you can select them in the combobox 10) Sign off or leave your feedback Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173264|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173316&action=edit Bug 38222: (follow-up) Reset overflow property of modal-body to prevent clipping of combobox options instead of position: fixed Also remove the inlined styles on the unordered list. Bootstrap's dropdown handles all of this. Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173277|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173317&action=edit Bug 38222: (follow-up) Remove residual inline styles from example for combobox usage Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173278|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173318&action=edit Bug 38222: (follow-up) Minimally initialize combobox if passed no data via constructor or referenced elements Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173281|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173319&action=edit Bug 38222: (follow-up) Only replace first numerical match in bookings count containers Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173282|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173320&action=edit Bug 38222: (follow-up) Include cancellation reason in sample notice for booking cancellation Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173321&action=edit Bug 38222: (QA follow-up) Add av category update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Discussed with Paul.. we're going to add however text on the cancelled status containing the reason and he's going to move the js snippet that's cloned in a few places into the modal.js asset to dry out the code a little for more re-use :) Once that's done I reckon we're PQA here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173322&action=edit Bug 38222: (QA follow-up) DRY event listener setup for combobox resets on modal close Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173323&action=edit Bug 38222: (QA follow-up) Show cancellation reason where applicable, appropriately handle statuses Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #26 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173336&action=edit Bug 38222: (QA follow-up) Limit combobox input in cancel booking modal to db field length Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173322|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173337&action=edit Bug 38222: (QA follow-up) DRY event listener setup for combobox resets on modal close Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173323|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173338&action=edit Bug 38222: (QA follow-up) Show cancellation reason where applicable, appropriately handle statuses Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173336|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173339&action=edit Bug 38222: (QA follow-up) Limit combobox input in cancel booking modal to db field length Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't ignore these :) FAIL installer/data/mysql/atomicupdate/bug_38222.pl FAIL file permissions File must have the exec flag When I git mv the file, I still need to fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Capitalization (fixed in follow-up) <label for="cancellation-reason" class="form-label">Cancellation Reason:</label> = Cancellation reason 2) Translations (fixed in follow-up) + return __("Expired"); Double underscore for JS in .js files. Single underscore for JS in .tt files (and .inc). 3) combobox.js (to consider) This almost looks like a library, maybe to avoid any confusion in the future a copyright statement/license would not hurt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dropping keyword. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement introduces release notes| |a combobox component for | |booking cancellations, | |allowing users to select | |from authorized values or | |enter free text, ensuring | |consistent input handling | |and improved user | |experience across booking | |management modules. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- No associated dropdown <ul> found for input: cancellation-reason Nobody sees that in the console? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40857 [Bug 40857] Dropdown menu for Booking cancellation is hidden in modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 --- Comment #36 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Jonathan Druart from comment #35)
No associated dropdown <ul> found for input: cancellation-reason
Nobody sees that in the console?
I don't see that in the console, but the dropdown looks weird. I reported bug 40857 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Bug 38222 depends on bug 38175, which changed state. Bug 38175 Summary: Improve bookings behavior with new status field https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38175 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Bug 38222 depends on bug 38193, which changed state. Bug 38193 Summary: Add cancellation_reason field to bookings table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38193 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1117 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38222 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #37 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Documented in the Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org