[Bug 43899] New: Report patrons whose userid is another patron's cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Bug ID: 43899 Summary: Report patrons whose userid is another patron's cardnumber Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- Koha lets one patron's userid be another patron's cardnumber ( bug 33905 ). Logins accept either field, so these conflicts can make a login match the wrong patron bug 43896 ). Before Koha can enforce uniqueness across both fields, libraries need a way to find the conflicts they already have. search_for_data_inconsistencies.pl and the Database audit tab of the about page should these conflicts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43898 [Bug 43898] Prevent patrons from using another patron's cardnumber as userid and vice versa -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209716&action=edit Bug 43899: Add check for userid / cardnumber conflicts to search_for_data_inconsistencies.pl Patrons can log in with either their userid or their cardnumber, but Koha doesn't stop one patron's userid from being another patron's cardnumber ( bug 33905 ). Libraries need a way to find the conflicts they already have. This patch adds a check to search_for_data_inconsistencies.pl that lists them. Test Plan: 1) Apply this patch 2) Edit any patron other than the koha user, set the username to 42 ( the koha user's card number ) 3) perl misc/maintenance/search_for_data_inconsistencies.pl 4) Note the new "Patrons with a userid that is another patron's cardnumber" section lists both patrons! 5) prove t/db_dependent/Koha/Database/DataInconsistency.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209717&action=edit Bug 43899: Show userid / cardnumber conflicts on the database audit tab of the about page The previous patch makes search_for_data_inconsistencies.pl list patrons whose userid is another patron's cardnumber, but not every library can run command line scripts. This patch shows the same list on the "Database audit" tab of the about page. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Edit any patron other than the koha user, set the username to 42 ( the koha user's card number ) 4) Browse to About Koha › Database audit ( /cgi-bin/koha/about.pl?tab=database ) 5) Note the new "Patrons with a userid that is another patron's cardnumber" warning lists both patrons! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209718&action=edit Bug 43899: Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209716|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209718|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209724&action=edit Bug 43899: Add check for userid / cardnumber conflicts to search_for_data_inconsistencies.pl Patrons can log in with either their userid or their cardnumber, but Koha doesn't stop one patron's userid from being another patron's cardnumber ( bug 33905 ). Libraries need a way to find the conflicts they already have. This patch adds a check to search_for_data_inconsistencies.pl that lists them. Test Plan: 1) Apply this patch 2) Give patron 19 the koha user's card number ( 42 ) as their username: UPDATE borrowers SET userid = '42' WHERE borrowernumber = 19; 3) perl misc/maintenance/search_for_data_inconsistencies.pl 4) Note the new "Patrons with a userid that is another patron's cardnumber" section lists both patrons! 5) prove t/db_dependent/Koha/Database/DataInconsistency.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209725&action=edit Bug 43899: Show userid / cardnumber conflicts on the database audit tab of the about page The previous patch makes search_for_data_inconsistencies.pl list patrons whose userid is another patron's cardnumber, but not every library can run command line scripts. This patch shows the same list on the "Database audit" tab of the about page. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Give patron 19 the koha user's card number ( 42 ) as their username: UPDATE borrowers SET userid = '42' WHERE borrowernumber = 19; 4) Browse to About Koha › Database audit ( /cgi-bin/koha/about.pl?tab=database ) 5) Note the new "Patrons with a userid that is another patron's cardnumber" warning lists both patrons! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209726&action=edit Bug 43899: Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209724|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209725|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #7 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209795&action=edit Bug 43899: Add check for userid / cardnumber conflicts to search_for_data_inconsistencies.pl Patrons can log in with either their userid or their cardnumber, but Koha doesn't stop one patron's userid from being another patron's cardnumber ( bug 33905 ). Libraries need a way to find the conflicts they already have. This patch adds a check to search_for_data_inconsistencies.pl that lists them. Test Plan: 1) Apply this patch 2) Give patron 19 the koha user's card number ( 42 ) as their username: UPDATE borrowers SET userid = '42' WHERE borrowernumber = 19; 3) perl misc/maintenance/search_for_data_inconsistencies.pl 4) Note the new "Patrons with a userid that is another patron's cardnumber" section lists both patrons! 5) prove t/db_dependent/Koha/Database/DataInconsistency.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209796&action=edit Bug 43899: Show userid / cardnumber conflicts on the database audit tab of the about page The previous patch makes search_for_data_inconsistencies.pl list patrons whose userid is another patron's cardnumber, but not every library can run command line scripts. This patch shows the same list on the "Database audit" tab of the about page. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Give patron 19 the koha user's card number ( 42 ) as their username: UPDATE borrowers SET userid = '42' WHERE borrowernumber = 19; 4) Browse to About Koha › Database audit ( /cgi-bin/koha/about.pl?tab=database ) 5) Note the new "Patrons with a userid that is another patron's cardnumber" warning lists both patrons! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #9 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 209797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209797&action=edit Bug 43899: Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33905 [Bug 33905] A patron's username and cardnumber must each not be used by another patron in any permutation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209795|0 |1 is obsolete| | Attachment #209796|0 |1 is obsolete| | Attachment #209797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 209861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209861&action=edit Bug 43899: Add check for userid / cardnumber conflicts to search_for_data_inconsistencies.pl Patrons can log in with either their userid or their cardnumber, but Koha doesn't stop one patron's userid from being another patron's cardnumber ( bug 33905 ). Libraries need a way to find the conflicts they already have. This patch adds a check to search_for_data_inconsistencies.pl that lists them. Test Plan: 1) Apply this patch 2) Give patron 19 the koha user's card number ( 42 ) as their username: UPDATE borrowers SET userid = '42' WHERE borrowernumber = 19; 3) perl misc/maintenance/search_for_data_inconsistencies.pl 4) Note the new "Patrons with a userid that is another patron's cardnumber" section lists both patrons! 5) prove t/db_dependent/Koha/Database/DataInconsistency.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 209862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209862&action=edit Bug 43899: Show userid / cardnumber conflicts on the database audit tab of the about page The previous patch makes search_for_data_inconsistencies.pl list patrons whose userid is another patron's cardnumber, but not every library can run command line scripts. This patch shows the same list on the "Database audit" tab of the about page. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Give patron 19 the koha user's card number ( 42 ) as their username: UPDATE borrowers SET userid = '42' WHERE borrowernumber = 19; 4) Browse to About Koha › Database audit ( /cgi-bin/koha/about.pl?tab=database ) 5) Note the new "Patrons with a userid that is another patron's cardnumber" warning lists both patrons! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43899 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 209863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209863&action=edit Bug 43899: Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org