[Bug 25463] New: Patron details page - display the alternative contact address as a block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 Bug ID: 25463 Summary: Patron details page - display the alternative contact address as a block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On the patron details page the address in the alternative contact section lists each address field, rather than displaying an address block. Displaying as an address block would be more consistent with how it is shown in the contact information and alternative address sections. For example, under contact information an address is displayed as: 4345 Library Rd. Springfield, MA 44224 In the alternative contact section it displays as: Address: 4345 Library Rd. City: Springfield State: MA ZIP/Postal code: 44224 Country: United States -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25070 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 [Bug 25070] Include files to display address and contact must be refactored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 --- Comment #1 from David Nind <david@davidnind.com> --- This was noted when signing off bug 25070 - that bug refactors the include files for displaying address and contact information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 105275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105275&action=edit Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. https://bugs.koha-community.org/show_bug.cgi?id=25436 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105275|0 |1 is obsolete| | --- Comment #3 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 105278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105278&action=edit Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105278|0 |1 is obsolete| | --- Comment #4 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 105279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105279&action=edit Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105279|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 105318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105318&action=edit Bug 25463: Patron details page - display the alternative contact address as a block This patch changes the format of the alternative contact address to a block, instead of a list. To test: 1) Edit a patron's contact details so that the Main Address and Alternative Contact addresses are complete 2) Install the patch 3) Ensure that the AddressFormat system preference is set to US style 4) View the patron record (members/moremember.pl) and ensure that the address format in both the Contact information and Alternative address sections display identically. 5) Change the AddressFormat system preference to German style, and repeat 6) Change the AddressFormat system preference to French style, and repeat. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 --- Comment #6 from David Nind <david@davidnind.com> --- Thanks David Roberts! Note from testing: There is no change with the German style address, as the street number is not a separate field (probably a separate bug required for that if required). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- David Roberts, Could you have a look at what have been done on bug 25070? There is no more 3 files per "block", but one. See includes/member-display-address-style.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 --- Comment #8 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #7)
David Roberts, Could you have a look at what have been done on bug 25070? There is no more 3 files per "block", but one. See includes/member-display-address-style.inc
I'll be happy to once Bug 25070 gets through QA. I dont see any point in rewriting what I've done here to mirror Bug 25070 if that doesn't get through QA for whatever reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes, that's why I pinged you before you wrote the patch, to make you aware of it. I also added the dependency. I should have written it explicitly in a comment here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 --- Comment #10 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #9)
Yes, that's why I pinged you before you wrote the patch, to make you aware of it. I also added the dependency. I should have written it explicitly in a comment here.
Sorry, I didn't get any message from you before I'd already written the patch. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This appears to be fixed on master. The alternate address now is also shown as an 'address block' instead of a list of labelled fields. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org