[Bug 6146] New: In Auth.pm the var OPACBaseURL ignores the syspref OPACBaseURL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 Bug #: 6146 Summary: In Auth.pm the var OPACBaseURL ignores the syspref OPACBaseURL Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: PATCH-Sent Component: Authentication AssignedTo: juan.sieira@xercode.es ReportedBy: juan.sieira@xercode.es QAContact: koha-bugs@lists.koha-community.org CC: dpavlin@rot13.org Created attachment 3839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3839 proposed patch In Auth.pm the var OPACBaseURL ignores the syspref OPACBaseURL. If this syspref is set, its value must be included in this param. A patch was submitted -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 09:45:09 UTC --- Isn't OPACBaseURL about to be debrecated? The current code build the OPAC URL based on the http server environment variables. It's better. It means that if you change your domain name, it will be automatically reported, you won't have to change a Koha syspref. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-13 09:53:16 UTC --- Hi Frederic, I think OpacBaseUrl is used in other places too. Like the links to opac from detail pages in intranet. And I think it's used in some mails too (mail your cart?). Don't know enough to say if it should be deprecated - but if we should take a look at those places too. Katrin -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 10:06:09 UTC --- (In reply to comment #2)
I think OpacBaseUrl is used in other places too. Like the links to opac from detail pages in intranet. And I think it's used in some mails too (mail your cart?). Don't know enough to say if it should be deprecated - but if we should take a look at those places too.
A quick look shows that OPACBaseURL is set in catalogue/detail.pl but not used anywhere in OPAC, and not in mail your cart template. But it seems that it has been added recently into MARC21 XSL in order to offer a link to OPAC from staff interface. I'm not sure it's a good idea, even if I can't see other mean to do it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-10-07 14:11:25 UTC --- OPACBaseURL is used in several places now, including the link to the OPAC from the detail page. It is used in the patch pending for Bug 6957. However, the way I've seen it used is to call the preference directly. In detail.pl: # Get OPAC URL if (C4::Context->preference('OPACBaseURL')){ $template->param( OpacUrl => C4::Context->preference('OPACBaseURL') ); } And build the link assuming that OPACBaseURL contains just the domain. In detail.tt: <a href="http://[% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]" target="_blank">Open in new window</a> Before or after this patch, if I leave the OPACBaseURL system preference empty, the output of the OPACBaseURL variable generated by Auth.pm is empty as well. I suspect something is wrong in the way the code builds the URL with or without this patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I think that bug 5010 will address this. Thoughts? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- It's been a year without comment, and I believe that bug 5010 which has been integrated to master dealt with this. I am marking this resolved duplicate instead of Failed QA. *** This bug has been marked as a duplicate of bug 5010 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org