[Bug 41026] New: sendbasket or sendshelf does not work with "My name" <someone@domain.com>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 Bug ID: 41026 Summary: sendbasket or sendshelf does not work with "My name" <someone@domain.com> Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org If you use that, it will be accepted. The line is parsed correctly by Email::Address. But exim will return a SMTP error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that adding two email addresses separated by a comma, does work and results in an email to two recipients. The list of emails is in the to_address of the message queue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #1)
Note that adding two email addresses separated by a comma, does work and results in an email to two recipients. The list of emails is in the to_address of the message queue.
Another thing is if we really want that. This allows a logged-in patron to send a mail to a lot of recipients. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|sendbasket or sendshelf |sendbasket or sendshelf |does not work with "My |need email validation |name" <someone@domain.com> | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41025 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #0)
If you use that, it will be accepted. The line is parsed correctly by Email::Address. But exim will return a SMTP error.
Changed the title. But I meant here (in short) sending an address "Marcel <my@email.com>" will pass all current validation. But results in SMTP error. Note that we pass the input param email just through to EnqueueLetter. Later on Koha::Email checks is_valid when processing the queue. But that algorithm is unreliable (bug 41025). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #2)
Another thing is if we really want that. This allows a logged-in patron to send a mail to a lot of recipients.
That's a very good point. This one might be a bit of a bug/feature. I know we've been expanding the number of places in Koha that allow multiple recipients, but that's not great when it's the OPAC I think... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #0)
If you use that, it will be accepted. The line is parsed correctly by Email::Address. But exim will return a SMTP error.
I'm not sure it's Koha's job to figure out if the email address is real? I think it's OK to get the SMTP error? For me, I think the key concern is "is this in email address format where the SMTP software can deal with it?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #5)
(In reply to Marcel de Rooy from comment #0)
If you use that, it will be accepted. The line is parsed correctly by Email::Address. But exim will return a SMTP error.
I'm not sure it's Koha's job to figure out if the email address is real? I think it's OK to get the SMTP error? For me, I think the key concern is "is this in email address format where the SMTP software can deal with it?"
Agreed. There is just a nasty bug somewhere: Adding the unexpected/unsupported(?) marcel <marcel@domain.com> or with quotes "marcel" <marcel@domain.com> in sendbasket/sendshelf are confirmed in the interface with Message sent. And die silently. The to address/header with the name (quoted and unquoted) pass Email::Address and should actually be correct for SMTP. But fail somewhere between Koha::Email and Email::Sender::Transport::SMTP. The fact that we use an encapsulated Email::Mime object within Email::Stuffer going to Email::Sender::Simple etc does not make it easier.. Part of the trace below. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [2025/10/17 09:28:41] [WARN] <marcel"@domain.com>: "@" or "." expected after "marcel" Trace begun at /usr/share/perl5/Email/Sender/Transport/SMTP.pm line 256 Email::Sender::Transport::SMTP::send_email('Email::Sender::Transport::SMTP::Persistent=HASH(0x56178566c960)', 'Email::Abstract=ARRAY(0x5617858cf3f8)', 'HASH(0x561785771838)') called at /usr/share/perl5/Email/Sender/Role/CommonSending.pm line 45 Email::Sender::Role::CommonSending::try {...} at /usr/share/perl5/Try/Tiny.pm line 102 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561785684d10)', 'Try::Tiny::Catch=REF(0x561784f9de68)') called at /usr/share/perl5/Email/Sender/Role/CommonSending.pm line 58 Email::Sender::Role::CommonSending::send('Email::Sender::Transport::SMTP::Persistent=HASH(0x56178566c960)', 'Email::Abstract=ARRAY(0x5617858cf3f8)', 'HASH(0x561785667940)') called at /usr/share/perl5/Email/Sender/Simple.pm line 119 Email::Sender::Simple::send_email('Email::Sender::Simple', 'Email::Abstract=ARRAY(0x5617858cf3f8)', 'HASH(0x561785797560)') called at /usr/share/perl5/Email/Sender/Role/CommonSending.pm line 45 Email::Sender::Role::CommonSending::try {...} at /usr/share/perl5/Try/Tiny.pm line 102 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x56178576c9a0)', 'Try::Tiny::Catch=REF(0x56178566efd0)') called at /usr/share/perl5/Email/Sender/Role/CommonSending.pm line 58 Email::Sender::Role::CommonSending::send('Email::Sender::Simple', 'Email::MIME=HASH(0x5617842f0960)', 'HASH(0x56177f79d1e8)') called at /usr/share/perl5/Email/Stuffer.pm line 784 Email::Stuffer::send_or_die('Koha::Email=HASH(0x561784f645f0)', 'HASH(0x5617856681e0)') called at /usr/share/koha/Koha/Email.pm line 237 Koha::Email::send_or_die('Koha::Email=HASH(0x561784f645f0)', 'HASH(0x5617856681e0)') called at /usr/share/koha/C4/Letters.pm line 1573 C4::Letters::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561782f0aa40)', 'Try::Tiny::Catch=REF(0x561785771ad8)') called at /usr/share/koha/C4/Letters.pm line 1595 C4::Letters::_send_message_by_email('HASH(0x561785669e90)', undef, undef, undef, 'HASH(0x5617855899e0)') called at /usr/share/koha/C4/Letters.pm line 1077 C4::Letters::SendQueuedMessages('HASH(0x561785559468)') called at /usr/share/koha/opac/opac-sendshelf.pl line 122 eval {...} at /usr/share/koha/opac/opac-sendshelf.pl line 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41026 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Now that I think about it... this sounds familiar. I think I had a crack at this in the past, but then ran out of steam... See bug 25382 *** This bug has been marked as a duplicate of bug 25382 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org