[Bug 23407] New: XSLT Details pages don't use items, we shouldn't pass them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Bug ID: 23407 Summary: XSLT Details pages don't use items, we shouldn't pass them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org C4::XSLT::XSLTParse4Display calls buildKohaItemsNamespace() for all displays For IntranetDetails and OPACDetails there is no item processing. Removing this call can save us time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91900&action=edit Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note th eload time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91916&action=edit Bug 23407: Don't process items for staff results either We also don't use the items here, same test plan but on staff cleint results, should see no change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This worked as advertised but I got this warning from the qa tool: FAIL C4/XSLT.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91900|0 |1 is obsolete| | Attachment #91916|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92045&action=edit Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note the load time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23414 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92045|0 |1 is obsolete| | --- Comment #5 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97850&action=edit Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note the load time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here
QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information
intranetResults xmlns:items="http://www.koha-community.org/items" exclude-result-prefixes="marc items str"> <xsl:key name="item-by-status" match="items:item" use="items:status"/> <xsl:key name="item-by-status-and-branch" match="items:item" use="concat(items:status, ' ', items:homebranch)"/> <xsl:variable name="hidelostitems" select="marc:sysprefs/marc:syspref[@name='hidelostitems']"/> still a few lines in intranetDetails too Removed in a follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97850|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 97854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97854&action=edit Bug 23407: Don't process items for XSLT on details pages To test: 1 - Add 1000 items to a record Go to biblio Edit items Add multiple copies of this item Add 1000 and confirm Wait.. 2 - Load the record in staff client and OPAC, note how long it takes Press F12 in browser to open the console use the Network tab of the console note the load time refresh a few times to see average time 3 - Apply patch 4 - Restart all the things 5 - Reload the record in staff and opac 6 - Note decresed time 7 - Verify nothing on the page has changed QA can grep the standard XSLT files for details pages for 'item' to note occurences do not use items information Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 97855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97855&action=edit Bug 23407: (QA follow-up) Remove some XSLT item leftovers Test plan: Check intranet results and detail page. Check opac detail. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 97856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97856&action=edit Bug 23407: (QA follow-up) Same change for UNIMARC XSLT Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #13 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28373 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org