[Bug 15360] New: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Bug ID: 15360 Summary: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: library@stas.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When viewing an authority using detail.pl, the "New from Z39.50" Button does not generate a new record, but replaces the currently viewed record. This is different behavior than in previous versions. It seems it should generate a new authority record (similar to what is found on the biblio cataloging page), given the text "New", just as it formerly did. If the new behavior is meant, it should be relabeled "Replace using Z39.50" or something similar to avoid destroying authority records and possibly causing database-wide changes by unintentionally replacing a record, and populating that record onto many biblios. Personally, I would favor the former behavior -- generate a new authority record from a Z39.50 search, and leave the button on the editing section in authorities.pl as the method for replacing via a Z39.50 search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46261&action=edit Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" If the record exist, the button text should not be "New from", but "Replace". Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46261|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 46273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46273&action=edit Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" If the record exist, the button text should not be "New from", but "Replace". Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #3 from Ian Palko <library@stas.org> --- Perhaps this would qualify as an "enhancement", but would it be possible to restore the older behavior as well? Previously the "New from z39.50" button did exactly that. It generated a new record from a z39.50 authorities search. There was never a "Replace" function or button. The replace feature is great, and allowing replacement as this patch does is a good idea, but perhaps we should also allow the creation of a new record as before. That would require a new "New from z39.50" button which would actually generate a new record, in addition to the "Replace from z39.50". Being on vacation, I'm not in front of my test server, else I'd work up a quick and dirty solution, since it seems easy and straight-forward. Perhaps if someone else has a few minutes ... Thanks for the work to fix and clarify this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46308&action=edit [ALTERNATIVE-PATCH] Bug 15360: Add a "Replace with Z39.50" button when editing an authority If the record exist, a new button "Replace with Z39.50" is added Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" and "New from Z39.50" Confirm that the 2 buttons work as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are 2 patches now, pick the one you prefer. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 15328 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Patch doesn't apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc Failed to merge in the changes. Patch failed at 0001 Bug 15360: Add a "Replace with Z39.50" button when editing an authority -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Oops sorry, I realise now these patches are meant to be alternatives and tested separately. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- I want to sign off on the alternative patch but the 'New from Z39.50' button now doesn't fit along the same line as the other buttons and would look much better if it did. Will sign off once that's fixed up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #9)
I want to sign off on the alternative patch but the 'New from Z39.50' button now doesn't fit along the same line as the other buttons and would look much better if it did. Will sign off once that's fixed up.
I don't get that, everything looks correct for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #11 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46565&action=edit Button on next line This is what happens for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Chloe Alabaster <chloealabaster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloealabaster@gmail.com --- Comment #12 from Chloe Alabaster <chloealabaster@gmail.com> --- I am also having the same problem as Aleisha where they aren't on the same line -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org