[Bug 32921] New: SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Bug ID: 32921 Summary: SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. This is a problem for some libraries because not every patron realizes there is another action after pressing 'Finish' and they walk away. Leaving open a screen that shows their username and checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146414&action=edit Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Lucas Gass from comment #1)
Created attachment 146414 [details] [review] Bug 32921: Honor SelfCheckTimeout when modal is open
To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires.
Hi Lucas, I set my SelfCheckTimeout to 10 seconds, left the modal open and it did not log out even after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Laura Escamilla from comment #2)
(In reply to Lucas Gass from comment #1)
Created attachment 146414 [details] [review] [review] Bug 32921: Honor SelfCheckTimeout when modal is open
To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires.
Hi Lucas,
I set my SelfCheckTimeout to 10 seconds, left the modal open and it did not log out even after applying the patch.
Hmmm, this does work for me in both Firefox and Chrome. Question, did you try clearing your cache after applying the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Since this is working for me I am going to set it back to NSO to see if I can get some more feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Marius <marius.mandrescu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Marius <marius.mandrescu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146414|0 |1 is obsolete| | --- Comment #5 from Marius <marius.mandrescu@inlibro.com> --- Created attachment 149779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149779&action=edit Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires. Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149779|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150568&action=edit Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires. Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com> JD amended patch - fix indentation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org