[Bug 18203] New: Add per borrower category restrictions on ILL placement.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Bug ID: 18203 Summary: Add per borrower category restrictions on ILL placement. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alex.sassmannshausen@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The ILLModule currently allows any borrower category to request new ILLs. This may not be what is required in many places as ILLs can be very expensive. This bug should implement a method by which entire borrower categories can be prevented from creating new ILL requests. Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #1 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 60805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60805&action=edit Add per borrower category create ILL privilege. * admin/categories.pl: Add validation & update for `canplaceill`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Add `canplaceill` handling. * ill/ill-requests.pl: Pass `canplaceill` to template. * koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc: Check for `canplaceill`. * opac/opac-illrequests.pl: Pass `canplaceill` to template. * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt: Check for `canplaceill`. * installer/data/mysql/kohastructure.sql: Create `canplaceill` column. * installer/data/mysql/atomicupdate/ill_cat_permission.sql: New file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #2 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 60806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60806&action=edit DO NOT PUSH: Schema changes. * Koha/Schema/Result/Category.pm: Add `canplaceill`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #3 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Test Plan: - Have ILLModule working - With any non-database user verify you can place new ILL requests in OPAC and Intranet - Apply patches here - Run dbupdate - Verify you can no longer place new ILL requests in OPAC and Intranet - In borrower categories, set 'Can place ILL' to yes. - Verify you can place new ILL requests in OPAC and Intranet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Bug 18203 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit | |y.org | Component|Circulation |ILL CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this would still be very useful to have as I see no other option to limit ILL requests for patrons. By patron category should work for most libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #5 from Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> --- Has there been any update on this since the DO NOT PUSH? Thanks, Niamh -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 23976 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com, | |martin.renvoize@ptfs-europe | |.com Status|NEW |Needs Signoff Summary|Add per borrower category |Add per borrower category |restrictions on ILL |restrictions on ILL |placement. |placement --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Alex is no longer working on Koha so I am not sure why this was never set to 'needs sign-off'. The DO NOT PUSH for schema changes is normal as this file is only used for testing and the RM will not use it when pushing the patch set. So this doesn't tell us much. hm. I am updating the status to 'Patch doesn't apply' and adding Andrew and Martin who may know what happened here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this would still be a nice to have feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex@komputilo.eu |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60805|0 |1 is obsolete| | Attachment #60806|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145331&action=edit Bug 18203: Add per borrower category restrictions on ILL placement Test Plan: - Enable ILLModule sys pref and install any backend - Verify you can place new ILL requests in OPAC and Intranet - Apply patch - Run dbic - Verify you can no longer place new ILL requests in OPAC and Intranet - In borrower categories, set 'Can place ILL' to yes. - Verify you can place new ILL requests in OPAC and Intranet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145331|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 145349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145349&action=edit Bug 18203: Add per borrower category restrictions on ILL placement Test Plan: - Enable ILLModule sys pref and install any backend - Verify you can place new ILL requests in OPAC and Intranet - Apply patch - Run dbic - Verify you can no longer place new ILL requests in OPAC and Intranet - In borrower categories, set 'Can place ILL' to yes. - Verify you can place new ILL requests in OPAC and Intranet. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145349|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 145354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145354&action=edit Bug 18203: Add per borrower category restrictions on ILL placement Test Plan: - Enable ILLModule sys pref and install any backend - Verify you can place new ILL requests in OPAC and Intranet - Apply patch - Run dbic - Verify you can no longer place new ILL requests in OPAC and Intranet - In borrower categories, set 'Can place ILL' to yes. - Verify you can place new ILL requests in OPAC and Intranet. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Fixed commit author, had originally been submitted as John Doe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) There is a fail in the QA scripts: FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column categories.canplaceill is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Category.pm), see the SQL12 coding guideline 2) Behavior in staff interface I think, we should not use the staff person's patron category for the check on the 'new request' button in the staff interface. If a staff user has permissions for the interlibrary loans module, they should be able to place ILL requests for the users of the library. They are usually not placing ILL requests for themselves, but for others. Similar to hold requests. The check on the category should be implemented in the patron search/the user they try to place the request for. But I am not sure if this would have to be done in the backends then? 3) Changed behaviour for existing installations As all categories are allowed to place ILL requests now, we should set "Can place ILL requests?" to yes for all categories if the ILLModule is activated. This way we won't break things for libraries and they can implement the new feature if they chose to do so. But overall this looks quite good already! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add per borrower category |Add per borrower category |restrictions on ILL |restrictions on placing ILL |placement |requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148707&action=edit Bug 18203: (QA follow-up) * Add boolean flag in Category.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> ---
2) Behavior in staff interface
I think, we should not use the staff person's patron category for the check on the 'new request' button in the staff interface.
If a staff user has permissions for the interlibrary loans module, they should be able to place ILL requests for the users of the library. They are usually not placing ILL requests for themselves, but for others. Similar to hold requests.
The check on the category should be implemented in the patron search/the user they try to place the request for. But I am not sure if this would have to be done in the backends then?
Yes, I agree with this idea. But it's the backend who is responsible for attaching the borrowernumber to the illrequest. However, this does seem a bit redundant for the staff UI, i.e. if a staff member already has the ill permission, this check should not even be required (since ill permission needs to be assigned on a per user in the first place anyway). I suggest we restructure this bug's functionality to just apply to OPAC, since I also believe the original problem it's trying to solve is only on the OPAC anyway (prevent certain patron categories from being able to place requests to avoid costs/noise)
3) Changed behaviour for existing installations
As all categories are allowed to place ILL requests now, we should set "Can place ILL requests?" to yes for all categories if the ILLModule is activated. This way we won't break things for libraries and they can implement the new feature if they chose to do so.
Should we: 1) keep canplaceill default 0, and in atomicupdate set to 1 for every existing installation if ILLModule sys pref is enabled, or 2) change canplaceill default to 1, which means upon enabling ILLModule it just works for everyone and then let staff members untick the canplaceill checkbox for any given category. Please Katrin let me know what you think of the above, or if some of what I said doesn't make sense or is wrong. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Current patches may or may not be causing issues with the table rendered in patron categories /cgi-bin/koha/admin/categories.pl Need to double-check that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148719&action=edit WIP: Fix categories table presentation But now there is an error in the console if ILL is disabled Squash this later -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149010&action=edit Bug 18203: Add per borrower category restrictions on placing ILL requests Default value for canplaceillopac is 1 Patron in a category that cannot place ill can still visit illlist and illview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add per borrower category |Add per borrower category |restrictions on placing ILL |restrictions on placing ILL |requests |requests in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149010|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153345&action=edit Bug 18203: DB specific and atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153346&action=edit Bug 18203: dbic specific [DONT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153347&action=edit Bug 18203: Add per borrower category restrictions on placing ILL requests Test Plan: - Enable ILLModule sys pref and install any backend, or run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Verify you can place new ILL requests in OPAC and Intranet - Apply patch - In borrower categories, verify there's a new column for 'can place ILL in opac' and is set to 'yes' by default - Edit your borrower's patron category and set 'can place ILL in opac' to 'No' - Verify you can no longer place new ILL requests in OPAC - Verify you also cannot place new ILL requests through URL: :8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased this after bug 33702. Updated test plan. Split submission to multiple patches (db, dbic and feature). Would someone be able to take a look at this? It's a quite small patch! (easy sign-off). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153345|0 |1 is obsolete| | --- Comment #23 from Sam Lau <samalau@gmail.com> --- Created attachment 153370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153370&action=edit Bug 18203: DB specific and atomicupdate Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153346|0 |1 is obsolete| | --- Comment #24 from Sam Lau <samalau@gmail.com> --- Created attachment 153371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153371&action=edit Bug 18203: dbic specific [DONT PUSH] Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153347|0 |1 is obsolete| | --- Comment #25 from Sam Lau <samalau@gmail.com> --- Created attachment 153372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153372&action=edit Bug 18203: Add per borrower category restrictions on placing ILL requests Test Plan: - Enable ILLModule sys pref and install any backend, or run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Verify you can place new ILL requests in OPAC and Intranet - Apply patch - In borrower categories, verify there's a new column for 'can place ILL in opac' and is set to 'yes' by default - Edit your borrower's patron category and set 'can place ILL in opac' to 'No' - Verify you can no longer place new ILL requests in OPAC - Verify you also cannot place new ILL requests through URL: :8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Needs a rebase on top of bug 34282 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Needs a rebase on top of bug 34382 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153370|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155316&action=edit Bug 18203: DB specific and atomicupdate Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153371|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155317&action=edit Bug 18203: dbic specific [DONT PUSH] Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153372|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155318&action=edit Bug 18203: Add per borrower category restrictions on placing ILL requests Test Plan: - Enable ILLModule sys pref and install any backend, or run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Verify you can place new ILL requests in OPAC and Intranet - Apply patch - In borrower categories, verify there's a new column for 'can place ILL in opac' and is set to 'yes' by default - Edit your borrower's patron category and set 'can place ILL in opac' to 'No' - Verify you can no longer place new ILL requests in OPAC - Verify you also cannot place new ILL requests through URL: :8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155316|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158126&action=edit Bug 18203: DB specific and atomicupdate Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155317|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158127&action=edit Bug 18203: dbic specific [DONT PUSH] Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155318|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158128&action=edit Bug 18203: Add per borrower category restrictions on placing ILL requests Test Plan: - Enable ILLModule sys pref and install any backend, or run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) - Verify you can place new ILL requests in OPAC and Intranet - Apply patch - In borrower categories, verify there's a new column for 'can place ILL in opac' and is set to 'yes' by default - Edit your borrower's patron category and set 'can place ILL in opac' to 'No' - Verify you can no longer place new ILL requests in OPAC - Verify you also cannot place new ILL requests through URL: :8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I made a last minute change on the column name. I hope you agree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #36 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- That's awesome Tomas thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35263 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35263 [Bug 35263] Cannot update patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #36)
That's awesome Tomas thank you.
We have a problem here, see bug 35263 - cannot edit patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe Ltd* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |When the ILL module is release notes|Europe Ltd* |activated, the patron | |category administration | |page will include a setting | |"Can patron place ILL | |requests in OPAC". For | |existing installations the | |flag will be set for all | |patron categories on | |update. | | | |**Sponsored by** | |*PTFS Europe Ltd* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/924 Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org