[Bug 26910] New: When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Bug ID: 26910 Summary: When calling the effective rule (allowed reserves), the undef is now set at 0 versus undef Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: jonathan.druart@bugs.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, nick@bywatersolutions.com When calling allowed reserves - git effective rule, if this rule is undef, the default is now set to zero. Prior to the change made in 18936, the default was set to undef. It appears this change was made "Bug 18936: Fix some more tests (19.56 KB, patch)" during this stage in the bug. In conclusion, this is very critical, as libraries will come across the inability to allow holds if they have circulation rules effective by this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can you provide a step by step plan to recreate the issue please? I edited the main circulation rule, filled "Holds allowed (total)" with an empty string, saved => "" is set in DB and I am able to place hold on items. Do you mean you have NULL in DB? What is the return of
select rule_value from circulation_rules where rule_name="reservesallowed";
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Found from bug 26911 Set some other values for a rule in the circ matrix then DELETE FROM circulation_rules WHERE rule_name = 'reservesallowed'; The rules now appear as unlimited, but act as if 0 This line: 427 $allowedreserves = $rights->{reservesallowed} // $allowedreserves; Previously it did not assign to allowed reserves which is defaulted to 0 at the beginning of CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26911 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So it does not happen if the upgrade does not fail? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Severity|major |normal --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- To recreate: 1 - Remove any All/All rules from circulation rules 2 - Set a circ rule for a specific itemtype with Holds allowed (total) set to 5 3 - Attempt to place a hold on an itemtype without the rules 4 - Too many holds: Edna Acosta can only place a maximum of 0 total holds. Turns out, this behaviour is consistent in my testing, so the problem was the upgrade only There is a question whether no rules set should allow unlimited holds, or 0 holds but that's not necessarily a bug. Currently we set "" for unlimited, and the rule not existing means that holds are not allowed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |koha-bugs@lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30794 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org