[Bug 35906] New: Add bookable option on itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Bug ID: 35906 Summary: Add bookable option on itemtypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hello everyone, In connection with bug 29002, which introduces the new "booking" feature, I'd like to suggest an improvement mentioned in the ticket: adding this option to an itemtype. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29002 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161397&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Edit an itemtype, there is a new checkbox to add 'bookable' option 6) Test it with item with this itemtype, go to edit item view ("Booking" tab is already in biblio-view-menu even if there is no booking on item, due to bookable option on itemtype) 7) Next to the bookable item option you can see a warn with a message if both options (item/itemtype) are not the same. 8) Test it Sponsored by: BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nick@bywatersolutions.com --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- This uses the record level item type to determine bookability even if item-level_itypes is set to specific item. This means a record can be defined as bookable, then have no items that can be booked, so booking fails. I also think the dropdown to set an item as bookable/not bookable should be disabled when the itemtype is set to 'Bookable' The warning when an itemtype is not set to bookable and the item is seems strange to me too. Maybe the option should be read "If checked, all items of this type will be enabled for future bookings, otherwise bookable status can be defined per item" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Thank you nick for your feedback. I've changed the "visual" problems with the dropdown and the messages. I was just wondering about the impact of itemtype on linked item bookings. I'd certainly change the checkbox for defining whether the itemtype is bookable by a select to have a behavior like : - Do not define => NULL, keeping the current operation with the possibility of defining each item as bookable - Bookable => 1 all linked items are bookable - Bookable => 0 items not bookable which would then lead us to use Items->filter_by_bookable with the right filters to obtain bookable items by their direct bookable status or by the bookable status of their itemtype. It would be necessary to create a foreign-key relationship between these tables, as this is not currently the case, and I wonder why... would there be any obstacle to doing so? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161397|0 |1 is obsolete| | --- Comment #4 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161638&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: BibLibre -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #5 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Thibaud Guillot from comment #3)
Thank you nick for your feedback. I've changed the "visual" problems with the dropdown and the messages.
Sorry for previous mispelling Nick* I've tried to come up with a workaround to avoid these table relationship problems. Using a new system preference, we choose whether the future booking option attribute is activated on the item or on the itemtype. I've taken into account your comments on inconsistent messages and how to view the select on the item if the system preference is set to "itemtype". I look forward to hearing from you :) Thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161638|0 |1 is obsolete| | --- Comment #6 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161744&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on|29002 |35248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 [Bug 35248] Bookings needs unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161744|0 |1 is obsolete| | --- Comment #7 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 161961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161961&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161961|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162242&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased on the tree.. We need unit test updates for the changes to filter_by_bookable too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #10 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 162365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162365&action=edit Bug 35906 : Add unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm considering this a little at the moment. I'm wondering if we aught to be following the patterns already put in place by filter_by_for_hold a little more. i.e. should this be in the circulation rules table rather than pushed into the item type management page. Also.. I'm envisaging that we don't actually need the pref to force libaries to pick on or the other setting. We could effectively build the query as 'item.bookable = 1 OR ( item.booking = undef AND item.itype NOT IN bookable_itypes )' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162242|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162465&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162466&action=edit Bug 35906: Add unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162467&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162468&action=edit Bug 35906: Schema dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I still have a little more to do here.. Mostly to update the test. Do you agree with the alternate approach proposed in the followup? It allows for setting at itemtype level and optionally overriding at item level should one wish to do so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162467|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162469&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162468|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162470&action=edit Bug 35906: Schema dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162472&action=edit Bug 35906: (QA follow-up) Fix item-type schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think with my follow-ups we can satisfy all interested parties... just looking for a signoff now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Do you think this approach will satisfy your sponsors Thibaud? If so, I'd love to see a signoff from them for the feature set as a whole then we can get it through QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #22 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Hello Martin, Thanks for your feedback, so I asked him to test it as soon as possible and SO (I hope so) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162465|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163291&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162466|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163292&action=edit Bug 35906: Add unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162469|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163293&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162470|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163294&action=edit Bug 35906: Schema dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162472|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163295&action=edit Bug 35906: (QA follow-up) Fix item-type schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just a quick rebase as it stopped applying when most fo the dependencies were pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Bug 35906 depends on bug 35248, which changed state. Bug 35248 Summary: Bookings needs unit tests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 [Bug 36271] Bookings should respect circulation rules for max loan periods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163291|0 |1 is obsolete| | --- Comment #29 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 163547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163547&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Edit an itemtype, there is a new checkbox to add 'bookable' option 6) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 7) You now have a new setting on the item bookable option to 'Follow itemtype" Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163292|0 |1 is obsolete| | --- Comment #30 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 163548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163548&action=edit Bug 35906: Add unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163293|0 |1 is obsolete| | --- Comment #31 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 163549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163549&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163294|0 |1 is obsolete| | --- Comment #32 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 163550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163550&action=edit Bug 35906: Schema dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163295|0 |1 is obsolete| | --- Comment #33 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 163551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163551&action=edit Bug 35906: (QA follow-up) Fix item-type schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #34 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Test plan update (syspref removal) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163547|0 |1 is obsolete| | --- Comment #35 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164579&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Edit an itemtype, there is a new checkbox to add 'bookable' option 6) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 7) You now have a new setting on the item bookable option to 'Follow itemtype" Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163548|0 |1 is obsolete| | --- Comment #36 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164580&action=edit Bug 35906: Add unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163549|0 |1 is obsolete| | --- Comment #37 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164581&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163550|0 |1 is obsolete| | --- Comment #38 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164582&action=edit Bug 35906: Schema dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163551|0 |1 is obsolete| | --- Comment #39 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164583&action=edit Bug 35906: (QA follow-up) Fix item-type schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #40 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164584&action=edit Bug 35906: (follow-up) fix missing bracket after rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164584|0 |1 is obsolete| | --- Comment #41 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 164585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164585&action=edit Bug 35906: (follow-up) rebased it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34440 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164585|0 |1 is obsolete| | --- Comment #42 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 165437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165437&action=edit Bug 35906: (follow-up) rebased it Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #43 from Esther Melander <esther.melander@bywatersolutions.com> --- Works according to test plan. Just a few notes: I tested this by changing the Book item type to allow for bookings. However, when I searched for Books, the Bookable dropdown for the item was not updated for existing items. I still had to go in and manually update the option to Follow item type. This is probably correct for existing items. There is not a way to update this via batch item modification for existing items (Bug 35671). However, adding a new item does default to Follow item type in the Bookable dropdown. I was able to place a booking for the item. Library limitations appear to work. In a consortium, if one library wants an item type like Books to be bookable and another does not, they will have to create separate item types with library limitations. If I change the item type like Books to be bookable by item type, book some items, and then go and change those items to not be bookable, the bookings/bookings tab disappears from the bibliographic detail view. In this scenario, the bookings should not disappear even though the item type is no longer bookable. Perhaps a separate bug. I did not understand step 8, other than I could see the behavior difference in the item detail page with the bookable option by item type enabled versus not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |david@davidnind.com --- Comment #44 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 35906 Bug 35906 - Add bookable option on itemtypes 164579 - Bug 35906: Add bookable option on itemtype 164580 - Bug 35906: Add unit test 164581 - Bug 35906: Remove preference and add override handling 164582 - Bug 35906: Schema dump 164583 - Bug 35906: (QA follow-up) Fix item-type schema 165437 - Bug 35906: (follow-up) rebased it Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35906: Add bookable option on itemtype Using index info to reconstruct a base tree... M Koha/Items.pm M Koha/REST/V1/Biblios.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging Koha/REST/V1/Biblios.pm CONFLICT (content): Merge conflict in Koha/REST/V1/Biblios.pm Auto-merging Koha/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 35906: Add bookable option on itemtype -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164579|0 |1 is obsolete| | Attachment #164580|0 |1 is obsolete| | Attachment #164581|0 |1 is obsolete| | Attachment #164582|0 |1 is obsolete| | Attachment #164583|0 |1 is obsolete| | Attachment #165437|0 |1 is obsolete| | --- Comment #45 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 166866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166866&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Edit an itemtype, there is a new checkbox to add 'bookable' option 6) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 7) You now have a new setting on the item bookable option to 'Follow itemtype" Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #46 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 166867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166867&action=edit Bug 35906: Add unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #47 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 166868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166868&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #48 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 166869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166869&action=edit Bug 35906: Schema dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #49 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 166870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166870&action=edit Bug 35906: (QA follow-up) Fix item-type schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #50 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 166871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166871&action=edit Bug 35906: (follow-up) rebased it Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #51 from David Nind <david@davidnind.com> --- Patch now applies again, so back to ready for QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Patch doesn't apply --- Comment #52 from Lucas Gass <lucas@bywatersolutions.com> --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166866|0 |1 is obsolete| | Attachment #166867|0 |1 is obsolete| | Attachment #166868|0 |1 is obsolete| | Attachment #166869|0 |1 is obsolete| | Attachment #166870|0 |1 is obsolete| | Attachment #166871|0 |1 is obsolete| | --- Comment #53 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 168120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168120&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Edit an itemtype, there is a new checkbox to add 'bookable' option 6) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 7) You now have a new setting on the item bookable option to 'Follow itemtype" Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #54 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 168121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168121&action=edit Bug 35906: Schema dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #55 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 168122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168122&action=edit Bug 35906: (QA follow-up) Fix item-type schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168120|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168160&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168161&action=edit Bug 35906: Add unit test Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168162&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168122|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168163&action=edit Bug 35906: (QA follow-up) Fix item-type schema Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168121|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168164&action=edit Bug 35906: Schema dump Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I restored the signoff lines in my rebase.. you also removed a function in your rebase in error I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #62 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Martin Renvoize from comment #61)
I restored the signoff lines in my rebase.. you also removed a function in your rebase in error I believe.
Oh sorry it was my mistake, I had squashed some commits about adding then removing the syspref and I must have forgotten some lines... thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168160|0 |1 is obsolete| | --- Comment #63 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170187&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168161|0 |1 is obsolete| | --- Comment #64 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170188&action=edit Bug 35906: Add unit test Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168162|0 |1 is obsolete| | --- Comment #65 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170189&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168163|0 |1 is obsolete| | --- Comment #66 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170190&action=edit Bug 35906: (QA follow-up) Fix item-type schema Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168164|0 |1 is obsolete| | --- Comment #67 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170191&action=edit Bug 35906: Schema dump Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.derscheid@lmscloud.de --- Comment #68 from Paul Derscheid <paul.derscheid@lmscloud.de> --- This is a long one: /kohadevbox/qa-test-tools/koha-qa.pl -c 5 -v 2 testing 5 commit(s) (applied to 5ca2066 'a3 Bug 37087: Add TCP keepalive suppo') Processing files before patches DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'item_orders' is trying to create a utility method called add_to_item_orders. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'item_orders' is trying to create a utility method called remove_from_item_orders. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'item_orders' is trying to create a utility method called set_item_orders. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'item_orders' is trying to create a utility method called item_orders_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'bundle_items' is trying to create a utility method called add_to_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'bundle_items' is trying to create a utility method called remove_from_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'bundle_items' is trying to create a utility method called set_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'bundle_items' is trying to create a utility method called bundle_items_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** Processing files after patches |========================>| 20 / 20 (100.00%) FAIL Koha/Item.pm FAIL critic # Subroutines::ProhibitNestedSubs: Got 24 violation(s). OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK tidiness FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted FAIL Koha/ItemType.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK tidiness FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted FAIL Koha/Items.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK tidiness FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted FAIL Koha/REST/V1/Biblios.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK tidiness FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted OK Koha/Schema/Result/Deleteditem.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK tidiness OK valid OK Koha/Schema/Result/Item.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK tidiness OK valid WARN Koha/Schema/Result/Itemtype.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 77, now: 79) OK valid FAIL admin/itemtypes.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 62, now: 64) FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted OK api/v1/swagger/definitions/item.yaml OK git manipulation OK rest_api_specs OK yaml_valid OK api/v1/swagger/definitions/item_type.yaml OK git manipulation OK rest_api_specs OK yaml_valid OK api/v1/swagger/paths/biblios.yaml OK git manipulation OK rest_api_specs OK yaml_valid OK api/v1/swagger/paths/items.yaml OK git manipulation OK rest_api_specs OK yaml_valid FAIL catalogue/updateitem.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK tidiness FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted OK installer/data/mysql/atomicupdate/Bug_35906_add-column-bookable-itemtype.pl OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod OK spelling OK tidiness OK valid FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column itemtypes.bookable is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Itemtype.pm), see the SQL12 coding guideline OK installer/data/mysql/mandatory/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template FAIL t/db_dependent/Koha/Items.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 392, now: 402) FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted FAIL t/lib/TestBuilder.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 205, now: 206) FAIL valid Missing right curly or square bracket syntax error Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Compilation failed in require BEGIN failed--compilation aborted Processing additional checks OK! * Was this bug sponsored by anyone? Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Items.t KO! Missing right curly or square bracket at /kohadevbox/koha/Koha/Item.pm line 2686, at end of line syntax error at /kohadevbox/koha/Koha/Item.pm line 2686, at EOF Compilation failed in require at /kohadevbox/koha/Koha/StockRotationItem.pm line 27. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/StockRotationItem.pm line 27. Compilation failed in require at /kohadevbox/koha/Koha/StockRotationRota.pm line 24. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/StockRotationRota.pm line 24. Compilation failed in require at /kohadevbox/koha/Koha/StockRotationStage.pm line 24. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/StockRotationStage.pm line 24. Compilation failed in require at /kohadevbox/koha/Koha/StockRotationStages.pm line 23. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/StockRotationStages.pm line 23. Compilation failed in require at /kohadevbox/koha/Koha/Library.pm line 28. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Library.pm line 28. Compilation failed in require at /kohadevbox/koha/Koha/CurbsidePickup.pm line 32. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/CurbsidePickup.pm line 32. Compilation failed in require at /kohadevbox/koha/Koha/CurbsidePickups.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/CurbsidePickups.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/Patron.pm line 41. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Patron.pm line 41. Compilation failed in require at /kohadevbox/koha/Koha/Patrons.pm line 28. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Patrons.pm line 28. Compilation failed in require at /kohadevbox/koha/Koha/Account.pm line 32. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Account.pm line 32. Compilation failed in require at /kohadevbox/koha/C4/Accounts.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Accounts.pm line 25. Compilation failed in require at /kohadevbox/koha/C4/Overdues.pm line 30. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Overdues.pm line 30. Compilation failed in require at /kohadevbox/koha/C4/Members.pm line 27. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Members.pm line 27. Compilation failed in require at /kohadevbox/koha/C4/Letters.pm line 29. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Letters.pm line 29. Compilation failed in require at /kohadevbox/koha/Koha/Auth/TwoFactorAuth.pm line 23. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Auth/TwoFactorAuth.pm line 23. Compilation failed in require at /kohadevbox/koha/C4/Auth.pm line 40. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Auth.pm line 40. Compilation failed in require at /kohadevbox/koha/C4/Serials.pm line 37. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Serials.pm line 37. Compilation failed in require at /kohadevbox/koha/Koha/Biblio.pm line 29. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblio.pm line 29. Compilation failed in require at /kohadevbox/koha/Koha/Biblios.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblios.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/Libraries.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Libraries.pm line 25. Compilation failed in require at /kohadevbox/koha/C4/Koha.pm line 28. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Koha.pm line 28. Compilation failed in require at /kohadevbox/koha/C4/Biblio.pm line 88. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Biblio.pm line 88. Compilation failed in require at /kohadevbox/koha/Koha/Items.pm line 26. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Items.pm line 26. Compilation failed in require at /kohadevbox/koha/Koha/Statistic.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Statistic.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/Statistics.pm line 23. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Statis tics.pm line 23. Compilation failed in require at /kohadevbox/koha/C4/Stats.pm line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Stats.pm line 22. Compilation failed in require at /kohadevbox/koha/C4/Circulation.pm line 27. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Circulation.pm line 27. Compilation failed in require at /kohadevbox/koha/t/db_dependent/Koha/Items.t line 28. BEGIN failed--compilation aborted at /kohadevbox/koha/t/db_dependent/Koha/Items.t line 28. # Looks like your test exited with 255 before it could output anything. /kohadevbox/koha/t/db_dependent/Koha/Items.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 20/20 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/Koha/Items.t (Wstat: 65280 (exited 255) Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 20 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.00 usr 0.00 sys + 0.36 cusr 0.16 csys = 0.52 CPU) Result: FAIL I rebased it while doing QA but setting this to FQA now. Sorry :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170187|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170582&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170188|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170583&action=edit Bug 35906: Add unit test Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170189|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170584&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170190|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170585&action=edit Bug 35906: (QA follow-up) Fix item-type schema Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170191|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170586&action=edit Bug 35906: Schema dump Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Corrected rebase.. now there's just a small number of QA script fails we need to look into rather than outright breakage :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #75 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Great! Privated the comment so it doesn't fill up the entire page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170582|0 |1 is obsolete| | --- Comment #76 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 172127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172127&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170583|0 |1 is obsolete| | --- Comment #77 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 172128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172128&action=edit Bug 35906: Add unit test Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170584|0 |1 is obsolete| | --- Comment #78 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 172129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172129&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170585|0 |1 is obsolete| | --- Comment #79 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 172130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172130&action=edit Bug 35906: (QA follow-up) Fix item-type schema Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170586|0 |1 is obsolete| | --- Comment #80 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 172131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172131&action=edit Bug 35906: Schema dump Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #81 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 172132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172132&action=edit Bug 35906: (QA follow-up) Add bookable option for API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #82 from Kristi <kkrueger@cuyahogalibrary.org> --- Looks like this one has been signed off. Can it be updated to a signed off status? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #83 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- We probably aught to add a unit test for effective_bookable here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #84 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172941&action=edit Bug 35906: (QA follow-up) Ensure we return effective_bookable The API wasn't including the effective_bookable value in responses Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #85 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- We should support the ?bookable filter on the plain /api/v1/items endpoint too. Also.. I'm tempted to rename it 'effective_bookable' to more clearly distinguish been effective bookable and localised item bookable fields. I'd love to see this also taken account of within q= as well as the local param option.. that could be a future follow-up though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #86 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I agree, that would be clearer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #87 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172945&action=edit Bug 35906: (QA follow-up) Unit tests for effective_bookable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172127|0 |1 is obsolete| | --- Comment #88 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172950&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172128|0 |1 is obsolete| | --- Comment #89 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172951&action=edit Bug 35906: Add unit test Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172129|0 |1 is obsolete| | --- Comment #90 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172952&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172130|0 |1 is obsolete| | --- Comment #91 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172953&action=edit Bug 35906: (QA follow-up) Fix item-type schema Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172131|0 |1 is obsolete| | --- Comment #92 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172954&action=edit Bug 35906: Schema dump Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172132|0 |1 is obsolete| | --- Comment #93 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172955&action=edit Bug 35906: (QA follow-up) Add bookable option for API Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172941|0 |1 is obsolete| | --- Comment #94 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172956&action=edit Bug 35906: (QA follow-up) Ensure we return effective_bookable The API wasn't including the effective_bookable value in responses Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #95 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172957&action=edit Bug 35906: (QA follow-up) Tidy admin/itemtypes.pl, Items.t Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #96 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172958&action=edit Bug 35906: (QA follow-up) Refactor (slightly) to reduce complexity in Koha/Item(s).pm, catalogue/updateitem Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #97 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172959&action=edit Bug 35906: (QA follow-up) Tidy block in TestBuilder.pm Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #98 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172960&action=edit Bug 35906: (QA follow-up) Correct type on added bookable column Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172945|0 |1 is obsolete| | --- Comment #99 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172961&action=edit Bug 35906: (QA follow-up) Unit tests for effective_bookable Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #100 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Please have another look, but I think this is PQA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38205 [Bug 38205] 'bookable' should be queryable on the /items endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #101 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, this currently no longer applies. Please rebase ASAP! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35906: Add bookable option on itemtype Applying: Bug 35906: Add unit test Applying: Bug 35906: Remove preference and add override handling error: sha1 information is lacking or useless (Koha/Items.pm). error: could not build fake ancestor Patch failed at 0001 Bug 35906: Remove preference and add override handling hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-35906-Remove-preference-and-add-override-handl-7ip612hr.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172950|0 |1 is obsolete| | --- Comment #102 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173324&action=edit Bug 35906: Add bookable option on itemtype Actually new "booking" feature can be set on an item but no directly on an itemtype. This patch adds this possibility. Test plan: 1) Test this new feature on an item as it were currently working. 2) Apply this patch 3) Run updatedatabase.pl 4) Reload Schema by running update_dbix_class_files.pl 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option 7) Test it with item with this itemtype, if there is 1 item at least you will see 'Booking' tab. 8) You can change syspref to 'item' to see the current behavior Note: When item-level_booking is set on 'itemtype' you can change dropdown option to 'No' on item bookable option. Sponsored by: Association de Gestion des Œuvres Sociales d'Inria (AGOS) Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172951|0 |1 is obsolete| | --- Comment #103 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173325&action=edit Bug 35906: Add unit test Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172952|0 |1 is obsolete| | --- Comment #104 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173326&action=edit Bug 35906: Remove preference and add override handling This patch updates the bookable nature of items to allow setting at the itemtype level and then overriding that setting at item level should you so wish to do so. We also now properly handle the item_level-itypes preference such that we look at item or biblioitem level appropriately. Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172953|0 |1 is obsolete| | --- Comment #105 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173327&action=edit Bug 35906: (QA follow-up) Fix item-type schema Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172954|0 |1 is obsolete| | --- Comment #106 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173328&action=edit Bug 35906: Schema dump Signed-off-by: Esther <esther@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172955|0 |1 is obsolete| | --- Comment #107 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173329&action=edit Bug 35906: (QA follow-up) Add bookable option for API Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172956|0 |1 is obsolete| | --- Comment #108 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173330&action=edit Bug 35906: (QA follow-up) Ensure we return effective_bookable The API wasn't including the effective_bookable value in responses Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172957|0 |1 is obsolete| | --- Comment #109 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173331&action=edit Bug 35906: (QA follow-up) Tidy admin/itemtypes.pl, Items.t Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172958|0 |1 is obsolete| | --- Comment #110 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173332&action=edit Bug 35906: (QA follow-up) Refactor (slightly) to reduce complexity in Koha/Item(s).pm, catalogue/updateitem Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172959|0 |1 is obsolete| | --- Comment #111 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173333&action=edit Bug 35906: (QA follow-up) Tidy block in TestBuilder.pm Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172960|0 |1 is obsolete| | --- Comment #112 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173334&action=edit Bug 35906: (QA follow-up) Correct type on added bookable column Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172961|0 |1 is obsolete| | --- Comment #113 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173335&action=edit Bug 35906: (QA follow-up) Unit tests for effective_bookable Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, |additional_work_needed, |RM_priority |release-notes-needed --- Comment #114 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Documentation Test plan is really outdated: 5) Change new syspref 'item-level_booking' to 'itemtype' 6) Edit an itemtype, there is a new checkbox to add 'bookable' option There is no such system preference (which is good). Please provide release notes and some documentation step by step for the documentation team. 2) Database update Whenever adding a new column, you need to use AFTER or BEFORE to make sure the sequence matches in updated and new installations. (Fixed in a follow-up) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #116 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It turns out that the "IF NOT EXISTS" pattern for ALTER TABLE doesn't play well with MySQL8 - can you please replace with our usual check? ALTER TABLE itemtypes ADD IF NOT EXISTS bookable INT(1) DEFAULT 0 AFTER automatic_checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #117 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173893&action=edit Bug 35906: (QA follow-up) Remove use of IF NOT EXISTS Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38434 [Bug 38434] (Bug 35906 follow-up) dbrev different from kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thibaud, can you provide a follow-up for the bug 35906 please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #118)
Thibaud, can you provide a follow-up for the bug 35906 please?
Sorry, wrong bug number. It's Bug 38434 - (Bug 35906 follow-up) dbrev different from kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #120 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 [Bug 36271] Bookings should have circulation rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This allows to configure on release notes| |item type level if an item | |is bookable or not. The | |item type level setting can | |be overwritten on item | |level. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/998 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 --- Comment #121 from David Cook <dcook@prosentient.com.au> --- I think I much prefer the idea of "Bookable" being an item type settings than an item setting. This is cool to see. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org