[Bug 32322] New: Column settings menu should not include "select all |none" in label text for Check In column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 Bug ID: 32322 Summary: Column settings menu should not include "select all |none" in label text for Check In column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On both the Checkout (circulation, issues-table) and Details (moremember, issues-table) tab of the patron record, the table of checkouts data includes a column to select items to check in. On both tables, the label to toggle this column on and off with the Columns button is labled "Check in select all | none." We don't need the "select all | none" part. It should just say "Check in." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 --- Comment #1 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 144209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144209&action=edit Bug 32322 : Removal of "Select all|None" Removed "Select all|None" from check in column of circ > checkouts and circ > details pages Test Plan: Navigate to Circulation > checkouts > *user* Ensure *user* has book checked out Observe that under both the Check Out and Details tabs on the left, the table has a column labelled "Check in select all | none." Apply Patch Observe that the above column on both tabs now reads "Check in" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Sorry, I wasn't quite clear. I think it's helpful to have "select all | none" in the column header itself. I don't think we need to include it in the Column Settings menu that pops up when you click the Columns button. Your patch removes the wording in both places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- While I agree that it's confusing to see this in the column settings, I don't think it can be removed from one but not the other place. What you see in the "columns" list is build with JS from the table headings 1:1. Maybe the select all | none could be moved somewhere else? Or wrapped into a classs that is then hidden from the column listing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jacob.omara@ptfs-europe.com |ity.org | CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Changed assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
Maybe the select all | none could be moved somewhere else? Or wrapped into a classs that is then hidden from the column listing? Good idea. Looks like the column name comes from th aria-label attribute, that contains
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Heuuu this patch simply removes the checkboxes select feature. It is a regression. (In reply to Katrin Fischer from comment #3) the text-only version of th content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32322 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |MOVED Status|Failed QA |RESOLVED --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Jonathans been doing lots around this of late so I think it should be resolved there. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org