[Bug 32999] New: Click handler to show QR code in OPAC lacks preventDefault
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Bug ID: 32999 Summary: Click handler to show QR code in OPAC lacks preventDefault Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 23566 If you're scrolled down on the OPAC bibliographic detail page and click the "Send to device" link, the page jumps up to the top because the click handler doesn't have a "return false" or "event.preventDefault()". Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23566 [Bug 23566] Continue on device - with QR codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146857&action=edit Bug 32999: Click handler to show QR code in OPAC lacks preventDefault This patch adds "preventDefault()" to the click handler for showing the bibliographic detail QR code. This prevents the page from scrolling to the top when the user clicks the link. To test, apply the patch and make sure the OPACDetailQRCode system preference is enabled. Locate a bibliographic record and view the detail page. If necessary, reduce the size of your browser window so that you have to scroll down a bit to bring the "Send to device" menu item into view in the sidebar. Click the link to confirm that it shows the QR code and that the page doesn't jump to the top. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146857|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146869&action=edit Bug 32999: Click handler to show QR code in OPAC lacks preventDefault This patch adds "preventDefault()" to the click handler for showing the bibliographic detail QR code. This prevents the page from scrolling to the top when the user clicks the link. To test, apply the patch and make sure the OPACDetailQRCode system preference is enabled. Locate a bibliographic record and view the detail page. If necessary, reduce the size of your browser window so that you have to scroll down a bit to bring the "Send to device" menu item into view in the sidebar. Click the link to confirm that it shows the QR code and that the page doesn't jump to the top. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146869|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146900&action=edit Bug 32999: Click handler to show QR code in OPAC lacks preventDefault This patch adds "preventDefault()" to the click handler for showing the bibliographic detail QR code. This prevents the page from scrolling to the top when the user clicks the link. To test, apply the patch and make sure the OPACDetailQRCode system preference is enabled. Locate a bibliographic record and view the detail page. If necessary, reduce the size of your browser window so that you have to scroll down a bit to bring the "Send to device" menu item into view in the sidebar. Click the link to confirm that it shows the QR code and that the page doesn't jump to the top. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.11 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.04,22.05.11 |23.05.00,22.11.04,22.05.11, released in| |21.11.19 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org