[Bug 31609] New: JavaScript error on Additional contents -> Pages main page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Bug ID: 31609 Summary: JavaScript error on Additional contents -> Pages main page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There is JavaScript on the new Pages page which is supposed to check to see whether the view includes the tabs, i.e. on the edit page. The script needs to be more specific about what DOM elements to look for before it tries to grab information about the tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|JavaScript error on |JavaScript error on |Additional contents -> |Additional contents main |Pages main page |page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140919&action=edit Bug 31609: JavaScript error on Additional contents main page This patch makes a minor modification to the JavaScript on the Additional contents page to prevent an error when there are no tabs present on the page. The JS needs an additional check so that it doesn't run when there are no tabs. To test you should have more than one language installed. - Before the patch, you would see a JavaScript error in the console: "Uncaught TypeError: can't access property "hash", firstTab[0] is undefined." - Apply the patch and go to Tools -> Additional contents. - With the patch applied there should be no error on the additional contents main page. - Try creating or editing additional contents entries to confirm that the interface still works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- Failed QA because after applying the patch and go to go Tools > Additional contents: - error no longer appears when language is English - switch to another language installed: the error message reappears. Steps to reproduce (tested using KTD): 1. Install another language: koha-translate --install fr-CA 2. Add an additional contents entry. 3. Replicate the error as per the test plan. 4. Apply the patch - leave language as English, flush_memcached, restart_all, clear browser cache. 5. From the home page, go to Tools > Additional contents - there should be no error in the browser console. 6. Switch language to Français. 7. The error message is back! (Note that it doesn't happen when you switch back to English.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I think the issue is that you have to run the translate "update" command first, to rebuild the other language strings based on the patch's modified template. Then run the "install" command. Could you try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140919|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 140975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140975&action=edit Bug 31609: JavaScript error on Additional contents main page This patch makes a minor modification to the JavaScript on the Additional contents page to prevent an error when there are no tabs present on the page. The JS needs an additional check so that it doesn't run when there are no tabs. To test you should have more than one language installed. - Before the patch, you would see a JavaScript error in the console: "Uncaught TypeError: can't access property "hash", firstTab[0] is undefined." - Apply the patch and go to Tools -> Additional contents. - With the patch applied there should be no error on the additional contents main page. - Try creating or editing additional contents entries to confirm that the interface still works correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #3)
I think the issue is that you have to run the translate "update" command first, to rebuild the other language strings based on the patch's modified template. Then run the "install" command.
Thanks Owen! That made things work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The error is still present on the list view of Tools/Pages Uncaught TypeError: firstTab[0] is undefined <anonymous> https://master.rijkskoha.nl:28443/cgi-bin/koha/tools/additional-contents.pl?... jQuery 13 Template code: let firstTab = $("#tabs a:first"); firstTab.tab("show"); initTinyMce( firstTab[0].hash ); There should probably be a check on firstTab first :) The <div id="tabs" class="toptabs"> belongs to the detail page and not to the list view on the main page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The above proves that it was not trivial :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #6)
The error is still present on the list view of Tools/Pages
I don't see this. Could you please look again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #8)
(In reply to Marcel de Rooy from comment #6)
The error is still present on the list view of Tools/Pages
I don't see this. Could you please look again?
You need to hit Tools/Pages. The JS error is on the main page. Not the detail one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can see the JavaScript error as dscribed on Tools > News: Uncaught TypeError: firstTab[0] is undefined <anonymous> http://localhost:8081/cgi-bin/koha/tools/additional-contents.pl?category=new... jQuery 13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- With this patch, all 3, Pages, News and HTML customizations on longer show the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140975|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142574&action=edit Bug 31609: JavaScript error on Additional contents main page This patch makes a minor modification to the JavaScript on the Additional contents page to prevent an error when there are no tabs present on the page. The JS needs an additional check so that it doesn't run when there are no tabs. To test you should have more than one language installed. - Before the patch, you would see a JavaScript error in the console: "Uncaught TypeError: can't access property "hash", firstTab[0] is undefined." - Apply the patch and go to Tools -> Additional contents. - With the patch applied there should be no error on the additional contents main page. - Try creating or editing additional contents entries to confirm that the interface still works correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Confirming that I do not see the error either anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142574|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 142599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142599&action=edit Bug 31609: JavaScript error on Additional contents main page This patch makes a minor modification to the JavaScript on the Additional contents page to prevent an error when there are no tabs present on the page. The JS needs an additional check so that it doesn't run when there are no tabs. To test you should have more than one language installed. - Before the patch, you would see a JavaScript error in the console: "Uncaught TypeError: can't access property "hash", firstTab[0] is undefined." - Apply the patch and go to Tools -> Additional contents. - With the patch applied there should be no error on the additional contents main page. - Try creating or editing additional contents entries to confirm that the interface still works correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |arthur.suzuki@biblibre.com --- Comment #17 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- patch relies on initTinyMce function, which I can't find defined in 21.11. Won't apply as is. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org