[Bug 41035] New: bundle_remove click handler in returns.tt has invalid path component "item"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Bug ID: 41035 Summary: bundle_remove click handler in returns.tt has invalid path component "item" Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com The problem is that "...bundled_items/item/{bundled_item_id}" gives 404, should just be "bundled_items/{bundled_item_id}". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188019&action=edit Bug 41035: remove invalid path component 'item' To test: 1. Create a record as a collection with leader 007 set to c 2. Add some items on the same branch to the bundle 3. Check one item in 4. Observe that you get a 404 error and the item is not removed from the bundle 5. Apply the patch 6. Repeat step 3 7. Observe that the item is correctly removed (unlinked) from the bundle 8. Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188019|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 190652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190652&action=edit Bug 41035: remove invalid path component 'item' To test: 1. Create a record as a collection with leader 007 set to c 2. Add some items on the same branch to the bundle 3. Check one item in 4. Observe that you get a 404 error and the item is not removed from the bundle 5. Apply the patch 6. Repeat step 3 7. Observe that the item is correctly removed (unlinked) from the bundle 8. Sign off Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190652|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 192192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192192&action=edit Bug 41035: remove invalid path component 'item' To test: 1. Create a record as a collection with leader 007 set to c 2. Add some items on the same branch to the bundle 3. Check one item in 4. Observe that you get a 404 error and the item is not removed from the bundle 5. Apply the patch 6. Repeat step 3 7. Observe that the item is correctly removed (unlinked) from the bundle 8. Sign off Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- This works and is consistent with how the items API defines the endpoint for remove from bundle: "/items/{item_id}/bundled_items/{bundled_item_id}": delete: x-mojo-to: Items#remove_from_bundle operationId: removeFromBundle tags: - items summary: Remove item from bundle Nice work. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Testing note: You can use the following leader to create the record: 00000npc a2200000 4500 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41035 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org