https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #123 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Florent Mara from comment #122)

I agree with most of it - also I can't reproduce the failed tests - but I can fail other tests so some of these need to be reconsidered. $headerrow_0 shouldn't be there. Namespace uniformity sounds like an excellent idea, any suggestion/guidance?

Actually it was added by bug 14722 which is already pushed. I have added the topic to the next dev meeting, just in case (https://wiki.koha-community.org/wiki/Development_IRC_meeting_13_July_2016). I have already talked about this to someone, but I don't find anything.

The part that confuses me is around Moo usage and I assume the comment refers to Koha::Patrons::Import. The module has 2 attributes ('today_iso' and 'text_csv'), can these exist without importing Moo?

Yes of course. What you are doing is just initializing them, so you can do that in the constructor (new). -- You are receiving this mail because: You are watching all bug changes.