[Bug 35017] New: If creating items when ordering, an alert should appear if the item type is not filled out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35017 Bug ID: 35017 Summary: If creating items when ordering, an alert should appear if the item type is not filled out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Step to reproduce 1. Create a basket 2. Choose to create items upon ordering 3. Use either a new file or a staged file 4. When adding records to the basket, the required fields seem to only be fund and price. Fill out the required fields. 5. Close the basket 6. Go to receive from that vendor, - add invoice number, then see a 500 error instead of being able to receive anything from that vendor. When a basket is created in Acquisitions with the "create items on ordering", but the item type is not filled in, a 500 error will appear when attempting to receive. Although the item type is not required, thus allowing a user to go through the whole process only to receive a 500 error when receiving. This error will appear regardless of what the user is receiving if an order within that vendor has an order without an item type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35017 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35017 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- HI Kelly, the itemtype should always be made mandatory in the ACQ framework and then trigger when it's not filled in. But this was broken a little while ago, maybe you are on a broken version still? Bug 34109 - When adding items on receive, mandatory fields are not checked Or it#s maybe not set to be mandatory? It should be, otherwise those items break the OPAC detail view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35017 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- itemtype is set to mandatory for all new installations now (but was not in the past) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35017 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I just had this in a client installation. They had made the item type not mandatory in ACQ framework. I don't think it caused an error before since they never complained until we upgraded them to 23.05. I told them to make it mandatory again and batch modify the items that have itype is null. Maybe we could disable the mandatory checkbox for the field mapped to item type? Or make it not explode if the item type is null. Cait also suggested adding the check in the framework test, which could be an in between, but won't prevent errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35017 Daphne Hoolahan <dch@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch@interleaf.ie --- Comment #4 from Daphne Hoolahan <dch@interleaf.ie> --- Now that we are checking for item type throughout Koha, we should remove the option to untick the Mandatory box from all frameworks. If you cannot create an item without an item type, it will eliminate a lot of 'Error 500' messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org