https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Is this still valid after bug 16284? The need is specifically for serials, and that is covered in bug 16284. Would a library want to control CheckPrevCheckout per itemtype for other types of materials? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #3 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 156974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156974&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either: - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Must fix: In wants_check_for_previous_checkout we should pass the item _object rather than unblessed. This would let us use the effective_itemtype routine to get the itemtype (in the case where Record Level itemtypes might be in use) The schema changes should be in their own patch to allow the RM to regenerate In the tests it says new types are generated as NULL but it should say 'inherit' QA tool complains about tidiness Should fix: Why does the item type choice say :try and override"? Looks like the item type setting trumps all except hard syspref, and it won't display if hard syspref set? Could fix: You can use testbuilder to generate the types for testing, there is no need to specify item type code, just check against what is generated. Would fix: Test could be a bit more verbose to be readable, the map is not as clear as a straightforward loop would be, but I like the laid out matrix explaining the results The update could test for existence of column and not run when exists, but the construction you use does work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #8 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 165586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165586&action=edit Bug 20644: Add checkprevcheckout on item types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165585|0 |1 is obsolete| | Attachment #165586|0 |1 is obsolete| | --- Comment #9 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 165661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165661&action=edit Bug 20644: [DO NOT PUSH] DBIC Update I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #11 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- I changed "item_unblessed" to "item_object". Put the shema changes in a different patch. Adjusted the tidiness. But for the point where in the tests it's marked NULL and not "inherit" I don't know what you're talking about, because for me it's already marked "inherit" as requested. For the "should fix" point, could you be more precise? I don't know which part you're talking about. The same goes for the "would fix" part. Could you be more specific about how to improve test comprehension? For the "could fix" part, I've tried to change using the builder, but with the builder you can't create an "ItemType" with the value "checkprevcheckout" at "undef" because this field can't be empty, so the builder throws an error. I tried this: my $itemType1 = $builder->build_object({ class => 'Koha::ItemTypes', value => { checkprevcheckout => undef, } }); and I get this error: "Null value for checkprevcheckout in Itemtype not allowed at /inlibro/git/koha-master-dev-matthias/t/lib/TestBuilder.pm line 430." Tell me if there is another solution with the builder or if we leave it as it is now? Finally, for the last point about the script that adds the column, there's already something that tests whether the column exists, isn't there? with : "ALTER TABLE itemtypes ADD IF NOT EXISTS checkprevcheckout" Does "ADD IF NOT EXISTS" do this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #13 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Matthias Le Gac from comment #12)

But for the point where in the tests it's marked NULL and not "inherit" I don't know what you're talking about, because for me it's already marked "inherit" as requested.

t/db_dependent/Koha/ItemTypes.t: 180 'Two item types with \'checkprevcheckout\' set to \'undef\' have been added' It's just the comment there

For the "should fix" point, could you be more precise? I don't know which part you're talking about.

When editing an itemtype, it the system preference is 'soft' the options are: Yes and try to override system preference No and try to override system preference Inherit from system preference

From what I understand it does not 'try' to override, it always does I think we should also display the system preference when set to 'Hard' otherwise this can be a somewhat hidden feature

The same goes for the "would fix" part. Could you be more specific about how to improve test comprehension?

For me, 4 nested 'map' calls is a bit obfuscated. Clearer would be something like: foreach my $syspref_setting ('hardno','hardyes','softno','softyes'){ foreach my $itemtype_setting( 'inherit','no','yes'){ ... The output from your tests is clear, the matrix in the comments is clear, if large, it's a matter of preference but not a blocker

For the "could fix" part, I've tried to change using the builder, but with the builder you can't create an "ItemType" with the value "checkprevcheckout" at "undef" because this field can't be empty, so the builder throws an error. I tried this: my $itemType1 = $builder->build_object({ class => 'Koha::ItemTypes', value => { checkprevcheckout => undef, } }); and I get this error: "Null value for checkprevcheckout in Itemtype not allowed at /inlibro/git/koha-master-dev-matthias/t/lib/TestBuilder.pm line 430." Tell me if there is another solution with the builder or if we leave it as it is now?

t/db_dependent/Patron/Borrower_PrevCheckout.t 49 itemtype => 'YESIT', 59 itemtype => 'NOIT', 69 itemtype => 'INHERITIT' I just meant you don't need to specify the codes here, you use them later, but could save the generated codes as variables in the hash and reference them - this just ensures the tests won't have a conflict with existing data - rare, but slightly possible if tests die and rollback fails, etc. Again, not a blocker

Finally, for the last point about the script that adds the column, there's already something that tests whether the column exists, isn't there? with : "ALTER TABLE itemtypes ADD IF NOT EXISTS checkprevcheckout" Does "ADD IF NOT EXISTS" do this?

It does, but it is inconsistent with how we handle this in Koha: if( !column_exists( 'borrowers', 'middle_name' ) ) { I am not sure if your construction was blocked for being a MySQL-ism, but I on second glance it seems we should stick with the established pattern git grep column_exists git grep "ADD IF NOT EXISTS" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|emily-rose.francoeur@inLibr |hammat.wele@inlibro.com |o.com | CC|emily-rose.francoeur@inLibr |philippe.blouin@inlibro.com |o.com, | |matthias.le-gac@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165662|0 |1 is obsolete| | --- Comment #15 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170620&action=edit Bug 20644: Add checkprevcheckout on item types -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170620|0 |1 is obsolete| | --- Comment #17 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170622&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- It looks like a pretty simple rebase, just need to deal with bookings. Can the database updates be done in a separate commit when this is rebased? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170621|0 |1 is obsolete| | --- Comment #21 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 176538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176538&action=edit Bug 20644: [DO NOT PUSH] DBIC Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |william.lavoie@inLibro.com --- Comment #23 from William Lavoie <william.lavoie@inLibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178093|0 |1 is obsolete| | --- Comment #25 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 178094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178094&action=edit Bug 20644: [DO NOT PUSH] DBIC Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176539|0 |1 is obsolete| | --- Comment #27 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179813&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179813|0 |1 is obsolete| | --- Comment #29 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179815&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |laurence.rault@biblibre.com --- Comment #32 from Laurence Rault <laurence.rault@biblibre.com> --- Functionality is working as expected Test plan 18) Verify that all tests pass successfully : could not be tested on sandbox -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #34 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Emmi Takkinen from comment #33)

Tested this and in staff interface everything works as intended. However tests to not pass, they throw following errors:

t/db_dependent/Patron/Borrower_PrevCheckout.t .. 152/170 # Failed test 'PostIssue: Same item, same patron [1]' # at t/db_dependent/Patron/Borrower_PrevCheckout.t line 385. # got: '0' # expected: '1'

# Failed test 'PostIssue: Diff item, same bib, same patron [1]' # at t/db_dependent/Patron/Borrower_PrevCheckout.t line 385. # got: '0' # expected: '1'

# Failed test 'patron, wants_check_for_previous_checkout, do_check_for_previous_checkout' # at t/db_dependent/Patron/Borrower_PrevCheckout.t line 555. # got: undef # expected: '1'

# Failed test 'Check only one item if bibliographic record is serial' # at t/db_dependent/Patron/Borrower_PrevCheckout.t line 582. # got: '0' # expected: '1' # Looks like you failed 1 test of 2.

# Failed test 'Check previous checkouts for serial' # at t/db_dependent/Patron/Borrower_PrevCheckout.t line 592.

# Failed test 'no warnings' # at /usr/share/perl/5.34/Test/Builder.pm line 193. # There were 73 warning(s) .....

And:

t/db_dependent/Koha/ItemTypes.t .. 1/19 # Failed test 'item types should be sorted by translated description' # at t/db_dependent/Koha/ItemTypes.t line 115. # got: '14 vrk av' # expected: 'a translated itemtype desc'

# Failed test 'no warnings' # at /usr/share/perl/5.34/Test/Builder.pm line 193. # There were 9 warning(s)

Strange. I just ran these 2 tests and they pass with no warnings. Can we get a third input on this? Putting back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179814|0 |1 is obsolete| | --- Comment #36 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 181680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181680&action=edit Bug 20644: [DO NOT PUSH] DBIC Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hammat.wele@inlibro.com |shi-yao.wang@inLibro.com --- Comment #38 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181681|0 |1 is obsolete| | --- Comment #40 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 182470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182470&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. Signed-off-by: Laurence <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182470|0 |1 is obsolete| | --- Comment #42 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 182477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182477&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. Signed-off-by: Laurence <laurence.rault@biblibre.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182476|0 |1 is obsolete| | --- Comment #43 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 182787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182787&action=edit Bug 20644: [DO NOT PUSH] DBIC Update Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #45 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182787|0 |1 is obsolete| | --- Comment #46 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 183403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183403&action=edit Bug 20644: [DO NOT PUSH] DBIC Update Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182788|0 |1 is obsolete| | --- Comment #47 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 183404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183404&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. Signed-off-by: Laurence <laurence.rault@biblibre.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #49 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 183406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183406&action=edit Bug 20644: (QA follow-up) Remove duplicate variable I removed a duplicate variable and tidied. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183405|0 |1 is obsolete| | --- Comment #51 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 183408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183408&action=edit Bug 20644: (QA follow-up) [DO NOT PUSH] DBIC Update Tidied the DBIC update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #53 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- atomic update file seems tidy and tests seems to pass for me. could someone else check? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #55 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Lisette Scheer from comment #54)

I'm not seeing un-tidyness in the current db update.

Tests failed for me as well: Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/Koha/ItemTypes.t (Wstat: 2816 (exited 11) Tests: 16 Failed: 0) Non-zero exit status: 11 Parse errors: Bad plan. You planned 19 tests but ran 16. Files=1, Tests=16, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.08 cusr 0.12 csys = 1.22 CPU) Result: FAIL

* Proving /kohadevbox/koha/t/db_dependent/Patron/Borrower_PrevCheckout.t FAIL Error: value hash contains unrecognized columns: checkprevcheckout at /kohadevbox/koha/t/lib/TestBuilder.pm line 311. # Looks like your test exited with 11 just after 2. /kohadevbox/koha/t/db_dependent/Patron/Borrower_PrevCheckout.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 170/172 subtests

Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/Patron/Borrower_PrevCheckout.t (Wstat: 2816 (exited 11) Tests: 2 Failed: 0) Non-zero exit status: 11 Parse errors: Bad plan. You planned 172 tests but ran 2. Files=1, Tests=2, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.91 cusr 0.08 csys = 1.00 CPU) Result: FAIL

Here is what I get:

Test Summary Report ------------------- t/00-check-atomic-updates.t (Wstat: 256 (exited 1) Tests: 2 >Failed: 1) Failed test: 1 Non-zero exit status: 1 t/00-deprecated.t (Wstat: 256 (exited 1) Tests: 2 >Failed: 1) Failed test: 2 Non-zero exit status: 1 t/Creators.t (Wstat: 512 (exited 2) Tests: 42 >Failed: 2) Failed tests: 12, 14 Non-zero exit status: 2 Files=76, Tests=2220, 37 wallclock secs ( 0.27 usr 0.08 sys + 29.19 cusr 3.41 >csys = 32.95 CPU) Result: FAIL

the tests that fail except "t/00-check-atomic-updates.t" were already failing before the patches I'm not using kohadevbox so maybe that's why? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40337 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40337 [Bug 40337] checkprevcheckout must be defined as ENUM at DB level -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183404|0 |1 is obsolete| | --- Comment #58 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 185448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185448&action=edit Bug 20644: Add checkprevcheckout on item types I have added the "Check for previous checkouts" option to item types. This option is visible only when the system preference "CheckPrevCheckout" is set to either : - "Unless overridden by patron category or by item type, do" or - "Unless overridden by patron category or by item type, do not." This option takes precedence over patron and patron category preferences. TEST PLAN 1) Apply the patch. 2) Perform an atomic update (installer/data/mysql/updatedatabase.pl) 3) Set the "CheckPrevCheckout" system preference to "Unless overridden by patron category or by item type, do". 4) Go to "Koha administration > Item types > + New item type". 5) Fill in the necessary fields; the "Check for previous checkouts" field should be set to "Inherit from system preferences". 6) Click the "Save changes" button. 7) Create an item with the type you have created. 8) Check out this item for a patron, then check it in. 9) Check out the same item for the same patron again. 10) The message "Patron has previously checked out this title: <Title>. Check out anyway?" should appear. 11) Go to "Koha administration > Item types". 12) Edit the created item type. 13) Change the value of the "Check for previous checkouts" field to "No and try to override system preferences". 14) Click the "Save changes" button. 15) Check out the same item for the same patron. 16) The message should not appear. 17) Run the tests "Borrower_PrevCheckout.t" (prove t/db_dependent/Patron/Borrower_PrevCheckout.t) and "ItemTypes.t" (prove t/db_dependent/Koha/ItemTypes.t). 18) Verify that all tests pass successfully. Signed-off-by: Laurence <laurence.rault@biblibre.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #60 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 185450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185450&action=edit Bug 20644: [DO NOT PUSH] DBIC Update Tidied -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183408|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- I see the aforementioned tests are failing. Looking into it -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185449|0 |1 is obsolete| | --- Comment #65 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 185479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185479&action=edit Bug 20644: (QA follow-up) Remove duplicate variable I removed a duplicate variable and tidied. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185450|0 |1 is obsolete| | --- Comment #67 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 185481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185481&action=edit Bug 20644: [DO NOT PUSH] DBIC Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185479|0 |1 is obsolete| | --- Comment #70 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185558&action=edit Bug 20644: (QA follow-up) Remove duplicate variable I removed a duplicate variable and tidied. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185481|0 |1 is obsolete| | --- Comment #72 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 185560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185560&action=edit Bug 20644: [DO NOT PUSH] DBIC Update Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #73 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This is now causing t/db_dependent/api/v1/item_types.t to fail. Please follow-up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #75)

I think this causes a problem when editing an item type. I was trying to make an existing itemtype "bookable" and got the error message "An error occurred when updating this item type. Perhaps the value already exists.". When I looked into plack-intranet-error.log, it said "[2025/08/21 15:48:59] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'checkprevcheckout' cannot be null at /kohadevbox/koha/Koha/O bject.pm line 174"

If CheckPrevCheckout is set to one of the 'Unless overridden by...' option, I can edit and save my itemtype. If CheckPrevCheckout is set to 'Do' or 'Do not', I can't edit an itemtype.

I'll need a fix for this, and the tests I mention, before Monday. Or I will need to revert this, sorry. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #78 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- I got the code fix for Caroline's issue. I am trying to fix the tests as well to push both solutions in the same commit -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #80 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- We also need to fix the atomicupdate, ADD IF NOT EXISTS isn't right. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #82 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185669&action=edit Bug 20644: Update swagger definitions for checkprevcheck -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #84 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Lucas Gass (lukeg) from comment #79)

Created attachment 185665 [details] [review] Bug 20644: (follow-up) Dont allow NULL value when the dropdown doesnt exist

Would it be better if we assigned "inherit" by default at line 102? (In reply to Lucas Gass (lukeg) from comment #82)

Created attachment 185669 [details] [review] Bug 20644: Update swagger definitions for checkprevcheck

t/db_dependent/api/v1/item_types.t tests are still failing. and it would be more accurate to say:

description: Produce a warning for this item type if this item has previously been checked out to this patron if ''yes'', not if ''no'', defer to patron setting if ''inherit''.'

instead of

description: Produce a warning for this item type if this item has previously been checked out to this patron if ''yes'', not if ''no'', defer to syspref setting if ''inherit''.'

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185666|0 |1 is obsolete| | --- Comment #86 from David Nind <david@davidnind.com> --- Created attachment 185671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185671&action=edit Bug 20644: (follow-up) Fix atomicupdate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #88 from David Nind <david@davidnind.com> --- I added my signoffs to the three follow-ups (using KTD): 1. Applied follow-up patches (using interactive mode) 2. Updated the database (no messages output): updatedatabase 3. Updated things: yarn build 4. Restarted everything: restart_all 5. Tested this things: 5.1 Making an item type bookable 5.2 Repeat 5.1 with all the options for the CheckPrevCheckout system preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #90 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Nevermind about the tests not passing for me. I forgot to run `yarn api:bundle`. Now it works I will add a follow-up patch to correct the description in swagger definition and assign "inherit" by default -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adolfo.rodriguez@xercode.es --- Comment #92 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Is the IF NOT EXISTS really necessary in the file installer/data/mysql/db_revs/250600010.pl? It's already being checked before applying the SQL with !column_exists( 'itemtypes', 'checkprevcheckout' ) and it returns an error with versions of MySQL such as Ver 15.1 Distrib 10.1.48-MariaDB and Ver 8.0.31 Error message: ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF NOT EXISTS checkprevcheckout enum('yes', 'no', 'inherit') NOT NULL DEFAULT' at line 1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement extends release notes| |the CheckPrevCheckout | |functionality to item | |types. With this change, if | |the CheckPrevCheckouts | |system preference is set to | |either "Unless overridden | |by patron category or by | |item type, do" or "Unless | |overridden by patron | |category or by item type, | |do not", an additional | |option will appear in the | |item type definition. This | |allows libraries to | |customize whether Koha | |should warn staff when a | |patron has already checked | |out the same title, on a | |per–item type basis. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1095 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #96 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Manual edit already done! :) -- You are receiving this mail because: You are watching all bug changes.