[Bug 30966] New: Record Overlay Rules - Fault in Z39.50 filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Bug ID: 30966 Summary: Record Overlay Rules - Fault in Z39.50 filter Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bjornbibblan@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl We're setting up MARC Overlay Rules in 21.11.05. When defining the rules, we aren't able to make the filter Z39.50 work. A colleague checked the code and reports that line 876 in cataloguing/addbiblio.pl sets the source to z39.50. The source value should be z3950 to match the filter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Björn Hellberg <bjornbibblan@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Record Overlay Rules - |Record Overlay Rules - |Fault in Z39.50 filter |can't use Z39.50 filter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Björn, that's a great hint already - does your coworker want to provide a patch for this? We are happy to help with the steps! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #2 from Björn Hellberg <bjornbibblan@gmail.com> --- (In reply to Katrin Fischer from comment #1)
Hi Björn, that's a great hint already - does your coworker want to provide a patch for this? We are happy to help with the steps!
Hi, we've asked our administrators to check if this could be a solution. If it is, we'll ask them if they can provide a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #3 from Björn Hellberg <bjornbibblan@gmail.com> --- We've now edited the code as suggested, but it didn't work. All fields are protected except when replacing record via Z39.50/SRU search; if I replace the record this way, the fields that I've listed as protected are also edited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Depends on| |14957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #4 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- We found out that the protection applies only after you have saved the imported record, which is kind of confusing when looking the record on the editor. Fixing the z3950 syntax works but I think that there should be done something so the protected fields appear to the editor. If you have required fields then those have to be filled before save and the new values don't even apply because of the protection. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #5 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 138248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138248&action=edit Bug 30966: Record Overlay Rules - can't use Z39.50 filter This patch fixes overlay rules on z39.50 import Test plan: 1) Create protection overlay rule to some fields for z39.50. 2) Import a record via z39.50. 3) See that the protected fields are replaced on the editor. 4) Apply the patch. 5) Import a record again. 6) See that the protected fields are in place on the editor. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Rachael <rachael.laritz@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachael.laritz@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Rachael <rachael.laritz@inlibro.com> --- Attempted to apply patch, but terminal returned : error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138248|0 |1 is obsolete| | --- Comment #7 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 139014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139014&action=edit Record Overlay Rules - can't use Z39.50 filter I updated the patch, please try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140004&action=edit Bug 30966: Record Overlay Rules - can't use Z39.50 filter This patch fixes overlay rules on z39.50 import Test plan: 1) Create protection overlay rule to some fields for z39.50. 2) Import a record via z39.50. 3) See that the protected fields are replaced on the editor. 4) Apply the patch. 5) Import a record again. 6) See that the protected fields are in place on the editor. Sponsored-by: Koha-Suomi Oy Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Attachment #139014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC|victor@tuxayo.net | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Record Overlay Rules - |Record overlay rules - |can't use Z39.50 filter |can't use Z39.50 filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the * (all) case might not be covered properly yet: My overlay rules: * source * 245 Protect Skip... * source Z39.50 100 Protect Skip... * Download and save from LOC control number 9162774. Verify it has 245 and 100 set * Edit record * Replace record via Z39.50 search * 245: was updated * 100: remained unchanged * Save record * 245: was updated * 100: was protected Hopefully an easy fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Johanna, this is a rather bad bug. Could you have another look maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33268 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've retested this and I think the fix is correct, but there is another bug with the * rules not working as expected. I tested Z39.50 and Batch record modification with these rules: +----+-----+--------+----------+-----+--------+--------+--------+ | id | tag | module | filter | add | append | remove | delete | +----+-----+--------+----------+-----+--------+--------+--------+ | 3 | 245 | source | z3950 | 0 | 0 | 0 | 0 | | 4 | 300 | source | * | 0 | 0 | 0 | 0 | | 5 | 245 | source | batchmod | 0 | 0 | 0 | 0 | +----+-----+--------+----------+-----+--------+--------+--------+ With the patch applied * 245 was protected/unchanged in both cases = correct * 300 was unprotected/overwritten in both cases = incorrect So the * is not only an issue for z39.50 and I filed this separately as: Bug 33268 - Overlay rules don't work correctly when source is set to * Going to pass this, because it restores some of the promised functionality and works well! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140004|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 148375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148375&action=edit Bug 30966: Record Overlay Rules - can't use Z39.50 filter This patch fixes overlay rules on z39.50 import Test plan: 1) Create protection overlay rule to some fields for z39.50. 2) Import a record via z39.50. 3) See that the protected fields are replaced on the editor. 4) Apply the patch. 5) Import a record again. 6) See that the protected fields are in place on the editor. Sponsored-by: Koha-Suomi Oy Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05,22.05.12 |23.05.00,22.11.05,22.05.12, released in| |21.11.20 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rachael.laritz@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org