[Bug 34323] New: Enhance header search icon for more options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Bug ID: 34323 Summary: Enhance header search icon for more options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 34322 I'd like to update the markup in header search forms for the "more options" icon: Add a title attribute, and aria-hidden to the icon. I propose to update the style of the icon so that it has a different appearance when the more options are displayed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 [Bug 34322] Correct icon triggering more fund search options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153721&action=edit Bug 34323: Enhance header search icon for more options This patch modifies header search forms which have a "more options" icon, adding a title attribute to the control and "aria-hidden" to the Font Awesome icons. I've added a bit of CSS and JS to change the appearance of the icon when it is clicked to expand the panel of options. To test, apply the patch and rebuild the staff interface CSS. - Test pages which have a "more options" icon in the search header: - Home -> Catalog search tab, with IntranetCatalogSearchPulldown enabled. - Acquisitions -> Orders search tab - Authorities -> All search tabs - Administration -> Budgets - Patrons -> Patron search tab - Serials -> Subscription search tab - On all these pages, hovering your mouse over the icon in the search form should trigger a "More options" title. - Clicking the icon should expand the panel, and the icon should be now have a highlighted style. - Clicking the icon to collapse the panel should return the icon to its original state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153721|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 154228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154228&action=edit Bug 34323: Enhance header search icon for more options This patch modifies header search forms which have a "more options" icon, adding a title attribute to the control and "aria-hidden" to the Font Awesome icons. I've added a bit of CSS and JS to change the appearance of the icon when it is clicked to expand the panel of options. To test, apply the patch and rebuild the staff interface CSS. - Test pages which have a "more options" icon in the search header: - Home -> Catalog search tab, with IntranetCatalogSearchPulldown enabled. - Acquisitions -> Orders search tab - Authorities -> All search tabs - Administration -> Budgets - Patrons -> Patron search tab - Serials -> Subscription search tab - On all these pages, hovering your mouse over the icon in the search form should trigger a "More options" title. - Clicking the icon should expand the panel, and the icon should be now have a highlighted style. - Clicking the icon to collapse the panel should return the icon to its original state. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154228|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155076&action=edit Bug 34323: Enhance header search icon for more options This patch modifies header search forms which have a "more options" icon, adding a title attribute to the control and "aria-hidden" to the Font Awesome icons. I've added a bit of CSS and JS to change the appearance of the icon when it is clicked to expand the panel of options. To test, apply the patch and rebuild the staff interface CSS. - Test pages which have a "more options" icon in the search header: - Home -> Catalog search tab, with IntranetCatalogSearchPulldown enabled. - Acquisitions -> Orders search tab - Authorities -> All search tabs - Administration -> Budgets - Patrons -> Patron search tab - Serials -> Subscription search tab - On all these pages, hovering your mouse over the icon in the search form should trigger a "More options" title. - Clicking the icon should expand the panel, and the icon should be now have a highlighted style. - Clicking the icon to collapse the panel should return the icon to its original state. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34322 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Bug 34323 depends on bug 34322, which changed state. Bug 34322 Summary: Correct icon triggering more fund search options https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org