[Bug 41387] New: Add option for 2 digit month to serial patterns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 Bug ID: 41387 Summary: Add option for 2 digit month to serial patterns Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The manual says: Numbering formula: this is what is used to create the number for each issue. You can use placeholders for up to three variables {X}, {Y}, and {Z} (which can be defined below), as well as predetermined variables: {Day} will be replaced by the date (two digits) {Month} will be replaced by the month number (two digits) {Year} will be replaced by the year (four digits) {DayName} will be replaced by the name of the day of the week https://koha-community.org/manual/23.11/en/html/serials.html#adding-serial-n... But we actually replace the month with a single digit, we should have an option for 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190214&action=edit Bug 41387: Add option for 2 digit month to serials To test: 0 - Apply patch 1 - Setup a new numbering pattern Serials->Manage numbering patterns + New numbering pattern 2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Month2} {Day} {MonthName} {DayName} 3 - Populate X/Y/Z in the table as you wish, these should be unaffected by patch 4 - Set a Frequency / First issue plublication date / Subscription length 5 - Click 'Test pattern' 6 - Confirm the dates in the Number match the publication date values 7 - Try with different frequencies to confirm they match 8 - Save the pattern 9 - Create a new subscription and use the new pattern 10 - Confirm it works as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190215&action=edit Bug 41387: Add 2 digit day option as well While adding 2 digit months, let's add 2 digit days as well. These are necessary to ensure correct sorting, that is the reason for this request To test: 0 - Apply patch 1 - Setup a new numbering pattern Serials->Manage numbering patterns + New numbering pattern 2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Month2} {Day} {Day2} {MonthName} {DayName} 3 - Populate X/Y/Z in the table as you wish, these should be unaffected by patch 4 - Set a Frequency / First issue plublication date / Subscription length 5 - Click 'Test pattern' 6 - Confirm the dates in the Number match the publication date values 7 - Try with different frequencies to confirm they match 8 - Save the pattern 9 - Create a new subscription and use the new pattern 10 - Confirm it works as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |caroline.cyr-la-rose@inlibr | |o.com, david@davidnind.com Depends on| |35646 Text to go in the| |This adds some new release notes| |placeholders to be used | |within the numbering | |pattern of a subscription: | |{Day2} and {Month2}. They | |will be automatically | |replaced with the | |corresponding 2 digit value | |derived from the | |publication date of the | |issue when its received. Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646 [Bug 35646] Allow using the publication date parts for serial numbering -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190214|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190274&action=edit Bug 41387: Add option for 2 digit month to serials To test: 0 - Apply patch 1 - Setup a new numbering pattern Serials->Manage numbering patterns + New numbering pattern 2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Month2} {Day} {MonthName} {DayName} 3 - Populate X/Y/Z in the table as you wish, these should be unaffected by patch 4 - Set a Frequency / First issue plublication date / Subscription length 5 - Click 'Test pattern' 6 - Confirm the dates in the Number match the publication date values 7 - Try with different frequencies to confirm they match 8 - Save the pattern 9 - Create a new subscription and use the new pattern 10 - Confirm it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190215|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 190275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190275&action=edit Bug 41387: Add 2 digit day option as well While adding 2 digit months, let's add 2 digit days as well. These are necessary to ensure correct sorting, that is the reason for this request To test: 0 - Apply patch 1 - Setup a new numbering pattern Serials->Manage numbering patterns + New numbering pattern 2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Month2} {Day} {Day2} {MonthName} {DayName} 3 - Populate X/Y/Z in the table as you wish, these should be unaffected by patch 4 - Set a Frequency / First issue plublication date / Subscription length 5 - Click 'Test pattern' 6 - Confirm the dates in the Number match the publication date values 7 - Try with different frequencies to confirm they match 8 - Save the pattern 9 - Create a new subscription and use the new pattern 10 - Confirm it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m Status|Signed Off |Failed QA --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Tests are failing. There was a merge error as well. * Proving /kohadevbox/koha/t/db_dependent/Serials.t FAIL # Failed test 'GetNextSeq correctly calculates numbering from next published date' # at /kohadevbox/koha/t/db_dependent/Serials.t line 733. # got: '2026 13 13 Friday 2 02 February' # expected: '1970 1 01 Sunday 11 11 November' # Failed test 'GetNextSeq correctly calculates numbering from next published date, leap year' # at /kohadevbox/koha/t/db_dependent/Serials.t line 740. # got: '2026 13 13 Friday 2 02 February' # expected: '2024 29 29 Thursday 2 02 February' # Looks like you failed 2 tests of 4. # Failed test 'test numbering pattern with dates in GetSeq GetNextSeq' # at /kohadevbox/koha/t/db_dependent/Serials.t line 745. # Looks like you failed 1 test of 65. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190274|0 |1 is obsolete| | Attachment #190275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 206852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206852&action=edit Bug 41387: Add option for 2 digit month to serials To test: 0 - Apply patch 1 - Setup a new numbering pattern Serials->Manage numbering patterns + New numbering pattern 2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Month2} {Day} {MonthName} {DayName} 3 - Populate X/Y/Z in the table as you wish, these should be unaffected by patch 4 - Set a Frequency / First issue plublication date / Subscription length 5 - Click 'Test pattern' 6 - Confirm the dates in the Number match the publication date values 7 - Try with different frequencies to confirm they match 8 - Save the pattern 9 - Create a new subscription and use the new pattern 10 - Confirm it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 206853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206853&action=edit Bug 41387: Add 2 digit day option as well While adding 2 digit months, let's add 2 digit days as well. These are necessary to ensure correct sorting, that is the reason for this request To test: 0 - Apply patch 1 - Setup a new numbering pattern Serials->Manage numbering patterns + New numbering pattern 2 - In the numbering formula enter: {X} {Y} {Z} {Year} {Month} {Month2} {Day} {Day2} {MonthName} {DayName} 3 - Populate X/Y/Z in the table as you wish, these should be unaffected by patch 4 - Set a Frequency / First issue plublication date / Subscription length 5 - Click 'Test pattern' 6 - Confirm the dates in the Number match the publication date values 7 - Try with different frequencies to confirm they match 8 - Save the pattern 9 - Create a new subscription and use the new pattern 10 - Confirm it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41387 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 206854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206854&action=edit Bug 41387: (QA follow-up) Additional POD -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org