[Bug 15456] New: Fix tabs and inconsistent indentation in smart-rules.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Bug ID: 15456 Summary: Fix tabs and inconsistent indentation in smart-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46161&action=edit Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46161|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 46241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46241&action=edit [SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Looks like refactoring :) No regressions, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are patches in the queue waiting for SO and QA. I would prefer to wait before pushing this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46241|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46453&action=edit Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt To verify patch, run `git diff -w HEAD^' and note that the only changes shown are where [% IF %] statements are expanded/unexpanded onto multiple lines to match the prevailing style. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Looks like refactoring :) No regressions, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I looked it up with the splitter tool: bug 8367 - needs sign-off bug 15407 - needs sign-off bug 15354 - passed qa bug 9805 - failed qa bug 14695 - failed qa I'd like to wait a bit too - there is currently no new work dependent on the clean-up and it will make it harder for other patches. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org