http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-11-02 13:01:09 UTC --- I can confirm this: If you edit a patron record which has a NULL dateofbirth, and leave the birth date field blank, after saving the record the dateofbirth column contains "0000-00-00" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-17 15:40:09 UTC --- Created attachment 6327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6327 Proposed Patch Fixes dateofbirth issue, but makes a change deep in SQLHelper. Please test not only this bug, but also re-test bug 6253 to verify we're regression-free (my initial tests show that's so, but I could be missing something) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-11-17 19:27:59 UTC --- Created attachment 6330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6330 [Signed Off] Bug 7134: patron records getting corrupted birthdates If no date of birth is provided in a new member form, the borrower gets the birthdate of "00/02/0", which is obviously incorrect (the result of passing 0 to the database directly) The fix is to remove a conditional check buried deep in C4::SQLHelper. This is in a helper subroutine that was changed for the Unified Member Search dev (bug 6253). Reverting this small change to the conditional does not seem to break search, but testing will be required. To test: 1. apply patch, and create a new patron with blank birthdate. The new patron should now have a blank birthdate instead of '00/02/0' 2. search for a borrower by 1 part surname, confirm search works 3. search for a borrower by 2 part surname, confirm search works 4. search for a borrower across firstname AND surname; confirm 5. search for a borrower and include categorycode/branchcode filters Signed-off-by: Liz Rea <wizzyrea@gmail.com> I confirm all working tests 1-5 1. Created patron with blank birthdate - birthdate was blank 2. Searched for patron "henry james acevedo III" by using "acevedo" - result was correct 3. Searched for mr. acevedo using "Acevedo III" - result was correct 4. Searched for Henry James Acevedo III, Henry Acevedo and James Acevedo - results were correct 5. Searched for Mr Acevedo with the branch he was not in, with the branch he is in, with a category he was not, and a category he was. All results were correct. also noted: inner searching seems to be working now? Example: Henry James (firstname) Acevedo III (surname) - searching James Acevedo brings back the correct patron. Not complaining, just noting. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-18 22:03:01 UTC --- QA comment : small patch, addresses the problem, perfect test plan Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-06 15:53:52 UTC --- Deep and confusing problem in SQLHelper.pm. Not sure if the test can be corrected; logic still looks right. Any any change to SQLHelper will likely lead to more bugs elsewhere in the system. Not an easy issue to squelch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 --- Comment #10 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-12-06 16:15:06 UTC --- (In reply to comment #9)

(In reply to comment #8)

...

Deep and confusing problem in SQLHelper.pm. Not sure if the test can be corrected; logic still looks right. Any any change to SQLHelper will likely lead to more bugs elsewhere in the system.

Ian, i'm not sure the problem comes from SQLHelper here. It's probably the test that must be fixed. I had a look, but I don't understand well how it works, I still have to investigate more.

Perhaps hdl could look into this since he wrote SQLHelper? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7134 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This was included in the 3.6 branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.